FreakU
/
Retrospring
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move user service into an instance variable 

Co-authored-by: nilsding <nilsding@nilsding.org>
This commit is contained in:
Karina Kwiatek 2023-01-02 09:09:29 +01:00
parent d320a74045
commit 02bcfb3c9e
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/workers/share_worker.rb
View File

@ -9,9 +9,9 @@ class ShareWorker
# @param answer_id [Integer] the user id # @param answer_id [Integer] the user id
# @param service [String] the service to post to # @param service [String] the service to post to
def perform(user_id, answer_id, service) def perform(user_id, answer_id, service)
user_service = find_service(user_id, service) @user_service = User.find(user_id).services.find_by(type: "Services::#{service.camelize}")
user_service.post(Answer.find(answer_id)) @user_service.post(Answer.find(answer_id))
rescue ActiveRecord::RecordNotFound rescue ActiveRecord::RecordNotFound
logger.info "Tried to post answer ##{answer_id} for user ##{user_id} to #{service.titleize} but the user/answer/service did not exist (likely deleted), will not retry." logger.info "Tried to post answer ##{answer_id} for user ##{user_id} to #{service.titleize} but the user/answer/service did not exist (likely deleted), will not retry."
# The question to be posted was deleted # The question to be posted was deleted
@ -31,8 +31,7 @@ class ShareWorker
end end
def revoke_and_notify(user_id, service) def revoke_and_notify(user_id, service)
user_service = find_service(user_id, service) @user_service.destroy
user_service.destroy
Object.const_get("Notification::ServiceTokenExpired").create( Object.const_get("Notification::ServiceTokenExpired").create(
target_id: user_id, target_id: user_id,
@ -41,6 +40,4 @@ class ShareWorker
new: true new: true
) )
end end
def find_service(user_id, service) = User.find(user_id).services.find_by(type: "Services::#{service.camelize}")
end end