Reformat services controller spec

spec/controllers/services_controller_spec.rb

@@ -1,17 +1,19 @@
-require 'rails_helper'
+# frozen_string_literal: true
+
+require "rails_helper"
 
 describe ServicesController, type: :controller do
-  context 'successful Twitter sign in' do
+  context "successful Twitter sign in" do
     let(:user) { FactoryBot.create(:user) }
 
     before do
       sign_in user
       OmniAuth.config.test_mode = true
       OmniAuth.config.mock_auth[:twitter] = OmniAuth::AuthHash.new({
-                                                                     'provider' => 'twitter',
+                                                                     "provider"    => "twitter",
-                                                                     'uid' => '12',
+                                                                     "uid"         => "12",
-                                                                     'info' => { 'nickname' => 'jack' },
+                                                                     "info"        => { "nickname" => "jack" },
-                                                                     'credentials' => { 'token' => 'AAAA', 'secret' => 'BBBB' }
+                                                                     "credentials" => { "token" => "AAAA", "secret" => "BBBB" }
                                                                    })
       request.env["omniauth.auth"] = OmniAuth.config.mock_auth[:twitter]
     end
@@ -20,58 +22,58 @@ describe ServicesController, type: :controller do
       OmniAuth.config.mock_auth[:twitter] = nil
     end
 
-    subject { get :create, params: { provider: 'twitter' } }
+    subject { get :create, params: { provider: "twitter" } }
 
-    context 'no services connected' do
+    context "no services connected" do
-      it 'creates a service integration' do
+      it "creates a service integration" do
         expect { subject }.to change { Service.count }.by(1)
       end
     end
 
-    context 'a user has a service connected' do
+    context "a user has a service connected" do
       let(:other_user) { FactoryBot.create(:user) }
       let!(:service) { Services::Twitter.create(user: other_user, uid: 12) }
 
-      it 'shows an error when trying to attach a service account which is already connected' do
+      it "shows an error when trying to attach a service account which is already connected" do
         subject
         expect(flash[:error]).to eq("The Twitter account you are trying to connect is already connected to another #{APP_CONFIG['site_name']} account. If you are unable to disconnect the account yourself, please send us a Direct Message on Twitter: @retrospring.")
       end
     end
   end
 
-  context '#update' do
+  context "#update" do
-    subject { patch :update, params: params }
+    subject { patch :update, params: }
 
-    context 'not signed in' do
+    context "not signed in" do
       let(:params) { { id: 1 } }
 
-      it 'redirects to sign in page' do
+      it "redirects to sign in page" do
         subject
         expect(response).to redirect_to(new_user_session_path)
       end
     end
 
-    context 'user with Twitter connection' do
+    context "user with Twitter connection" do
       before { sign_in user }
 
       let(:user) { FactoryBot.create(:user) }
-      let(:service) { Services::Twitter.create(user: user, uid: 12) }
+      let(:service) { Services::Twitter.create(user:, uid: 12) }
-      let(:params) { { id: service.id, service: { post_tag: post_tag } } }
+      let(:params) { { id: service.id, service: { post_tag: } } }
 
-      context 'tag is valid' do
+      context "tag is valid" do
-        let(:post_tag) { '#askaraccoon' }
+        let(:post_tag) { "#askaraccoon" }
 
-        it 'updates a service connection' do
+        it "updates a service connection" do
-          expect { subject }.to change { service.reload.post_tag }.to('#askaraccoon')
+          expect { subject }.to change { service.reload.post_tag }.to("#askaraccoon")
           expect(response).to redirect_to(services_path)
           expect(flash[:success]).to eq("Service updated successfully.")
         end
       end
 
-      context 'tag is too long' do
+      context "tag is too long" do
-        let(:post_tag) { 'a' * 21 }  # 1 character over the limit
+        let(:post_tag) { "a" * 21 }  # 1 character over the limit
 
-        it 'shows an error' do
+        it "shows an error" do
           subject
           expect(response).to redirect_to(services_path)
           expect(flash[:error]).to eq("Unable to update service.")