From 10473f4ed0ffaf20863f73b1396f2fccf61778ab Mon Sep 17 00:00:00 2001 From: Andreas Nedbal Date: Thu, 26 Oct 2023 21:38:21 +0200 Subject: [PATCH] Remove `Ajax::RelationshipController` and spec --- .../ajax/relationship_controller.rb | 35 ---- .../ajax/relationship_controller_spec.rb | 153 ------------------ 2 files changed, 188 deletions(-) delete mode 100644 app/controllers/ajax/relationship_controller.rb delete mode 100644 spec/controllers/ajax/relationship_controller_spec.rb diff --git a/app/controllers/ajax/relationship_controller.rb b/app/controllers/ajax/relationship_controller.rb deleted file mode 100644 index ba9f4546..00000000 --- a/app/controllers/ajax/relationship_controller.rb +++ /dev/null @@ -1,35 +0,0 @@ -# frozen_string_literal: true - -class Ajax::RelationshipController < AjaxController - before_action :authenticate_user! - - def create - params.require :screen_name - - UseCase::Relationship::Create.call( - source_user: current_user, - target_user: ::User.find_by!(screen_name: params[:screen_name]), - type: params[:type] - ) - @response[:success] = true - @response[:message] = t(".#{params[:type]}.success") - rescue Errors::Base => e - @response[:message] = t(e.locale_tag) - ensure - return_response - end - - def destroy - UseCase::Relationship::Destroy.call( - source_user: current_user, - target_user: ::User.find_by!(screen_name: params[:screen_name]), - type: params[:type] - ) - @response[:success] = true - @response[:message] = t(".#{params[:type]}.success") - rescue Errors::Base => e - @response[:message] = t(e.locale_tag) - ensure - return_response - end -end diff --git a/spec/controllers/ajax/relationship_controller_spec.rb b/spec/controllers/ajax/relationship_controller_spec.rb deleted file mode 100644 index 11d2ddbd..00000000 --- a/spec/controllers/ajax/relationship_controller_spec.rb +++ /dev/null @@ -1,153 +0,0 @@ -# coding: utf-8 -# frozen_string_literal: true - -require "rails_helper" - -describe Ajax::RelationshipController, type: :controller do - shared_examples_for "params is empty" do - let(:params) { {} } - - include_examples "ajax does not succeed", "is required" - end - - let!(:user) { FactoryBot.create(:user) } - let!(:user2) { FactoryBot.create(:user) } - - describe "#create" do - shared_examples_for "valid relationship type" do - it_behaves_like "params is empty" - - context "screen_name does not exist" do - let(:screen_name) { "peter-witzig" } - - include_examples "ajax does not succeed", "not found" - end - - context "screen_name is current user" do - let(:screen_name) { user.screen_name } - - include_examples "ajax does not succeed", "yourself" - end - - context "screen_name is different from current_user" do - let(:screen_name) { user2.screen_name } - - it "creates the relationship" do - expect { subject }.to change { Relationship.count }.by(1) - expect(Relationship.last.target.screen_name).to eq(screen_name) - end - end - end - - let(:type) { "Sauerkraut" } - let(:screen_name) { user2.screen_name } - let(:params) { { type: type, screen_name: screen_name } } - - subject { post(:create, params: params) } - - it_behaves_like "requires login" - - context "user signed in" do - before(:each) { sign_in(user) } - - context "type = 'follow'" do - let(:type) { "follow" } - - include_examples "valid relationship type" - - context "target user mutes source user" do - before do - user2.mute(user) - end - - it "creates the relationship but no notification" do - expect { subject }.to change { Notification.count }.by(0) - end - end - end - - context "type = 'block'" do - let(:type) { "block" } - - include_examples "valid relationship type" - end - - context "type = 'mute'" do - let(:type) { "mute" } - - include_examples "valid relationship type" - end - - context "type = 'dick'" do - let(:type) { "dick" } - - it_behaves_like "params is empty" - include_examples "ajax does not succeed", "Invalid parameter" - end - end - end - - describe "#destroy" do - shared_examples_for "valid relationship type" do - let(:screen_name) { user2.screen_name } - - context "relationship exists" do - before do - user.public_send(type, user2) - end - - it "destroys a relationship" do - expect { subject }.to change { Relationship.count }.by(-1) - end - end - - context "relationship does not exist" do - it "does not change anything at all" do - expect { subject }.to change { Relationship.count }.by(0) - end - end - - context "screen_name does not exist" do - let(:screen_name) { "peter-witzig" } - - include_examples "ajax does not succeed", "not found" - end - end - - let(:type) { "Sauerkraut" } - let(:screen_name) { user2.screen_name } - let(:params) { { type: type, screen_name: screen_name } } - - subject { delete(:destroy, params: params) } - - it_behaves_like "requires login" - - context "user signed in" do - before(:each) { sign_in(user) } - - context "type = 'follow'" do - let(:type) { "follow" } - - include_examples "valid relationship type" - end - - context "type = 'block'" do - let(:type) { "block" } - - include_examples "valid relationship type" - end - - context "type = 'mute'" do - let(:type) { "mute" } - - include_examples "valid relationship type" - end - - context "type = 'dick'" do - let(:type) { "dick" } - - include_examples "ajax does not succeed", "Invalid parameter" - end - end - end -end