FreakU
/
Retrospring
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove legacy SmileController

This commit is contained in:
Andreas Nedbal 2023-10-31 23:33:10 +01:00 committed by Andreas Nedbal
parent 9872d3aace
commit 4e434dd268
3 changed files with 0 additions and 429 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

85
app/controllers/ajax/smile_controller.rb
View File

@ -1,85 +0,0 @@
class Ajax::SmileController < AjaxController
def create
params.require :id
answer = Answer.find(params[:id])
begin
current_user.smile answer
rescue Errors::Base => e
@response[:status] = e.code
@response[:message] = I18n.t(e.locale_tag)
return
rescue => e
Sentry.capture_exception(e)
@response[:status] = :fail
@response[:message] = t(".error")
return
end
@response[:status] = :okay
@response[:message] = t(".success")
@response[:success] = true
end
def destroy
params.require :id
answer = Answer.find(params[:id])
begin
current_user.unsmile answer
rescue => e
Sentry.capture_exception(e)
@response[:status] = :fail
@response[:message] = t(".error")
return
end
@response[:status] = :okay
@response[:message] = t(".success")
@response[:success] = true
end
def create_comment
params.require :id
comment = Comment.find(params[:id])
begin
current_user.smile comment
rescue Errors::Base => e
@response[:status] = e.code
@response[:message] = I18n.t(e.locale_tag)
return
rescue => e
Sentry.capture_exception(e)
@response[:status] = :fail
@response[:message] = t(".error")
return
end
@response[:status] = :okay
@response[:message] = t(".success")
@response[:success] = true
end
def destroy_comment
params.require :id
comment = Comment.find(params[:id])
begin
current_user.unsmile comment
rescue => e
Sentry.capture_exception(e)
@response[:status] = :fail
@response[:message] = t(".error")
return
end
@response[:status] = :okay
@response[:message] = t(".success")
@response[:success] = true
end
end

4
config/routes.rb
View File

@ -118,10 +118,6 @@ Rails.application.routes.draw do
post "/destroy_answer", to: "answer#destroy", as: :destroy_answer post "/destroy_answer", to: "answer#destroy", as: :destroy_answer
post "/create_relationship", to: "relationship#create", as: :create_relationship post "/create_relationship", to: "relationship#create", as: :create_relationship
post "/destroy_relationship", to: "relationship#destroy", as: :destroy_relationship post "/destroy_relationship", to: "relationship#destroy", as: :destroy_relationship
post "/create_smile", to: "smile#create", as: :create_smile
post "/destroy_smile", to: "smile#destroy", as: :destroy_smile
post "/create_comment_smile", to: "smile#create_comment", as: :create_comment_smile
post "/destroy_comment_smile", to: "smile#destroy_comment", as: :destroy_comment_smile
post "/create_comment", to: "comment#create", as: :create_comment post "/create_comment", to: "comment#create", as: :create_comment
post "/destroy_comment", to: "comment#destroy", as: :destroy_comment post "/destroy_comment", to: "comment#destroy", as: :destroy_comment
post "/report", to: "report#create", as: :report post "/report", to: "report#create", as: :report

340
spec/controllers/ajax/smile_controller_spec.rb
View File

@ -1,340 +0,0 @@
# coding: utf-8
# frozen_string_literal: true
require "rails_helper"
describe Ajax::SmileController, :ajax_controller, type: :controller do
describe "#create" do
let(:params) do
{
id: answer_id
}.compact
end
let(:answer) { FactoryBot.create(:answer, user: user) }
subject { post(:create, params: params) }
context "when user is signed in" do
before(:each) { sign_in(user) }
context "when answer exists" do
let(:answer_id) { answer.id }
let(:expected_response) do
{
"success" => true,
"status" => "okay",
"message" => anything
}
end
it "creates a smile to the answer" do
expect { subject }.to(change { Reaction.count }.by(1))
expect(answer.reload.smiles.ids).to include(Reaction.last.id)
end
include_examples "returns the expected response"
end
context "when answer does not exist" do
let(:answer_id) { "nein!" }
let(:expected_response) do
{
"success" => false,
"status" => anything,
"message" => anything
}
end
it "does not create a smile" do
expect { subject }.not_to(change { Reaction.count })
end
include_examples "returns the expected response"
end
context "when some parameters are missing" do
let(:answer_id) { nil }
let(:expected_response) do
{
"success" => false,
"status" => "parameter_error",
"message" => anything
}
end
include_examples "returns the expected response"
end
end
context "when user is not signed in" do
let(:answer_id) { answer.id }
let(:expected_response) do
{
"success" => false,
"status" => "fail",
"message" => anything
}
end
include_examples "returns the expected response"
end
context "when blocked by the answer's author" do
let(:other_user) { FactoryBot.create(:user) }
let(:answer) { FactoryBot.create(:answer, user: other_user) }
let(:answer_id) { answer.id }
before do
other_user.block(user)
end
let(:expected_response) do
{
"success" => false,
"status" => "fail",
"message" => anything
}
end
it "does not create a smile" do
expect { subject }.not_to(change { Reaction.count })
end
include_examples "returns the expected response"
end
context "when blocking the answer's author" do
let(:other_user) { FactoryBot.create(:user) }
let(:answer) { FactoryBot.create(:answer, user: user) }
let(:answer_id) { answer.id }
before do
user.block(other_user)
end
let(:expected_response) do
{
"success" => false,
"status" => "fail",
"message" => anything
}
end
it "does not create a smile" do
expect { subject }.not_to(change { Reaction.count })
end
include_examples "returns the expected response"
end
end
describe "#destroy" do
let(:answer) { FactoryBot.create(:answer, user: user) }
let(:smile) { FactoryBot.create(:smile, user: user, parent: answer) }
let(:answer_id) { answer.id }
let(:params) do
{
id: answer_id
}
end
subject { delete(:destroy, params: params) }
context "when user is signed in" do
before(:each) { sign_in(user) }
context "when the smile exists" do
# ensure we already have it in the db
before(:each) { smile }
let(:expected_response) do
{
"success" => true,
"status" => "okay",
"message" => anything
}
end
it "deletes the smile" do
expect { subject }.to(change { Reaction.count }.by(-1))
end
include_examples "returns the expected response"
end
context "when the smile does not exist" do
let(:answer_id) { "sonic_the_hedgehog" }
let(:expected_response) do
{
"success" => false,
"status" => anything,
"message" => anything
}
end
include_examples "returns the expected response"
end
end
context "when user is not signed in" do
let(:expected_response) do
{
"success" => false,
"status" => "fail",
"message" => anything
}
end
include_examples "returns the expected response"
end
end
describe "#create_comment" do
let(:params) do
{
id: comment_id
}.compact
end
let(:answer) { FactoryBot.create(:answer, user: user) }
let(:comment) { FactoryBot.create(:comment, user: user, answer: answer) }
subject { post(:create_comment, params: params) }
context "when user is signed in" do
before(:each) { sign_in(user) }
context "when comment exists" do
let(:comment_id) { comment.id }
let(:expected_response) do
{
"success" => true,
"status" => "okay",
"message" => anything
}
end
it "creates a smile to the comment" do
expect { subject }.to(change { Reaction.count }.by(1))
expect(comment.reload.smiles.ids).to include(Reaction.last.id)
end
include_examples "returns the expected response"
end
context "when comment does not exist" do
let(:comment_id) { "nein!" }
let(:expected_response) do
{
"success" => false,
"status" => anything,
"message" => anything
}
end
it "does not create a smile" do
expect { subject }.not_to(change { Reaction.count })
end
include_examples "returns the expected response"
end
context "when some parameters are missing" do
let(:comment_id) { nil }
let(:expected_response) do
{
"success" => false,
"status" => "parameter_error",
"message" => anything
}
end
include_examples "returns the expected response"
end
end
context "when user is not signed in" do
let(:comment_id) { comment.id }
let(:expected_response) do
{
"success" => false,
"status" => "fail",
"message" => anything
}
end
include_examples "returns the expected response"
end
end
describe "#destroy_comment" do
let(:answer) { FactoryBot.create(:answer, user: user) }
let(:comment) { FactoryBot.create(:comment, user: user, answer: answer) }
let(:comment_smile) { FactoryBot.create(:comment_smile, user: user, parent: comment) }
let(:comment_id) { comment.id }
let(:params) do
{
id: comment_id
}
end
subject { delete(:destroy_comment, params: params) }
context "when user is signed in" do
before(:each) { sign_in(user) }
context "when the smile exists" do
# ensure we already have it in the db
before(:each) { comment_smile }
let(:expected_response) do
{
"success" => true,
"status" => "okay",
"message" => anything
}
end
it "deletes the smile" do
expect { subject }.to(change { Reaction.count }.by(-1))
end
include_examples "returns the expected response"
end
context "when the smile does not exist" do
let(:answer_id) { "sonic_the_hedgehog" }
let(:expected_response) do
{
"success" => false,
"status" => anything,
"message" => anything
}
end
include_examples "returns the expected response"
end
end
context "when user is not signed in" do
let(:expected_response) do
{
"success" => false,
"status" => "fail",
"message" => anything
}
end
include_examples "returns the expected response"
end
end
end