add spec for Ajax::AnswerController

Gemfile

@@ -91,6 +91,7 @@ group :development, :test do
   gem 'puma'
   gem 'rspec-rails', '~> 3.9'
   gem 'rspec-its', '~> 1.3'
+  gem "rspec-sidekiq", "~> 3.0"
   gem 'factory_bot_rails', require: false
   gem 'faker'
   gem 'capybara'

Gemfile.lock

@@ -406,6 +406,9 @@ GEM
       rspec-expectations (~> 3.9.0)
       rspec-mocks (~> 3.9.0)
       rspec-support (~> 3.9.0)
+    rspec-sidekiq (3.0.3)
+      rspec-core (~> 3.0, >= 3.0.0)
+      sidekiq (>= 2.4.0)
     rspec-support (3.9.2)
     ruby-progressbar (1.10.1)
     sanitize (5.1.0)
@@ -564,6 +567,7 @@ DEPENDENCIES
   rolify (~> 5.2)
   rspec-its (~> 1.3)
   rspec-rails (~> 3.9)
+  rspec-sidekiq (~> 3.0)
   ruby-progressbar
   sanitize
   sass-rails (~> 5.0)

spec/controllers/ajax/answer_controller_spec.rb

@@ -0,0 +1,290 @@
+# coding: utf-8
+# frozen_string_literal: true
+
+require "rails_helper"
+
+describe Ajax::AnswerController, type: :controller do
+  shared_examples "returns the expected response" do
+    it "returns the expected response" do
+      expect(JSON.parse(subject.body)).to match(expected_response)
+    end
+  end
+
+  let(:user) { FactoryBot.create(:user) }
+  let(:question) { FactoryBot.create(:question, user: FactoryBot.build(:user, privacy_allow_stranger_answers: asker_allows_strangers)) }
+  let(:asker_allows_strangers) { true }
+
+  describe "#create" do
+    let(:params) do
+      {
+        id: id,
+        answer: answer,
+        share: shared_services&.to_json,
+        inbox: inbox
+      }.compact
+    end
+
+    subject { post(:create, params: params) }
+
+    context "when user is signed in" do
+      shared_examples "creates the answer" do
+        it "creates an answer" do
+          expect { subject }.to(change { Answer.count }.by(1))
+        end
+
+        it "enqueues a job for sharing the answer to social networks" do
+          subject
+          expect(ShareWorker).to have_enqueued_sidekiq_job(user.id, Answer.last.id, shared_services)
+        end
+
+        include_examples "returns the expected response"
+      end
+
+      shared_examples "does not create the answer" do
+        it "does not create an answer" do
+          expect { subject }.not_to(change { Answer.count })
+        end
+
+        it "does not enqueue a job for sharing the answer to social networks" do
+          subject
+          expect(ShareWorker).not_to have_enqueued_sidekiq_job(anything, anything, anything)
+        end
+
+        include_examples "returns the expected response"
+      end
+
+      shared_examples "fails when answer content is empty" do
+        let(:expected_response) do
+          {
+            "success" => false,
+            # caught by rescue_from, so status is not peter_dinklage
+            "status" => "parameter_error",
+            "message" => anything
+          }
+        end
+
+        ["", "    ", "\r  \n"].each do |a|
+          context "when answer is #{a.inspect}" do
+            let(:answer) { a }
+            include_examples "does not create the answer"
+          end
+        end
+      end
+
+      before(:each) { sign_in(user) }
+
+      context "when all parameters are given" do
+        let(:answer) { "Werfen Sie nicht länger das Fenster zum Geld hinaus!" }
+        let(:shared_services) { %w[twitter] }
+
+        context "when inbox is true" do
+          let(:id) { FactoryBot.create(:inbox, user: inbox_user, question: question).id }
+          let(:inbox) { true }
+
+          context "when the inbox entry belongs to the user" do
+            let(:inbox_user) { user }
+            let(:expected_response) do
+              {
+                "success" => true,
+                "status" => "okay",
+                "message" => anything
+              }
+            end
+
+            include_examples "creates the answer"
+
+            it_behaves_like "fails when answer content is empty"
+          end
+
+          context "when the inbox entry does not belong to the user" do
+            let(:inbox_user) { FactoryBot.create(:user) }
+            let(:expected_response) do
+              {
+                "success" => false,
+                "status" => "fail",
+                "message" => anything
+              }
+            end
+
+            include_examples "does not create the answer"
+
+            it_behaves_like "fails when answer content is empty"
+          end
+        end
+
+        context "when inbox is false" do
+          let(:id) { question.id }
+          let(:inbox) { false }
+
+          context "when question asker allows strangers to answer (i.e. question was not in inbox)" do
+            let(:asker_allows_strangers) { true }
+            let(:expected_response) do
+              {
+                "success" => true,
+                "status" => "okay",
+                "message" => anything,
+                "render" => anything
+              }
+            end
+
+            include_examples "creates the answer"
+
+            it_behaves_like "fails when answer content is empty"
+          end
+
+          context "when question asker does not allow strangers to answer (i.e. question was not in inbox)" do
+            let(:asker_allows_strangers) { false }
+            let(:expected_response) do
+              {
+                "success" => false,
+                "status" => "privacy_stronk",
+                "message" => anything
+              }
+            end
+
+            include_examples "does not create the answer"
+          end
+        end
+      end
+
+      context "when some parameters are missing" do
+        let(:id) { nil }
+        let(:answer) { "Trollolo" }
+        let(:inbox) { nil }
+        let(:shared_services) { [] }
+
+        let(:expected_response) do
+          {
+            "success" => false,
+            # caught by rescue_from, so status is not peter_dinklage
+            "status" => "parameter_error",
+            "message" => anything
+          }
+        end
+
+        include_examples "returns the expected response"
+      end
+    end
+
+    context "when user is not signed in" do
+      let(:id) { question.id }
+      let(:inbox) { false }
+      let(:shared_services) { %w[twitter] }
+      let(:answer) { "HACKED" }
+
+      let(:expected_response) do
+        {
+          "success" => false,
+          "status" => "err",
+          "message" => anything
+        }
+      end
+
+      include_examples "returns the expected response"
+    end
+  end
+
+  describe "#destroy" do
+    let(:answer_user) { user }
+    let(:question) { FactoryBot.create(:question, user: FactoryBot.create(:user)) }
+    let(:answer) { FactoryBot.create(:answer, user: answer_user, question: question) }
+    let(:answer_id) { answer.id }
+
+    let(:params) do
+      {
+        answer: answer_id
+      }
+    end
+
+    subject { delete(:destroy, params: params) }
+
+    context "when user is signed in" do
+      shared_examples "deletes the answer" do
+        let(:expected_response) do
+          {
+            "success" => true,
+            "status" => "okay",
+            "message" => anything
+          }
+        end
+
+        it "deletes the answer" do
+          answer # ensure we already have it in the db
+          expect { subject }.to(change { Answer.count }.by(-1))
+        end
+
+        include_examples "returns the expected response"
+      end
+
+      shared_examples "does not delete the answer" do
+        let(:expected_response) do
+          {
+            "success" => false,
+            "status" => "nopriv",
+            "message" => anything
+          }
+        end
+
+        it "does not delete the answer" do
+          answer # ensure we already have it in the db
+          expect { subject }.not_to(change { Answer.count })
+        end
+
+        include_examples "returns the expected response"
+      end
+
+      before(:each) { sign_in(user) }
+
+      context "when the answer exists and was made by the current user" do
+        include_examples "deletes the answer"
+
+        it "returns the question back to the user's inbox" do
+          expect { subject }.to(change { Inbox.where(question_id: answer.question.id, user_id: user.id).count }.by(1))
+        end
+      end
+
+      context "when the answer exists and was not made by the current user" do
+        let(:answer_user) { FactoryBot.create(:user) }
+        include_examples "does not delete the answer"
+
+        %i[moderator administrator].each do |privileged_role|
+          context "when the current user is a #{privileged_role}" do
+            around do |example|
+              user.add_role privileged_role
+              example.run
+              user.remove_role privileged_role
+            end
+
+            include_examples "deletes the answer"
+          end
+        end
+      end
+
+      context "when the answer does not exist" do
+        let(:answer_id) { "sonic_the_hedgehog" }
+
+        let(:expected_response) do
+          {
+            "success" => false,
+            "status" => anything,
+            "message" => anything
+          }
+        end
+
+        include_examples "returns the expected response"
+      end
+    end
+
+    context "when user is not signed in" do
+      let(:expected_response) do
+        {
+          "success" => false,
+          "status" => "nopriv",
+          "message" => anything
+        }
+      end
+
+      include_examples "returns the expected response"
+    end
+  end
+end

spec/factories/inbox.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :inbox do
+    question { FactoryBot.build(:question) }
+    new { true }
+  end
+end