From 58705fffba417db7210c36500487ab7b448c3196 Mon Sep 17 00:00:00 2001
From: Georg Gadinger <nilsding@nilsding.org>
Date: Tue, 24 Jan 2023 15:54:41 +0100
Subject: [PATCH] mark notifications as "read" in the controller and when you
 see them

this makes it behave a bit more like the inbox
---
 app/controllers/notifications_controller.rb       | 7 +++++++
 app/views/layouts/notifications.html.haml         | 1 -
 spec/controllers/notifications_controller_spec.rb | 4 ++++
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/app/controllers/notifications_controller.rb b/app/controllers/notifications_controller.rb
index 6f6f0e91..0655c3c3 100644
--- a/app/controllers/notifications_controller.rb
+++ b/app/controllers/notifications_controller.rb
@@ -3,6 +3,8 @@
 class NotificationsController < ApplicationController
   before_action :authenticate_user!
 
+  after_action :mark_notifications_as_read, only: %i[index]
+
   TYPE_MAPPINGS = {
     "answer"       => Notification::QuestionAnswered.name,
     "comment"      => Notification::Commented.name,
@@ -25,6 +27,11 @@ class NotificationsController < ApplicationController
 
   private
 
+  def mark_notifications_as_read
+    # using .dup to not modify @notifications -- useful in tests
+    @notifications&.dup&.update_all(new: false)
+  end
+
   def cursored_notifications_for(type:, last_id:, size: nil)
     cursor_params = { last_id: last_id, size: size }.compact
 
diff --git a/app/views/layouts/notifications.html.haml b/app/views/layouts/notifications.html.haml
index dceb6d47..08d8ad1d 100644
--- a/app/views/layouts/notifications.html.haml
+++ b/app/views/layouts/notifications.html.haml
@@ -8,5 +8,4 @@
 .d-block.d-sm-none= render "shared/links"
 
 :ruby
-  Notification.for(current_user).where(new: true).update_all(new: false)
   parent_layout 'base'
diff --git a/spec/controllers/notifications_controller_spec.rb b/spec/controllers/notifications_controller_spec.rb
index f89db5fb..bcae9a8d 100644
--- a/spec/controllers/notifications_controller_spec.rb
+++ b/spec/controllers/notifications_controller_spec.rb
@@ -33,5 +33,9 @@ describe NotificationsController do
       expect(response).to render_template(:index)
       expect(controller.instance_variable_get(:@notifications)).to have_attributes(size: 2)
     end
+
+    it "marks notifications as read" do
+      expect { subject }.to change { Notification.for(user).where(new: true).count }.from(2).to(0)
+    end
   end
 end