add spec for Ajax::GroupController

app/controllers/ajax/group_controller.rb

@@ -19,7 +19,7 @@ class Ajax::GroupController < AjaxController
     params.require :user
 
     begin
-      target_user = User.find_by_screen_name(params[:user])
+      target_user = User.find_by_screen_name!(params[:user])
       group = Group.create! user: current_user, display_name: params[:name]
     rescue ActiveRecord::RecordInvalid => e
       NewRelic::Agent.notice_error(e)
@@ -85,7 +85,7 @@ class Ajax::GroupController < AjaxController
     add = params[:add] == 'true'
 
     begin
-      group = current_user.groups.find_by_name(params[:group])
+      group = current_user.groups.find_by_name!(params[:group])
     rescue ActiveRecord::RecordNotFound => e
       NewRelic::Agent.notice_error(e)
       @response[:status] = :notfound
@@ -93,7 +93,7 @@ class Ajax::GroupController < AjaxController
       return
     end
 
-    target_user = User.find_by_screen_name(params[:user])
+    target_user = User.find_by_screen_name!(params[:user])
 
     if add
       group.add_member target_user if group.members.find_by_user_id(target_user.id).nil?

spec/controllers/ajax/group_controller_spec.rb

@@ -0,0 +1,341 @@
+# frozen_string_literal: true
+
+require "rails_helper"
+
+describe Ajax::GroupController, :ajax_controller, type: :controller do
+  let(:target_user) { FactoryBot.create(:user) }
+
+  describe "#create" do
+    let(:name) { "I signori della gallassia" }
+    let(:target_user_param) { target_user.screen_name }
+    let(:params) do
+      {
+        "name" => name,
+        "user" => target_user_param
+      }
+    end
+
+    subject { post(:create, params: params) }
+
+    context "when user is signed in" do
+      let(:expected_response) do
+        {
+          "success" => true,
+          "status" => "okay",
+          "message" => anything,
+          "render" => anything
+        }
+      end
+
+      before(:each) { sign_in(user) }
+
+      it "creates the group" do
+        expect { subject }.to(change { user.groups.count }.by(1))
+      end
+
+      include_examples "returns the expected response"
+
+      context "when name param is missing" do
+        let(:name) { "" }
+        let(:expected_response) do
+          {
+            "success" => false,
+            "status" => "toolong",
+            "message" => anything
+          }
+        end
+
+        it "does not create the group" do
+          expect { subject }.not_to(change { user.groups.count })
+        end
+
+        include_examples "returns the expected response"
+      end
+
+      context "when target user does not exist" do
+        let(:target_user_param) { "giuseppe-drogo" }
+        let(:expected_response) do
+          {
+            "success" => false,
+            "status" => "notfound",
+            "message" => anything
+          }
+        end
+
+        it "does not create the group" do
+          expect { subject }.not_to(change { user.groups.count })
+        end
+
+        include_examples "returns the expected response"
+      end
+
+      context "when group name is invalid for reasons" do
+        let(:name) { "\u{1f43e}" }
+        let(:expected_response) do
+          {
+            "success" => false,
+            "status" => "toolong",
+            "message" => anything
+          }
+        end
+
+        it "does not create the group" do
+          expect { subject }.not_to(change { user.groups.count })
+        end
+
+        include_examples "returns the expected response"
+      end
+
+      context "when group already exists" do
+        before(:each) { post(:create, params: params) }
+        let(:expected_response) do
+          {
+            "success" => false,
+            "status" => "exists",
+            "message" => anything
+          }
+        end
+
+        it "does not create the group" do
+          expect { subject }.not_to(change { user.groups.count })
+        end
+
+        include_examples "returns the expected response"
+      end
+
+      context "when someone else created a group with the same name" do
+        before(:each) do
+          FactoryBot.create(:group, user: target_user, display_name: name)
+        end
+
+        it "creates the group" do
+          expect { subject }.to(change { user.groups.count }.by(1))
+        end
+
+        include_examples "returns the expected response"
+      end
+    end
+
+    context "when user is not signed in" do
+      let(:expected_response) do
+        {
+          "success" => false,
+          "status" => "noauth",
+          "message" => anything
+        }
+      end
+
+      include_examples "returns the expected response"
+    end
+  end
+
+  describe "#destroy" do
+    let(:name) { "I signori della gallassia" }
+    let(:group) { FactoryBot.create(:group, user: user, display_name: name) }
+    let(:group_param) { group.name }
+    let(:params) do
+      {
+        "group" => group_param
+      }
+    end
+
+    subject { delete(:destroy, params: params) }
+
+    context "when user is signed in" do
+      let(:expected_response) do
+        {
+          "success" => true,
+          "status" => "okay",
+          "message" => anything
+        }
+      end
+
+      before(:each) { sign_in(user) }
+
+      it "deletes the group" do
+        group
+        expect { subject }.to(change { user.groups.count }.by(-1))
+      end
+
+      include_examples "returns the expected response"
+
+      context "when group param is missing" do
+        let(:group_param) { "" }
+        let(:expected_response) do
+          {
+            "success" => false,
+            "status" => "parameter_error",
+            "message" => anything
+          }
+        end
+
+        it "does not delete the group" do
+          expect { subject }.not_to(change { user.groups.count })
+        end
+
+        include_examples "returns the expected response"
+      end
+
+      context "when group does not exist" do
+        let(:group_param) { "the-foobars-and-the-dingdongs" }
+        let(:expected_response) do
+          {
+            "success" => false,
+            "status" => "err",
+            "message" => anything
+          }
+        end
+
+        it "does not delete the group" do
+          expect { subject }.not_to(change { user.groups.count })
+        end
+
+        include_examples "returns the expected response"
+      end
+
+      context "when someone else created a group with the same name" do
+        before(:each) do
+          group
+          FactoryBot.create(:group, user: target_user, display_name: name)
+        end
+
+        it "deletes the group" do
+          expect { subject }.to(change { user.groups.count }.by(-1))
+        end
+
+        it "does not delete the other users' group" do
+          expect { subject }.not_to(change { target_user.groups.count })
+        end
+
+        include_examples "returns the expected response"
+      end
+    end
+
+    context "when user is not signed in" do
+      let(:expected_response) do
+        {
+          "success" => false,
+          "status" => "noauth",
+          "message" => anything
+        }
+      end
+
+      include_examples "returns the expected response"
+    end
+  end
+
+  describe "#membership" do
+    let(:name) { "The Agency" }
+    let(:members) { [] }
+    let(:group) { FactoryBot.create(:group, user: user, display_name: name, members: members) }
+    let(:group_param) { group.name }
+    let(:target_user_param) { target_user.screen_name }
+    let(:params) do
+      {
+        "group" => group_param,
+        "user" => target_user_param,
+        "add" => add_param
+      }
+    end
+
+    subject { post(:membership, params: params) }
+
+    context "when user is signed in" do
+      let(:expected_response) do
+        {
+          "success" => true,
+          "status" => "okay",
+          "message" => anything,
+          "checked" => expected_checked
+        }
+      end
+
+      before(:each) { sign_in(user) }
+
+      context "when add is false" do
+        let(:add_param) { "false" }
+        let(:expected_checked) { false }
+
+        it "does not do anything" do
+          expect { subject }.not_to(change { group.members })
+          expect(group.members.map { |gm| gm.user.id }.sort ).to eq([])
+        end
+
+        include_examples "returns the expected response"
+
+        context "when the user was already added to the group" do
+          let(:members) { [target_user] }
+
+          it "removes the user from the group" do
+            expect { subject }.to(change { group.reload.members.map { |gm| gm.user.id }.sort }.from([target_user.id]).to([]))
+          end
+
+          include_examples "returns the expected response"
+        end
+      end
+
+      context "when add is true" do
+        let(:add_param) { "true" }
+        let(:expected_checked) { true }
+
+        it "adds the user to the group" do
+          expect { subject }.to(change { group.reload.members.map { |gm| gm.user.id }.sort }.from([]).to([target_user.id]))
+        end
+
+        include_examples "returns the expected response"
+
+        context "when the user was already added to the group" do
+          let(:members) { [target_user] }
+
+          it "does not add the user to the group again" do
+            expect { subject }.not_to(change { group.members })
+            expect(group.members.map { |gm| gm.user.id }.sort ).to eq([target_user.id])
+          end
+
+          include_examples "returns the expected response"
+        end
+      end
+
+      context "when group does not exist" do
+        let(:group_param) { "the-good-agency" }
+        let(:add_param) { "add" }
+        let(:expected_response) do
+          {
+            "success" => false,
+            "status" => "notfound",
+            "message" => anything
+          }
+        end
+
+        include_examples "returns the expected response"
+      end
+
+      context "when target user does not exist" do
+        let(:target_user_param) { "erwin-proell" }
+        let(:add_param) { "add" }
+        let(:expected_response) do
+          {
+            "success" => false,
+            "status" => "not_found",
+            "message" => anything
+          }
+        end
+
+        include_examples "returns the expected response"
+      end
+    end
+
+    context "when user is not signed in" do
+      let(:add_param) { "whatever" }
+      let(:expected_response) do
+        {
+          "success" => false,
+          "status" => "noauth",
+          "message" => anything
+        }
+      end
+
+      include_examples "returns the expected response"
+    end
+  end
+end

spec/factories/group.rb

@@ -4,5 +4,15 @@ FactoryBot.define do
   factory :group do
     sequence(:display_name) { |i| "#{Faker::Internet.username(specifier: 0..12, separators: %w[_])}#{i}" }
     user { FactoryBot.build(:user) }
+
+    transient do
+      members { [] }
+    end
+
+    after(:create) do |group, evaluator|
+      evaluator.members.each do |member|
+        GroupMember.create(group_id: group.id, user_id: member.id)
+      end
+    end
   end
 end