Merge pull request #187 from Retrospring/fix/question-link-visibility

Show question link for answered questions with only one answer

app/controllers/ajax/question_controller.rb

@@ -32,7 +32,8 @@ class Ajax::QuestionController < AjaxController
     begin
       question = Question.create!(content: params[:question],
                                   author_is_anonymous: is_never_anonymous ? false : params[:anonymousQuestion],
-                                  user: current_user)
+                                  user: current_user,
+                                  direct: params[:rcpt] != 'followers')
     rescue ActiveRecord::RecordInvalid => e
       NewRelic::Agent.notice_error(e)
       @response[:status] = :rec_inv

app/views/answerbox/_header.haml

@@ -24,7 +24,7 @@
                   View in Kontrollzentrum
       %h6.text-muted.media-heading.answerbox__question-user
         = raw t('views.answerbox.asked', user: user_screen_name(a.question.user, anonymous: a.question.author_is_anonymous), time: time_tooltip(a.question))
-        - if !a.question.author_is_anonymous && a.question.answer_count > 1
+        - if !a.question.author_is_anonymous && !a.question.direct
           ·
           %a{ href: show_user_question_path(a.question.user.screen_name, a.question.id) }
             = pluralize(a.question.answer_count, t('views.general.answer'))

db/migrate/20210811133004_add_direct_to_questions.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+class AddDirectToQuestions < ActiveRecord::Migration[5.2]
+  def change
+    add_column :questions, :direct, :boolean, null: false, default: false
+
+    # default all legacy questions to direct
+    execute 'UPDATE questions SET direct = true;'
+
+    # All questions where
+    # - the author is not 'justask' (generated questions), and
+    # - the question wasn't asked anonymously
+    # can be direct or not.  This depends on if the question has more than one answer
+    execute "
+UPDATE questions
+SET direct = (NOT (questions.answer_count > 1))
+WHERE author_name <> 'justask'
+   OR NOT author_is_anonymous;"
+
+    # All questions which exist in at least more than one inbox are not direct
+    execute "
+UPDATE questions
+SET direct = false
+WHERE id IN (
+    SELECT question_id FROM inboxes GROUP BY question_id HAVING count(question_id) > 1
+);"
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2020_11_01_155648) do
+ActiveRecord::Schema.define(version: 2021_08_11_133004) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -125,6 +125,7 @@ ActiveRecord::Schema.define(version: 2020_11_01_155648) do
     t.datetime "created_at"
     t.datetime "updated_at"
     t.integer "answer_count", default: 0, null: false
+    t.boolean "direct", default: false, null: false
     t.index ["user_id", "created_at"], name: "index_questions_on_user_id_and_created_at"
   end
 

spec/controllers/ajax/question_controller_spec.rb

@@ -10,6 +10,7 @@ describe Ajax::QuestionController, :ajax_controller, type: :controller do
         expect(Question.last.content).to eq(question_content)
         expect(Question.last.author_is_anonymous).to be(expected_question_anonymous)
         expect(Question.last.user).to eq(expected_question_user)
+        expect(Question.last.direct).to eq(expected_question_direct)
       end
 
       if check_for_inbox
@@ -85,6 +86,7 @@ describe Ajax::QuestionController, :ajax_controller, type: :controller do
 
         context "when user allows anonymous questions" do
           let(:user_allows_anonymous_questions) { true }
+          let(:expected_question_direct) { true }
 
           context "when anonymousQuestion is true" do
             let(:anonymous_question) { "true" }
@@ -120,6 +122,7 @@ describe Ajax::QuestionController, :ajax_controller, type: :controller do
           context "when anonymousQuestion is false" do
             let(:anonymous_question) { "false" }
             let(:expected_question_anonymous) { false }
+            let(:expected_question_direct) { true }
 
             include_examples "creates the question"
           end
@@ -128,6 +131,7 @@ describe Ajax::QuestionController, :ajax_controller, type: :controller do
 
       context "when rcpt is followers" do
         let(:rcpt) { "followers" }
+        let(:expected_question_direct) { false }
 
         context "when anonymousQuestion is true" do
           let(:anonymous_question) { "true" }
@@ -182,6 +186,7 @@ describe Ajax::QuestionController, :ajax_controller, type: :controller do
 
         context "when user allows anonymous questions" do
           let(:user_allows_anonymous_questions) { true }
+          let(:expected_question_direct) { true }
 
           include_examples "creates the question"