Clean up Rakefile

Rakefile

@@ -1,21 +1,21 @@
+# frozen_string_literal: true
+
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
-require File.expand_path('../config/application', __FILE__)
+require File.expand_path("config/application", __dir__)
 
 Rails.application.load_tasks
 
 namespace :justask do
   desc "Upload to AWS"
   task paperclaws: :environment do
-    if APP_CONFIG["fog"]["credentials"].nil? or APP_CONFIG["fog"]["credentials"]["provider"] != "AWS"
+    throw "Needs fog (AWS) to be defined in justask.yml" if APP_CONFIG["fog"]["credentials"].nil? || (APP_CONFIG["fog"]["credentials"]["provider"] != "AWS")
-      throw "Needs fog (AWS) to be defined in justask.yml"
-    end
 
-    format = '%t (%c/%C) [%b>%i] %e'
+    format = "%t (%c/%C) [%b>%i] %e"
-    root = "#{Rails.root}/public/system"
+    root = Rails.root.join("/public/system")
     files = Dir["#{root}/**/*.*"]
-    progress = ProgressBar.create title: 'Processing files', format: format, starting_at: 0, total: files.length
+    progress = ProgressBar.create(title: "Processing files", format:, starting_at: 0, total: files.length)
 
     # weird voodoo, something is causing just using "APP_CONFIG["fog"]["credentials"]" as Fog::Storage.new to cause an exception
     # TODO: Programmatically copy?
@@ -39,29 +39,25 @@ namespace :justask do
 
   desc "Recount everything!"
   task recount: :environment do
-    format = '%t (%c/%C) [%b>%i] %e'
+    format = "%t (%c/%C) [%b>%i] %e"
     total = User.count
-    progress = ProgressBar.create title: 'Processing users', format: format, starting_at: 0, total: total
+    progress = ProgressBar.create(title: "Processing users", format:, starting_at: 0, total:)
     User.all.each do |user|
       begin
-        answered = Answer.where(user: user).count
+        user.answered_count = Answer.where(user:).count
-        asked = Question.where(user: user).where(author_is_anonymous: false).count
+        user.asked_count = Question.where(user:).where(author_is_anonymous: false).count
-        commented = Comment.where(user: user).count
+        user.commented_count = Comment.where(user:).count
-        smiled = Smile.where(user: user).count
+        user.smiled_count = Appendable::Reaction.where(user:).count
-        user.answered_count = answered
-        user.asked_count = asked
-        user.commented_count = commented
-        user.smiled_count = smiled
         user.save!
       end
       progress.increment
     end
 
     total = Question.count
-    progress = ProgressBar.create title: 'Processing questions', format: format, starting_at: 0, total: total
+    progress = ProgressBar.create(title: "Processing questions", format:, starting_at: 0, total:)
     Question.all.each do |question|
       begin
-        answers = Answer.where(question: question).count
+        answers = Answer.where(question:).count
         question.answer_count = answers
         question.save!
       end
@@ -69,13 +65,11 @@ namespace :justask do
     end
 
     total = Answer.count
-    progress = ProgressBar.create title: 'Processing answers', format: format, starting_at: 0, total: total
+    progress = ProgressBar.create(title: "Processing answers", format:, starting_at: 0, total:)
     Answer.all.each do |answer|
       begin
-        smiles = Smile.where(answer: answer).count
+        answer.comment_count = Comment.where(answer:).count
-        comments = Comment.where(answer: answer).count
+        answer.smile_count = Appendable::Reaction.where(answer:).count
-        answer.comment_count = comments
-        answer.smile_count = smiles
         answer.save!
       end
       progress.increment
@@ -83,10 +77,10 @@ namespace :justask do
   end
 
   desc "Gives admin status to a user."
-  task :admin, [:screen_name] => :environment do |t, args|
+  task :admin, [:screen_name] => :environment do |_t, args|
     abort "screen name required" if args[:screen_name].nil?
 
-    user = User.find_by_screen_name(args[:screen_name])
+    user = User.find_by(screen_name: args[:screen_name])
     abort "user #{args[:screen_name]} not found" if user.nil?
 
     user.add_role :administrator
@@ -94,10 +88,10 @@ namespace :justask do
   end
 
   desc "Removes admin status from a user."
-  task :deadmin, [:screen_name] => :environment do |t, args|
+  task :deadmin, [:screen_name] => :environment do |_t, args|
     abort "screen name required" if args[:screen_name].nil?
 
-    user = User.find_by_screen_name(args[:screen_name])
+    user = User.find_by(screen_name: args[:screen_name])
     abort "user #{args[:screen_name]} not found" if user.nil?
 
     user.remove_role :administrator
@@ -105,10 +99,10 @@ namespace :justask do
   end
 
   desc "Gives moderator status to a user."
-  task :mod, [:screen_name] => :environment do |t, args|
+  task :mod, [:screen_name] => :environment do |_t, args|
     abort "screen name required" if args[:screen_name].nil?
 
-    user = User.find_by_screen_name(args[:screen_name])
+    user = User.find_by(screen_name: args[:screen_name])
     abort "user #{args[:screen_name]} not found" if user.nil?
 
     user.add_role :moderator
@@ -116,10 +110,10 @@ namespace :justask do
   end
 
   desc "Removes moderator status from a user."
-  task :demod, [:screen_name] => :environment do |t, args|
+  task :demod, [:screen_name] => :environment do |_t, args|
     abort "screen name required" if args[:screen_name].nil?
 
-    user = User.find_by_screen_name(args[:screen_name])
+    user = User.find_by(screen_name: args[:screen_name])
     abort "user #{args[:screen_name]} not found" if user.nil?
 
     user.remove_role :moderator
@@ -127,83 +121,92 @@ namespace :justask do
   end
 
   desc "Hits an user with the banhammer."
-  task :permanently_ban, [:screen_name, :reason] => :environment do |t, args|
+  task :permanently_ban, %i[screen_name reason] => :environment do |_t, args|
-    fail "screen name required" if args[:screen_name].nil?
+    raise "screen name required" if args[:screen_name].nil?
-    user = User.find_by_screen_name(args[:screen_name])
+
-    fail "user #{args[:screen_name]} not found" if user.nil?
+    user = User.find_by(screen_name: args[:screen_name])
+    raise "user #{args[:screen_name]} not found" if user.nil?
+
     UseCase::User::Ban.call(
       target_user_id: user.id,
       expiry:         nil,
-      reason: args[:reason],
+      reason:         args[:reason]
     )
     puts "#{user.screen_name} got hit by\033[5m YE OLDE BANHAMMER\033[0m!!1!"
   end
 
   desc "Hits an user with the banhammer for one day."
-  task :ban, [:screen_name, :reason] => :environment do |t, args|
+  task :ban, %i[screen_name reason] => :environment do |_t, args|
-    fail "screen name required" if args[:screen_name].nil?
+    raise "screen name required" if args[:screen_name].nil?
-    user = User.find_by_screen_name(args[:screen_name])
+
+    user = User.find_by(screen_name: args[:screen_name])
     UseCase::User::Ban.call(
       target_user_id: user.id,
       expiry:         DateTime.current + 1,
-      reason: args[:reason],
+      reason:         args[:reason]
     )
     puts "#{user.screen_name} got hit by\033[5m YE OLDE BANHAMMER\033[0m!!1!"
   end
 
   desc "Hits an user with the banhammer for one week."
-  task :week_ban, [:screen_name, :reason] => :environment do |t, args|
+  task :week_ban, %i[screen_name reason] => :environment do |_t, args|
-    fail "screen name required" if args[:screen_name].nil?
+    raise "screen name required" if args[:screen_name].nil?
-    user = User.find_by_screen_name(args[:screen_name])
+
+    user = User.find_by(screen_name: args[:screen_name])
     UseCase::User::Ban.call(
       target_user_id: user.id,
       expiry:         DateTime.current + 7,
-      reason: args[:reason],
+      reason:         args[:reason]
     )
     puts "#{user.screen_name} got hit by\033[5m YE OLDE BANHAMMER\033[0m!!1!"
   end
 
   desc "Hits an user with the banhammer for one month."
-  task :month_ban, [:screen_name, :reason] => :environment do |t, args|
+  task :month_ban, %i[screen_name reason] => :environment do |_t, args|
-    fail "screen name required" if args[:screen_name].nil?
+    raise "screen name required" if args[:screen_name].nil?
-    user = User.find_by_screen_name(args[:screen_name])
+
+    user = User.find_by(screen_name: args[:screen_name])
     UseCase::User::Ban.call(
       target_user_id: user.id,
       expiry:         DateTime.current + 30,
-      reason: args[:reason],
+      reason:         args[:reason]
     )
     puts "#{user.screen_name} got hit by\033[5m YE OLDE BANHAMMER\033[0m!!1!"
   end
 
   desc "Hits an user with the banhammer for one year."
-  task :year_ban, [:screen_name, :reason] => :environment do |t, args|
+  task :year_ban, %i[screen_name reason] => :environment do |_t, args|
-    fail "screen name required" if args[:screen_name].nil?
+    raise "screen name required" if args[:screen_name].nil?
-    user = User.find_by_screen_name(args[:screen_name])
+
+    user = User.find_by(screen_name: args[:screen_name])
     UseCase::User::Ban.call(
       target_user_id: user.id,
       expiry:         DateTime.current + 365,
-      reason: args[:reason],
+      reason:         args[:reason]
     )
     puts "#{user.screen_name} got hit by\033[5m YE OLDE BANHAMMER\033[0m!!1!"
   end
 
   desc "Hits an user with the banhammer for one aeon."
-  task :aeon_ban, [:screen_name, :reason] => :environment do |t, args|
+  task :aeon_ban, %i[screen_name reason] => :environment do |_t, args|
-    fail "screen name required" if args[:screen_name].nil?
+    raise "screen name required" if args[:screen_name].nil?
-    user = User.find_by_screen_name(args[:screen_name])
+
+    user = User.find_by(screen_name: args[:screen_name])
     UseCase::User::Ban.call(
       target_user_id: user.id,
       expiry:         DateTime.current + 365_000_000_000,
-      reason: args[:reason],
+      reason:         args[:reason]
     )
     puts "#{user.screen_name} got hit by\033[5m YE OLDE BANHAMMER\033[0m!!1!"
   end
 
   desc "Removes banned status from an user."
-  task :unban, [:screen_name] => :environment do |t, args|
+  task :unban, [:screen_name] => :environment do |_t, args|
-    fail "screen name required" if args[:screen_name].nil?
+    raise "screen name required" if args[:screen_name].nil?
-    user = User.find_by_screen_name(args[:screen_name])
+
-    fail "user #{args[:screen_name]} not found" if user.nil?
+    user = User.find_by(screen_name: args[:screen_name])
+    raise "user #{args[:screen_name]} not found" if user.nil?
+
     UseCase::User::Unban.call(user.id)
     puts "#{user.screen_name} is no longer banned."
   end
@@ -211,7 +214,7 @@ namespace :justask do
   desc "Lists all users."
   task lusers: :environment do
     User.all.each do |u|
-      puts "#{sprintf "%3d", u.id}. #{u.screen_name}"
+      puts "#{format '%3d', u.id}. #{u.screen_name}"
     end
   end
 
@@ -228,22 +231,24 @@ namespace :justask do
   task loners: :environment do
     people = {}
     Question.all.each do |q|
-      if q.author_is_anonymous && !%w[justask retrospring_exporter].include?(q.author_identifier)
+      next unless q.author_is_anonymous && %w[justask retrospring_exporter].exclude?(q.author_identifier)
+
       q.answers.each do |a|
-          if q.user == a.user
+        next unless q.user == a.user
+
         people[q.user.screen_name] ||= 0
         people[q.user.screen_name] += 1
         puts "#{q.user.screen_name} -- answer id #{a.id}"
       end
     end
-      end
-    end
 
     max = 0
     res = []
-    people.each { |k, v| max = v if v > max }
+    people.each do |k, v|
-    people.each { |k, v| res << k if v == max }
+      max = v if v > max
-    if res.length == 0
+      res << k if v == max
+    end
+    if res.length.zero?
       puts "No one?  I hope you're just on the development session."
     else
       puts res.length == 1 ? "And the winner is..." : "And the winners are..."
@@ -256,33 +261,33 @@ end
 
 namespace :db do
   namespace :schema do
-    task :create_timestampid_function do
+    task create_timestampid_function: :environment do
       conn = ActiveRecord::Base.connection
       have_func = conn.execute("SELECT EXISTS(SELECT * FROM pg_proc WHERE proname = 'gen_timestamp_id');").values.first.first
       next if have_func
 
-      statement = File.read(File.join(__dir__, 'db/migrate/20200704163504_use_timestamped_ids.rb')).match(/<~SQL(?<stmt>.+)SQL$/m)[:stmt]
+      statement = File.read(File.join(__dir__, "db/migrate/20200704163504_use_timestamped_ids.rb")).match(/<~SQL(?<stmt>.+)SQL$/m)[:stmt]
       conn.execute(statement)
     end
 
-    task :create_id_sequences do
+    task create_id_sequences: :environment do
       conn = ActiveRecord::Base.connection
 
       # required for the timestampid function to work properly
-      %i[questions answers comments smiles comment_smiles users mute_rules].each do |tbl|
+      %i[questions answers comments users mute_rules].each do |tbl|
         conn.execute("CREATE SEQUENCE IF NOT EXISTS #{tbl}_id_seq")
       end
     end
   end
 
   # create timestampid before loading schema
-  Rake::Task['db:schema:load'].enhance ['db:schema:create_timestampid_function']
+  Rake::Task["db:schema:load"].enhance ["db:schema:create_timestampid_function"]
-  Rake::Task['db:test:load_schema'].enhance ['db:schema:create_timestampid_function']
+  Rake::Task["db:test:load_schema"].enhance ["db:schema:create_timestampid_function"]
   # create id_sequences after loading schema
-  Rake::Task['db:schema:load'].enhance do
+  Rake::Task["db:schema:load"].enhance do
-    Rake::Task['db:schema:create_id_sequences'].invoke
+    Rake::Task["db:schema:create_id_sequences"].invoke
   end
-  Rake::Task['db:test:load_schema'].enhance do
+  Rake::Task["db:test:load_schema"].enhance do
-    Rake::Task['db:schema:create_id_sequences'].invoke
+    Rake::Task["db:schema:create_id_sequences"].invoke
   end
 end