From 851c74f228b8a2dedead95ae7031ea9bce4c3a7d Mon Sep 17 00:00:00 2001 From: Andreas Nedbal Date: Fri, 8 Jul 2022 23:19:36 +0200 Subject: [PATCH] Fix logged-out users sending wrong data to question endpoint --- app/javascript/retrospring/features/questionbox/user.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/javascript/retrospring/features/questionbox/user.ts b/app/javascript/retrospring/features/questionbox/user.ts index e321f5b0..68d7170e 100644 --- a/app/javascript/retrospring/features/questionbox/user.ts +++ b/app/javascript/retrospring/features/questionbox/user.ts @@ -5,7 +5,12 @@ import I18n from 'retrospring/i18n'; export function questionboxUserHandler(event: Event): void { const button = event.target as HTMLButtonElement; const promote = button.dataset.promote === "true"; - const anonymousQuestion = document.querySelector('input[name=qb-anonymous]')?.checked; + const anonymousInput = document.querySelector('input[name=qb-anonymous]'); + let anonymousQuestion = true; + + if (anonymousInput) { + anonymousQuestion = anonymousInput.checked; + } document.querySelector('textarea[name=qb-question]').readOnly = true; button.disabled = true;