Move empty filter check back into show action

This commit is contained in:
Karina Kwiatek 2023-01-28 22:42:14 +01:00
parent 367e2f4b92
commit 87894d1e95
1 changed files with 8 additions and 9 deletions

View File

@ -5,10 +5,16 @@ class InboxController < ApplicationController
after_action :mark_inbox_entries_as_read, only: %i[show]
def show
def show # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
find_author
find_inbox_entries
check_for_empty_filter
if @author_user && @inbox_count.zero?
# rubocop disabled because of a false positive
flash[:info] = t(".author.info", author: @author) # rubocop:disable Rails/ActionControllerFlashBeforeRender
redirect_to inbox_path(last_id: params[:last_id])
return
end
@delete_id = find_delete_id
@disabled = true if @inbox.empty?
@ -46,13 +52,6 @@ class InboxController < ApplicationController
private
def check_for_empty_filter
return unless @author_user && @inbox_count.zero?
flash[:info] = t(".author.info", author: @author)
redirect_to inbox_path(last_id: params[:last_id])
end
def find_author
return if params[:author].blank?