FreakU
/
Retrospring
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Apply review suggestion for navigation tag helpers

This commit is contained in:
Andreas Nedbal 2020-05-06 14:30:12 +02:00
parent 859d2825d1
commit 9961796e3b
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
app/helpers/application_helper.rb
View File

@ -7,6 +7,12 @@ module ApplicationHelper
class: ''
}.merge(options)
classes = [
"nav-item",
current_page? ? "active" : nil,
options[:class]
].compact.join(" ")
unless options[:icon].nil?
body = "#{content_tag(:i, '', class: "mdi-#{options[:icon]}")} #{body}"
end
@ -18,7 +24,7 @@ module ApplicationHelper
}"))}"
end
content_tag(:li, link_to(body.html_safe, path, class: "nav-link"), class: ("nav-item#{' active' if current_page? path} #{options[:class]}"))
content_tag(:li, link_to(body.html_safe, path, class: "nav-link"), class: classes)
end
def list_group_item(body, path, options = {})
@ -28,6 +34,13 @@ module ApplicationHelper
class: ''
}.merge(options)
classes = [
"list-group-item",
"list-group-item-action",
current_page? ? "active" : nil,
options[:class]
].compact.join(" ")
unless options[:badge].nil? or options[:badge] == 0
# TODO: make this prettier?
body << " #{
@ -36,7 +49,7 @@ module ApplicationHelper
}"))}"
end
content_tag(:a, body.html_safe, href: path, class: ("list-group-item list-group-item-action #{'active ' if current_page? path}#{options[:class]}"))
content_tag(:a, body.html_safe, href: path, class: classes)
end
def tooltip(body, tooltip_content, placement = "bottom")