From ea4a661368ee87e4869fb6b1b0f4f1033c1708a7 Mon Sep 17 00:00:00 2001 From: Georg Gadinger Date: Thu, 13 Oct 2022 07:59:54 +0200 Subject: [PATCH] typoed_email_validator: add new endings to the typo list --- app/validators/typoed_email_validator.rb | 1 + spec/models/user_spec.rb | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/validators/typoed_email_validator.rb b/app/validators/typoed_email_validator.rb index dc80bb2a..279c4950 100644 --- a/app/validators/typoed_email_validator.rb +++ b/app/validators/typoed_email_validator.rb @@ -4,6 +4,7 @@ class TypoedEmailValidator < ActiveModel::EachValidator # this array contains "forbidden" email address endings INVALID_ENDINGS = [ # without @: + ".carrd", ".con", ".coom", ".cmo", diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index 3250d212..5d12058f 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -68,10 +68,12 @@ RSpec.describe User, type: :model do # examples from the real world: - # .con is not a valid TLD + # .carrd is not a valid TLD + include_examples "invalid email", "fritz.fantom@gmail.carrd" + # neither is .con include_examples "invalid email", "fritz.fantom@gmail.con" include_examples "invalid email", "fritz.fantom@protonmail.con" - # neither is .coom + # nor .coom include_examples "invalid email", "fritz.fantom@gmail.coom" # nor .cmo include_examples "invalid email", "gustav.geldsack@gmail.cmo"