Merge pull request #665

Refactor inbox to use a Turbo Streams-backed pagination

app/controllers/inbox_controller.rb

@@ -49,7 +49,7 @@ class InboxController < ApplicationController
     @disabled = true if @inbox.empty?
     respond_to do |format|
       format.html
-      format.js { render layout: false }
+      format.turbo_stream
     end
   end
 end

app/views/inbox/show.haml

@@ -1,14 +1,12 @@
-#entries
+= turbo_frame_tag "inbox" do
-  - @inbox.each do |i|
+  #entries
-    = render "inbox/entry", i: i
+    - @inbox.each do |i|
+      = render "inbox/entry", i: i
 
-  - if @inbox.empty?
+    - if @inbox.empty?
-    = t(".empty")
+      = t(".empty")
 
-= render "shared/cursored_pagination_dummy", more_data_available: @more_data_available, last_id: @inbox_last_id
+  - if @more_data_available
-
+    .d-flex.justify-content-center.justify-content-sm-start#paginator
-- if @more_data_available
+      = button_to inbox_path(last_id: @inbox_last_id), class: "btn btn-light" do
-
+        = t("voc.load")
-  .d-flex.justify-content-center.justify-content-sm-start
-    %button.btn.btn-light#load-more-btn{ type: :button, data: { last_id: @inbox_last_id } }
-      = t("voc.load")

app/views/inbox/show.js.erb

@@ -1,9 +0,0 @@
-$('#entries').append('<% @inbox.each do |i|
-  %><%= j render 'inbox/entry', i: i
-%><% end %>');
-<% if @more_data_available %>
-$('#pagination').html('<%= j render 'shared/cursored_pagination_dummy', more_data_available: @more_data_available, last_id: @inbox_last_id %>');
-<% else %>
-$('#pagination, #load-more-btn').remove();
-<% end %>
-<% Inbox.where(id: @inbox.pluck(:id)).update_all(new: false) %>

app/views/inbox/show.turbo_stream.haml

@@ -0,0 +1,8 @@
+= turbo_stream.append "entries" do
+  - @inbox.each do |i|
+    = render "inbox/entry", i: i
+
+= turbo_stream.update "paginator" do
+  - if @more_data_available
+    = button_to t("voc.load"), inbox_path(last_id: @inbox_last_id), class: "btn btn-light"
+

config/routes.rb

@@ -143,8 +143,7 @@ Rails.application.routes.draw do
 
   get "/notifications(/:type)", to: "notifications#index", as: :notifications, defaults: { type: "new" }
 
-  get "/inbox", to: "inbox#show"
+  match "/inbox(/:author)", via: [:get, :post], to: "inbox#show", as: :inbox
-  get "/inbox/:author", to: "inbox#show"
 
   get "/user/:username(/p/:page)", to: "user#show", defaults: { page: 1 }
   get "/@:username(/p/:page)", to: "user#show", as: :user, defaults: { page: 1 }