From fc420a8091dff107ddd941a0e1ffb6c671be91ab Mon Sep 17 00:00:00 2001 From: Andreas Nedbal Date: Thu, 26 Oct 2023 21:39:47 +0200 Subject: [PATCH] Add specs for `RelationshipsController` --- .../relationships_controller_spec.rb | 153 ++++++++++++++++++ spec/shared_examples/error_raising.rb | 7 + 2 files changed, 160 insertions(+) create mode 100644 spec/controllers/relationships_controller_spec.rb diff --git a/spec/controllers/relationships_controller_spec.rb b/spec/controllers/relationships_controller_spec.rb new file mode 100644 index 00000000..6b3bed06 --- /dev/null +++ b/spec/controllers/relationships_controller_spec.rb @@ -0,0 +1,153 @@ +# coding: utf-8 +# frozen_string_literal: true + +require "rails_helper" + +describe RelationshipsController, type: :controller do + shared_examples_for "params is empty" do + let(:params) { {} } + + include_examples "turbo does not succeed", "is required" + end + + let!(:user) { FactoryBot.create(:user) } + let!(:user2) { FactoryBot.create(:user) } + + describe "#create" do + shared_examples_for "valid relationship type" do + it_behaves_like "params is empty" + + context "screen_name does not exist" do + let(:screen_name) { "peter-witzig" } + + include_examples "turbo does not succeed", "not found" + end + + context "screen_name is current user" do + let(:screen_name) { user.screen_name } + + include_examples "turbo does not succeed", "yourself" + end + + context "screen_name is different from current_user" do + let(:screen_name) { user2.screen_name } + + it "creates the relationship" do + expect { subject }.to change { Relationship.count }.by(1) + expect(Relationship.last.target.screen_name).to eq(screen_name) + end + end + end + + let(:type) { "Sauerkraut" } + let(:screen_name) { user2.screen_name } + let(:params) { { type: type, screen_name: screen_name } } + + subject { post(:create, params: params, format: :turbo_stream) } + + it_behaves_like "requires login" + + context "user signed in" do + before(:each) { sign_in(user) } + + context "type = 'follow'" do + let(:type) { "follow" } + + include_examples "valid relationship type" + + context "target user mutes source user" do + before do + user2.mute(user) + end + + it "creates the relationship but no notification" do + expect { subject }.to change { Notification.count }.by(0) + end + end + end + + context "type = 'block'" do + let(:type) { "block" } + + include_examples "valid relationship type" + end + + context "type = 'mute'" do + let(:type) { "mute" } + + include_examples "valid relationship type" + end + + context "type = 'dick'" do + let(:type) { "dick" } + + it_behaves_like "params is empty" + include_examples "turbo does not succeed", "Invalid parameter" + end + end + end + + describe "#destroy" do + shared_examples_for "valid relationship type" do + let(:screen_name) { user2.screen_name } + + context "relationship exists" do + before do + user.public_send(type, user2) + end + + it "destroys a relationship" do + expect { subject }.to change { Relationship.count }.by(-1) + end + end + + context "relationship does not exist" do + it "does not change anything at all" do + expect { subject }.to change { Relationship.count }.by(0) + end + end + + context "screen_name does not exist" do + let(:screen_name) { "peter-witzig" } + + include_examples "turbo does not succeed", "not found" + end + end + + let(:type) { "Sauerkraut" } + let(:screen_name) { user2.screen_name } + let(:params) { { type: type, screen_name: screen_name } } + + subject { delete(:destroy, params: params, format: :turbo_stream) } + + it_behaves_like "requires login" + + context "user signed in" do + before(:each) { sign_in(user) } + + context "type = 'follow'" do + let(:type) { "follow" } + + include_examples "valid relationship type" + end + + context "type = 'block'" do + let(:type) { "block" } + + include_examples "valid relationship type" + end + + context "type = 'mute'" do + let(:type) { "mute" } + + include_examples "valid relationship type" + end + + context "type = 'dick'" do + let(:type) { "dick" } + + include_examples "turbo does not succeed", "Invalid parameter" + end + end + end +end diff --git a/spec/shared_examples/error_raising.rb b/spec/shared_examples/error_raising.rb index 03290783..527318b1 100644 --- a/spec/shared_examples/error_raising.rb +++ b/spec/shared_examples/error_raising.rb @@ -13,3 +13,10 @@ RSpec.shared_examples_for "ajax does not succeed" do |part_of_error_message| expect(assigns(:response)[:message]).to include(part_of_error_message) end end + +RSpec.shared_examples_for "turbo does not succeed" do |part_of_error_message| + it "turbo does not succeed" do + subject + expect(response.body).to include(part_of_error_message) + end +end