Commit Graph

2689 Commits

Author SHA1 Message Date
Karina Kwiatek 1e5957bfe9 Test relationship use cases using both user objects and screen names as params 2022-01-23 16:48:53 +01:00
Karina Kwiatek b74c64c664 Fix order of types for relationship use case options 2022-01-23 16:48:53 +01:00
Karina Kwiatek 3b1287c424 Apply suggestions from @nilsding
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
2022-01-23 16:48:53 +01:00
Karina Kwiatek aa683ca5d5 Appease the dog overlords (fix lint errors) 2022-01-23 16:48:53 +01:00
Karina Kwiatek 731ee4bf69 Address review comments from @nilsding 2022-01-23 16:48:53 +01:00
Karina Kwiatek 677ce26e6c Use generic handling of our own exceptions
Noticed that we shouldn't be trying to catch specific exceptions as `Dry::Types` will throw its own exceptions for validation errors.
2022-01-23 16:48:53 +01:00
Karina Kwiatek 29d46b43db Fix lint error; use fail message for relationship create failures 2022-01-23 16:48:53 +01:00
Karina Kwiatek 8d59ef9398 Use `screen_name` instead of `target_user` param in `Ajax::RelationshipController` 2022-01-23 16:48:53 +01:00
Karina Kwiatek b4e0699e82 Fix lint errors 2022-01-23 16:48:53 +01:00
Karina Kwiatek 0ab822c33a Use full translation key for messages 2022-01-23 16:48:53 +01:00
Karina Kwiatek d609435f7c Update `Ajax::RelationshipController` to use usernames; Test Use Case 2022-01-23 16:48:53 +01:00
Karina Kwiatek 4a1ed5394a Remove relationships where source == target prior to adding relationship type 2022-01-23 16:48:53 +01:00
Karina Kwiatek 5c9659ccf5 Update Exporter spec to not include removed relationship count fields 2022-01-23 16:48:53 +01:00
Karina Kwiatek c8059ccd6b Fix namespace resolution in relationship use cases 2022-01-23 16:48:53 +01:00
Karina Kwiatek ce57414595 Update `UserController` tests to match rename of followings 2022-01-23 16:48:53 +01:00
Karina Kwiatek 3962671135 Implement relationship logic as use case 2022-01-23 16:48:53 +01:00
Karina Kwiatek d20e07ee19 Remove relationship counters in `users` table 2022-01-23 16:48:53 +01:00
Karina Kwiatek ce951453a2 Make relationships polymorphic 2022-01-23 16:48:53 +01:00
Karina Kwiatek ee6ba8f9b7 Update `schema.rb` (post-rebase) 2022-01-23 16:48:53 +01:00
Andreas Nedbal d56dfc02f9 Move consent POST-logic to separate action 2022-01-22 22:50:32 +01:00
Andreas Nedbal 1933aaac7f Fix codestyle in `ScreenNameValidator` 2022-01-22 22:50:32 +01:00
Andreas Nedbal 77c6dc7120 Turn `feedback_features_path` into snake_case 2022-01-22 22:50:32 +01:00
Andreas Nedbal 8fba959f5e Add `feedback` to forbidden screen names 2022-01-22 22:50:32 +01:00
Andreas Nedbal 322048a48a Add final newline to config 2022-01-22 22:50:32 +01:00
Andreas Nedbal 153ba70aea Sort feedback items alphabetically 2022-01-22 22:50:32 +01:00
Andreas Nedbal 54ae1ca08c Disable HAML linting through Hound
Hound doesn't support HAML linting with RuboCop cops, effectively making it useless
2022-01-22 22:50:32 +01:00
Andreas Nedbal eecaaeab2d Hide navigation section if Canny is not configured 2022-01-22 22:50:32 +01:00
Andreas Nedbal 2f7d7b2601 Fix HAML codestyle of navigation partials 2022-01-22 22:50:32 +01:00
Andreas Nedbal 3bd43f1cf2 Add feedback links to navigation 2022-01-22 22:50:32 +01:00
Andreas Nedbal 4e9f83330b Fix HAML codestyle 2022-01-22 22:50:32 +01:00
Andreas Nedbal 3711c676da Fix Ruby codestyle 2022-01-22 22:50:32 +01:00
Andreas Nedbal af66e69ca5 Add tests for `FeedbackHelper` 2022-01-22 22:50:32 +01:00
Andreas Nedbal 067dfc3a50 Add tests for `FeedbackController` 2022-01-22 22:50:32 +01:00
Andreas Nedbal 7374aba6d3 Add generation of the Canny SSO token 2022-01-22 22:50:32 +01:00
Andreas Nedbal 4d4296de19 Redirect away from consent action if consent is already given 2022-01-22 22:50:32 +01:00
Andreas Nedbal 0b76ceb73d WIP: Canny integration 2022-01-22 22:50:32 +01:00
Karina Kwiatek 558dbfe870 Add Brewfile 2022-01-19 15:32:19 +01:00
Georg Gadinger 1997f89cc0 typoed_email_validator: add new ending to the typo list 2022-01-17 20:41:39 +01:00
Georg Gadinger 989f4a5132 run Rubocop on changed files 2022-01-17 20:41:39 +01:00
Andreas Nedbal 1c6d22355a Add a quote testcase for the question markdown spec 2022-01-16 22:33:48 +01:00
Andreas Nedbal 60c7c86b05 Remove unnecessary `.dup` 2022-01-16 22:33:48 +01:00
Andreas Nedbal c84b6a61bd Use `gsub` instead of `gsub!` to not modify frozen literals 2022-01-16 22:33:48 +01:00
Andreas Nedbal 3bdca34c2d QuestionMarkdown adjustments
* Using `Redcarpet::Render::StripDown` as base now
* Support for autolinks and named links in Markdown
* Named links in questions just return the actual link as text
* Fixed codestyle in files
2022-01-16 22:33:48 +01:00
Andreas Nedbal 0a52c09684 Apply review suggestion from @nilsding
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
2022-01-16 14:17:29 +01:00
Andreas Nedbal 34b9f0bc61 Add tests for `ApplicationHelper` 2022-01-16 14:17:29 +01:00
Andreas Nedbal 0878561e50 Rename .houndci.yml to .hound.yml
Because of course the config is not respected when you use the wrong name
2022-01-16 14:17:29 +01:00
Andreas Nedbal 914b56369b Adjust ApplicationHelper tests 2022-01-16 14:17:29 +01:00
Andreas Nedbal a438e414c9 Fix code style in ApplicationHelper 2022-01-16 14:17:29 +01:00
Andreas Nedbal bdaf2f7fef Include cop settings from `rt_rubocop_defaults` and remove Gem
Hound can't require external configurations and so we have to resort to this.
2022-01-15 23:48:43 +01:00
Andreas Nedbal 71353b3721 Fix order of (new) gems in Gemfile 2022-01-15 23:48:43 +01:00