Commit Graph

2333 Commits

Author SHA1 Message Date
Karina Kwiatek 52ece6fa5e
Merge pull request #240 from Retrospring/add-indexes-to-notifications
Add indexes to notifications table
2021-12-28 16:12:37 +01:00
Karina Kwiatek b438c89256 Fix broken tests 2021-12-28 15:11:41 +01:00
Karina Kwiatek 07a54c473e Add `notifications` table indexes for `recipient_id` & `new` 2021-12-28 15:11:41 +01:00
Karina Kwiatek fe6a04c6e2
Merge pull request #238 from Retrospring/fix/failed-posts
Catch common `ShareWorker` exceptions to avoid unnecessary retries
2021-12-28 14:37:38 +01:00
Karina Kwiatek a534dd04d5 Test all cases of error handling for `ShareWorker` 2021-12-28 03:59:45 +01:00
Karina Kwiatek 45dae78ed0 Adjust `ShareWorker` test to not be dependent on config options 2021-12-28 03:03:59 +01:00
Karina Kwiatek 9dafa675d1 Log on `ShareWorker` Twitter exceptions 2021-12-27 23:03:51 +01:00
Karina Kwiatek d73e269d85 Test `ShareWorker`'s handling of unhandled exceptions 2021-12-27 23:02:32 +01:00
Karina Kwiatek 6ed91204a4
Merge pull request #239 from Retrospring/feature/mail-notice-part-2
Update mail notice to mention people to look at their spam folder
2021-12-27 21:06:52 +01:00
Andreas Nedbal e3c9d1b7b4 Update mail notice to mention people to look at their spam folder 2021-12-27 20:51:36 +01:00
Karina Kwiatek 0b926a43e4 Test `ShareWorker`'s handling of deleted records 2021-12-27 18:53:59 +01:00
Karina Kwiatek 9c599db3a7 Log message if `ShareWorker` tries to post something deleted 2021-12-27 18:17:47 +01:00
Karina Kwiatek 58a5065e52 Catch common `ShareWorker` exceptions to avoid unnecessary retries 2021-12-27 17:44:42 +01:00
Andreas Nedbal b544145b93 Fix `SocialHelper::TwitterMethods` tests so they work anywhere 2021-12-27 14:28:11 +01:00
Andreas Nedbal 8dd14e4a05 Fix `SocialHelper::TumblrMethods` tests so they work anywhere 2021-12-27 14:28:11 +01:00
Andreas Nedbal 719e393ed1 Add test for `Services::Tumblr` 2021-12-27 14:28:11 +01:00
Andreas Nedbal 4529fa0d18 Fix `Services::Tumblr` not being able to post 2021-12-27 14:28:11 +01:00
Karina Kwiatek 62755b8827
Merge pull request #236 from Retrospring/feature/mail-notice
Add notice on registering about issues with Hotmail/Outlook
2021-12-27 01:52:36 +01:00
Andreas Nedbal 3f4bd13486 Add notice on registering about issues with Hotmail/Outlook 2021-12-27 01:44:10 +01:00
Karina Kwiatek 8d607fd833
Merge pull request #233 from Retrospring/bugfix/pp-markdown
Add newline to prevent rendering issue in privacy policy
2021-12-27 00:01:57 +01:00
Andreas Nedbal dab5fa0935
Add newline to prevent rendering issue in privacy policy 2021-12-27 00:00:11 +01:00
Karina Kwiatek 1ba99af4ce
Merge pull request #232 from Retrospring/feature/sharing
Add manual share links to answerboxes
2021-12-26 23:53:02 +01:00
Andreas Nedbal 453724be8b Prevent reloading of page on share link click 2021-12-26 23:46:42 +01:00
Andreas Nedbal a1ba1a8082
Apply review suggestion from @raccube
Co-authored-by: Karina Kwiatek <6197148+raccube@users.noreply.github.com>
2021-12-26 23:41:23 +01:00
Andreas Nedbal 5fcf24646e Open share widgets in new tab 2021-12-26 23:28:46 +01:00
Andreas Nedbal 21c4e0662f Make the share event work on any answer
...not just the initially loaded set
2021-12-26 23:01:16 +01:00
Andreas Nedbal 08a0f2e1ca Don't include `Rails.application.routes.url_helpers` in `SocialHelper::`
It badly trips up things
2021-12-26 22:40:27 +01:00
Andreas Nedbal 7be52bb7f2 Include Rails URL helpers in `Services::Twitter` 2021-12-26 22:17:53 +01:00
Andreas Nedbal 4ddfba9a79 Add tests for `SocialHelper::TumblrMethods` 2021-12-26 22:07:58 +01:00
Andreas Nedbal b202a1f7e7 Add tests for `SocialHelper::TwitterMethods` 2021-12-26 22:07:42 +01:00
Andreas Nedbal b630baa870 Hide any element with `ab-share` as a name 2021-12-26 22:07:17 +01:00
Andreas Nedbal fa37f5c857 Add share links to answerboxes 2021-12-26 22:06:52 +01:00
Andreas Nedbal ed64a0990e Move tumblr post formatting into a separate helper class 2021-12-26 22:04:46 +01:00
Andreas Nedbal b64b039d21 Move tweet formatting into a separate helper class 2021-12-26 22:04:16 +01:00
Georg Gadinger 5b1b4901af
Merge pull request #230 from Retrospring/dep/questiongenerator-1.0
Bump `questiongenerator` to 1.0
2021-12-26 19:41:10 +01:00
Karina Kwiatek 3803ae97c4 Bump `questiongenerator` to 1.0 2021-12-26 19:38:04 +01:00
Georg Gadinger 2d776e7171
Merge pull request #228 from Retrospring/feature/codeowners-plus-plus
Add more frontend filetypes to CODEOWNERS
2021-12-26 15:57:31 +01:00
Andreas Nedbal 993667ad0c
Add more frontend filetypes to CODEOWNERS
This just prevents @nilsding from getting code review requests on frontend-related code.
2021-12-26 14:02:32 +01:00
Karina Kwiatek 3e7c6d8d95 Fix ShareWorker retries failing 2021-12-25 23:22:52 +01:00
Karina Kwiatek 0f654a4d7d
Merge pull request #226 from Retrospring/refactor/user-typescript
Port User functionality to TypeScript
2021-12-25 22:44:26 +01:00
Karina Kwiatek 053ebafbc5
Merge pull request #213 from Retrospring/refactor/profile
Move profile fields to seperate table
2021-12-25 22:44:10 +01:00
Karina Kwiatek c773d43447
Merge pull request #227 from Retrospring/fix/tweet-length
Fixes to ensure answers shared to twitter post more reliably
2021-12-25 22:39:56 +01:00
Karina Kwiatek 570425821f Add test for handling answers that don't need to be shortened for tweets 2021-12-25 22:27:32 +01:00
Karina Kwiatek 3204aaa2e9 Add test for tweet shortening
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
2021-12-25 22:08:20 +01:00
Karina Kwiatek 7f26c1fef3 Ensure elipsis character always gets added for long questions/answers 2021-12-25 22:08:06 +01:00
Karina Kwiatek fa025ced92 Update `Ajax::AnswerController` test to expect multiple `ShareWorker` jobs 2021-12-25 15:22:19 +01:00
Karina Kwiatek b0fce22ef1 Install `libidn11-dev` for build & docker 2021-12-25 14:49:18 +01:00
Karina Kwiatek f28f714457 Allow retries for ShareWorker 2021-12-25 13:40:21 +01:00
Karina Kwiatek 61c8208e26 Ensure tweets fit twitter's length limit 2021-12-25 13:39:35 +01:00
Andreas Nedbal 8b583e103a Fix lint nits 2021-12-25 04:05:03 +01:00