Commit Graph

2900 Commits

Author SHA1 Message Date
Andreas Nedbal 3afa52c59e Fix haml-lint nits 2023-10-15 10:16:21 +02:00
Andreas Nedbal 9f8450a83c Add frontend validation for mute rule creation 2023-10-15 10:16:21 +02:00
Andreas Nedbal f3f8e99045 Use `length` validation instead of `presence` for `MuteRule` 2023-10-15 10:16:21 +02:00
Andreas Nedbal d40519dffa Handle Rails validation errors in TurboStreamable concern 2023-10-15 10:16:21 +02:00
Andreas Nedbal 9e35c036b1 Rewrite WebPush enable handler to properly catch errors 2023-10-14 20:57:09 +02:00
Karina Kwiatek fa74a296c5
Merge pull request #1238 from Retrospring/fix/counter-jank 2023-10-02 14:07:57 +01:00
Karina Kwiatek d39f37072d Fix lint errors 2023-08-18 19:43:59 +02:00
Karina Kwiatek 620121341e Fix typo 2023-08-18 19:41:21 +02:00
Karina Kwiatek 54ac832c91 Ensure inbox caching timestamp gets updated when answering questions and returning to inbox 2023-08-16 21:57:31 +02:00
Karina Kwiatek cb89d42813 Put IDs directly on nav entries 2023-08-16 21:17:18 +02:00
Andreas Nedbal a18bf040b3 Apply review suggestions from @nilsding
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
2023-08-07 22:34:46 +02:00
Andreas Nedbal 3d21beff39 Fix race condition in `CropperController` 2023-08-07 22:34:46 +02:00
Karina Kwiatek bcfb215f8c Ensure caching timestamp is updated when marking notifications as read 2023-06-16 18:20:21 +02:00
Karina Kwiatek 5a3f65e39a Ensure counters are up to date when rendering inbox/notifications views 2023-06-16 18:19:31 +02:00
Karina Kwiatek ece64669a1 Update caching timestamps in model events 2023-06-16 18:18:40 +02:00
Karina Kwiatek a6f526b9c4 Update inbox/notification counters when paginating 2023-06-16 18:07:53 +02:00
Karina Kwiatek ab81fc0c1b Use `present?` for badge check 2023-05-30 22:29:31 +02:00
Karina Kwiatek 5fc481f797 Set fallback for PWA badge count to 0 (removes badge) 2023-05-30 22:04:39 +02:00
Karina Kwiatek 1826da1e0a Allow navigation items to have their badge persist if they have a Stimulus controller
This fixes a bug which caused the PWA app badge to persist even though the user's inbox was empty.
2023-05-30 21:58:02 +02:00
Karina Kwiatek f1863e5309 Fix notification created_at not being set for comment notifications 2023-05-26 20:39:19 +02:00
Karina Kwiatek 6643a4763f Make `target` a keyword argument for `user_screen_name` helper
Co-authored-by: nilsding <nilsding@nilsding.org>
2023-05-09 23:20:36 +02:00
Karina Kwiatek 4bf977e96c Fix lint errors for the remaining notification types 2023-05-09 23:03:26 +02:00
Karina Kwiatek 2c72252591 Use Unicode ellipsis 2023-05-09 22:58:14 +02:00
Karina Kwiatek 0d55ff16c3 Appease the dog overlords 2023-05-09 22:57:18 +02:00
Karina Kwiatek e096ddc999 Prevent links from notifications from being opened in the dropdown frame 2023-05-09 22:51:40 +02:00
Karina Kwiatek 63372cdeac Pass subscribed answer IDs on answer create 2023-05-08 21:45:31 +02:00
Karina Kwiatek a37a498fb9 Exclude pinned answers from pagination queries 2023-05-08 20:29:27 +02:00
Karina Kwiatek 2db4ce38c9 Add stub notification partial for content pending deletion 2023-05-08 19:06:40 +02:00
Karina Kwiatek 4cab189750 Fix notification cache timestamp not being touched after marking all as read 2023-05-08 18:55:35 +02:00
Karina Kwiatek eca53de004
Merge pull request #1200 from Retrospring/fix/touch-updated-at-after-mark-as-read
Touch updated at after marking inbox/notification entries as read
2023-05-07 20:56:47 +02:00
Karina Kwiatek 2aaba3e2d9 Touch `notifications_updated_at` after marking entries as read 2023-05-07 20:54:54 +02:00
Karina Kwiatek ed6bdfe8cb Touch `inbox_updated_at` after marking entries as read 2023-05-07 20:54:44 +02:00
Karina Kwiatek f15cb930ef Appease the robot dog 2023-05-07 20:35:00 +02:00
Karina Kwiatek bbbff68c7d Fix remaining missing subscribed answers in views 2023-05-07 20:31:32 +02:00
Karina Kwiatek 578dd9c6e6 Pass subscribed answer IDs down in Discover views 2023-05-07 17:27:34 +02:00
Karina Kwiatek 15405e41c5 Fix incorrect caching method used for notifications dropdown 2023-05-07 16:54:35 +02:00
Karina Kwiatek be66f7061d Fix 500 on Discover 2023-05-07 16:39:02 +02:00
Karina Kwiatek 4c6ad5f789 Fix 500 when not logged in 2023-05-07 15:10:31 +02:00
Karina Kwiatek 7dc25ba841 Appease the robot dog 2023-05-07 12:51:40 +02:00
Karina Kwiatek 50531d3b6b Cache notifications dropdown based on `notifications_updated_at` 2023-05-07 12:47:29 +02:00
Karina Kwiatek 7a9a7e0d47
Merge pull request #1130 from Retrospring/feature/mark-all-notifications-as-read
Mark all notifications as read
2023-05-07 10:07:11 +02:00
Karina Kwiatek 142a31f655 Set `subscribed_answer_ids` in answerbox when user is not set 2023-05-05 16:01:48 +02:00
Karina Kwiatek 4221f8cee9 Fix incorrect user being notified and mutes not being respected 2023-05-05 16:01:48 +02:00
Karina Kwiatek bbc0afe292 Move subscribed answer IDs to an ivar 2023-05-05 16:01:46 +02:00
Karina Kwiatek 9c4b2e452a Prevent error when no one is subscribed 2023-05-05 16:01:40 +02:00
Karina Kwiatek b93058b11d Fix remaining lint errors 2023-05-05 16:01:40 +02:00
Karina Kwiatek fb83f48adf Fix lint errors 2023-05-05 16:01:40 +02:00
Karina Kwiatek 36d59d100e Remove unused `destruct_by` method 2023-05-05 16:01:40 +02:00
Karina Kwiatek f73fc87991 Simplify `notify` and `denotify` methods 2023-05-05 16:01:40 +02:00
Karina Kwiatek 0132d7b251 Remove usages of `is_active` 2023-05-05 16:01:40 +02:00
Karina Kwiatek 0a97a86d73 Pass `subscribed_answer_ids` into `answerbox` in Turbo Stream 2023-05-05 16:01:40 +02:00
Karina Kwiatek 6fc4049f6c Pass answer list method into `paginate_answers` 2023-05-05 16:01:40 +02:00
Karina Kwiatek d77919ee01 Don't check for user sign in when fetching subscriptions in timeline 2023-05-05 16:01:40 +02:00
Karina Kwiatek 904eab8daa Remove now unused `is_subscribed` method 2023-05-05 16:01:40 +02:00
Karina Kwiatek 0771c689ea Clean up marking notifications as read when viewing an answer 2023-05-05 16:01:40 +02:00
Karina Kwiatek d7997db492 Check subscription in `answer/show` 2023-05-05 16:01:40 +02:00
Karina Kwiatek 7aed99d187 Appease the dog overlords 2023-05-05 16:01:38 +02:00
Karina Kwiatek 2604e6b240 Prefetch subscriptions 2023-05-05 16:01:21 +02:00
Karina Kwiatek 57ed3008d3 Fix "Content missing" on "Show all notifications" 2023-05-05 15:59:45 +02:00
Karina Kwiatek 80d8bebe57 Appease the dog overlords 2023-05-05 15:59:43 +02:00
Karina Kwiatek c9c458252b Add functionality for marking all notifications as read 2023-05-05 15:59:25 +02:00
Karina Kwiatek b801af9465
Merge pull request #1061 from Retrospring/feature/hotkey
Keyboard shortcuts
2023-04-29 16:26:55 +02:00
Karina Kwiatek 2afb10ab81 Move keyboard shortcuts menu entry out of canny if clause 2023-04-29 14:55:07 +02:00
Karina Kwiatek 55090a42f8
Merge pull request #1148 from Retrospring/moar-metrics
metrics: add counter for created/destroyed users
2023-04-29 09:54:53 +02:00
Karina Kwiatek 79e742ce1e Remove debug 2023-04-29 09:34:28 +02:00
Karina Kwiatek 655b822e54 Add Stimulus controller for handling hotkeys 2023-04-29 09:34:28 +02:00
Karina Kwiatek f7b9d90e28 Appease the dog overlords 2023-04-29 09:34:28 +02:00
Karina Kwiatek 9a7dedcafc Ensure bottom of page is visible while navigating 2023-04-29 09:34:28 +02:00
Karina Kwiatek 1aed44dd3d Apply hotkeys on user profiles 2023-04-29 09:34:28 +02:00
Karina Kwiatek e307204375 Navigate between traversable elements regardless of parent element 2023-04-29 09:34:28 +02:00
Karina Kwiatek 0eb9a4d089 Add hotkey for loading more entries 2023-04-29 09:34:28 +02:00
Karina Kwiatek b22fc0bd16 Apply hotkeys on question pages 2023-04-29 09:34:28 +02:00
Karina Kwiatek d684e8d782 Add shortcut for viewing answer page 2023-04-29 09:34:28 +02:00
Karina Kwiatek cc73f84152 Change smile hotkey to `s` 2023-04-29 09:34:28 +02:00
Karina Kwiatek 9572f844ec Add hotkey help window 2023-04-29 09:34:28 +02:00
Karina Kwiatek a39696dd3e Add shortcut for writing new comment 2023-04-29 09:34:26 +02:00
Karina Kwiatek 43d80fffcf Add shortcut for jumping to answers 2023-04-29 09:34:15 +02:00
Karina Kwiatek a64a4699b0 Add Stimulus controller for navigation shortcuts 2023-04-29 09:34:15 +02:00
Karina Kwiatek dbd6f96f53 Add navigation shortcuts 2023-04-29 09:34:15 +02:00
Karina Kwiatek 1a2650e810 Add `@github/hotkey` 2023-04-29 09:34:12 +02:00
Karina Kwiatek b5193cd1ac
Merge pull request #1129 from Retrospring/feature/multiline-comments
Allow multi-line comments
2023-04-29 08:52:24 +02:00
Georg Gadinger 48e63cf472 typoed_email_validator: add new endings to the typo list 2023-04-22 22:05:15 +02:00
Georg Gadinger a9cf00f75e metrics: add counter for created/destroyed users 2023-03-29 08:01:35 +02:00
Karina Kwiatek eda522ce8b Remove extra space
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
2023-03-26 18:28:36 +02:00
Karina Kwiatek 010f871eb2 Disable Turbo on sign in forms 2023-03-26 18:28:36 +02:00
Karina Kwiatek 3fa607f39c Clean up `User::SessionsController` 2023-03-26 18:28:36 +02:00
Karina Kwiatek c43543f8d3 Revert "Disable Turbo for all Devise forms"
This reverts commit 8226198f76.
2023-03-26 18:28:36 +02:00
Georg Gadinger 6f59abe9dd Update app/models/user/relationship/mute.rb
Co-authored-by: Karina Kwiatek <6197148+raccube@users.noreply.github.com>
2023-03-26 18:28:19 +02:00
Georg Gadinger 1ffa2e5125 filter out non-anon questions from blocked/muted users in questions view 2023-03-26 18:28:19 +02:00
Georg Gadinger 920187bc88 filter out non-anon questions from blocked/muted users in public timeline 2023-03-26 18:28:19 +02:00
Georg Gadinger f1a1321a25 filter out non-anon questions from blocked/muted users in list timeline 2023-03-26 18:28:19 +02:00
Georg Gadinger 765397d813 filter out non-anon questions from blocked/muted users in home timeline 2023-03-26 18:28:19 +02:00
Karina Kwiatek da186747cc Handle clicking the comment submit button 2023-03-18 15:24:36 +01:00
Karina Kwiatek ceb55c656e Appease the dog overlords 2023-03-10 21:06:11 +01:00
Georg Gadinger 4e150945e5 typoed_email_validator: add new endings to the typo list 2023-03-09 20:08:15 +01:00
Karina Kwiatek fc90b746c9 Remove debug 2023-03-07 19:14:57 +01:00
Karina Kwiatek 3c052e9e0e Fix trivial lint issues 2023-03-07 19:14:20 +01:00
Karina Kwiatek b93453dee4 Remove eager load from notifications
Unsure of how this managed to work before but eager loading polymorphic associations is not possible in this way.
2023-03-07 19:14:14 +01:00
Karina Kwiatek 14379acbd3 Fix incorrect access of `unread_inbox_count` in `notification_data` 2023-03-07 19:14:14 +01:00
Karina Kwiatek 68e0f02a2d Adapt tests to match new counter methods 2023-03-07 19:14:14 +01:00