3b1287c424
Apply suggestions from @nilsding
...
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
2022-01-23 16:48:53 +01:00
aa683ca5d5
Appease the dog overlords (fix lint errors)
2022-01-23 16:48:53 +01:00
731ee4bf69
Address review comments from @nilsding
2022-01-23 16:48:53 +01:00
677ce26e6c
Use generic handling of our own exceptions
...
Noticed that we shouldn't be trying to catch specific exceptions as `Dry::Types` will throw its own exceptions for validation errors.
2022-01-23 16:48:53 +01:00
29d46b43db
Fix lint error; use fail message for relationship create failures
2022-01-23 16:48:53 +01:00
8d59ef9398
Use `screen_name` instead of `target_user` param in `Ajax::RelationshipController`
2022-01-23 16:48:53 +01:00
b4e0699e82
Fix lint errors
2022-01-23 16:48:53 +01:00
0ab822c33a
Use full translation key for messages
2022-01-23 16:48:53 +01:00
d609435f7c
Update `Ajax::RelationshipController` to use usernames; Test Use Case
2022-01-23 16:48:53 +01:00
4a1ed5394a
Remove relationships where source == target prior to adding relationship type
2022-01-23 16:48:53 +01:00
5c9659ccf5
Update Exporter spec to not include removed relationship count fields
2022-01-23 16:48:53 +01:00
c8059ccd6b
Fix namespace resolution in relationship use cases
2022-01-23 16:48:53 +01:00
ce57414595
Update `UserController` tests to match rename of followings
2022-01-23 16:48:53 +01:00
3962671135
Implement relationship logic as use case
2022-01-23 16:48:53 +01:00
d20e07ee19
Remove relationship counters in `users` table
2022-01-23 16:48:53 +01:00
ce951453a2
Make relationships polymorphic
2022-01-23 16:48:53 +01:00
ee6ba8f9b7
Update `schema.rb` (post-rebase)
2022-01-23 16:48:53 +01:00
d56dfc02f9
Move consent POST-logic to separate action
2022-01-22 22:50:32 +01:00
1933aaac7f
Fix codestyle in `ScreenNameValidator`
2022-01-22 22:50:32 +01:00
77c6dc7120
Turn `feedback_features_path` into snake_case
2022-01-22 22:50:32 +01:00
8fba959f5e
Add `feedback` to forbidden screen names
2022-01-22 22:50:32 +01:00
322048a48a
Add final newline to config
2022-01-22 22:50:32 +01:00
153ba70aea
Sort feedback items alphabetically
2022-01-22 22:50:32 +01:00
54ae1ca08c
Disable HAML linting through Hound
...
Hound doesn't support HAML linting with RuboCop cops, effectively making it useless
2022-01-22 22:50:32 +01:00
eecaaeab2d
Hide navigation section if Canny is not configured
2022-01-22 22:50:32 +01:00
2f7d7b2601
Fix HAML codestyle of navigation partials
2022-01-22 22:50:32 +01:00
3bd43f1cf2
Add feedback links to navigation
2022-01-22 22:50:32 +01:00
4e9f83330b
Fix HAML codestyle
2022-01-22 22:50:32 +01:00
3711c676da
Fix Ruby codestyle
2022-01-22 22:50:32 +01:00
af66e69ca5
Add tests for `FeedbackHelper`
2022-01-22 22:50:32 +01:00
067dfc3a50
Add tests for `FeedbackController`
2022-01-22 22:50:32 +01:00
7374aba6d3
Add generation of the Canny SSO token
2022-01-22 22:50:32 +01:00
4d4296de19
Redirect away from consent action if consent is already given
2022-01-22 22:50:32 +01:00
0b76ceb73d
WIP: Canny integration
2022-01-22 22:50:32 +01:00
558dbfe870
Add Brewfile
2022-01-19 15:32:19 +01:00
1997f89cc0
typoed_email_validator: add new ending to the typo list
2022-01-17 20:41:39 +01:00
989f4a5132
run Rubocop on changed files
2022-01-17 20:41:39 +01:00
1c6d22355a
Add a quote testcase for the question markdown spec
2022-01-16 22:33:48 +01:00
60c7c86b05
Remove unnecessary `.dup`
2022-01-16 22:33:48 +01:00
c84b6a61bd
Use `gsub` instead of `gsub!` to not modify frozen literals
2022-01-16 22:33:48 +01:00
3bdca34c2d
QuestionMarkdown adjustments
...
* Using `Redcarpet::Render::StripDown` as base now
* Support for autolinks and named links in Markdown
* Named links in questions just return the actual link as text
* Fixed codestyle in files
2022-01-16 22:33:48 +01:00
0a52c09684
Apply review suggestion from @nilsding
...
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
2022-01-16 14:17:29 +01:00
34b9f0bc61
Add tests for `ApplicationHelper`
2022-01-16 14:17:29 +01:00
0878561e50
Rename .houndci.yml to .hound.yml
...
Because of course the config is not respected when you use the wrong name
2022-01-16 14:17:29 +01:00
914b56369b
Adjust ApplicationHelper tests
2022-01-16 14:17:29 +01:00
a438e414c9
Fix code style in ApplicationHelper
2022-01-16 14:17:29 +01:00
bdaf2f7fef
Include cop settings from `rt_rubocop_defaults` and remove Gem
...
Hound can't require external configurations and so we have to resort to this.
2022-01-15 23:48:43 +01:00
71353b3721
Fix order of (new) gems in Gemfile
2022-01-15 23:48:43 +01:00
2f52a9c325
Remove HAML linting action step
...
Hound also does this
2022-01-15 23:48:43 +01:00
dbc01f0264
Add HoundCI configuration
2022-01-15 23:48:43 +01:00
Karina Kwiatek