Commit Graph

2057 Commits

Author SHA1 Message Date
Karina Kwiatek d9ff4d5765 Refactor Ajax::QuestionController#create into separate UseCases
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
2022-07-17 10:05:20 +02:00
Andreas Nedbal 2722f4fffb Fix comment notifications displaying escaped HTML 2022-07-17 09:40:47 +02:00
Andreas Nedbal ca2cf727e1 Require `user` param for `ListController#create` 2022-07-17 09:40:34 +02:00
Andreas Nedbal 47120e8d24 Appease the dog overlords 2022-07-17 09:40:34 +02:00
Andreas Nedbal a5b6ef07d3 Refactor `Ajax::ListController`
* remove inline authentication checks and use before_action instead
* remove begin/rescue catches as those are handled by the base controller and validations now
2022-07-17 09:40:34 +02:00
Andreas Nedbal a3f80380dd Adjust validations for `List` 2022-07-17 09:40:34 +02:00
Karina Kwiatek e1e45b04a3 Use double quotes instead of single quotes 2022-07-16 21:29:20 +02:00
Karina Kwiatek c59a70844b Display if a context question has been deleted when viewing anon blocks 2022-07-16 21:29:20 +02:00
Karina Kwiatek 8005fc8ae6 Skip denotify if recipient doesn't exist 2022-07-16 21:29:20 +02:00
Karina Kwiatek d9f82c4985 Disallow deletion of accounts when a data export is pending 2022-07-16 21:29:20 +02:00
Karina Kwiatek 5e633ab56e Fix invalid paths for original size images 2022-07-16 15:58:30 +02:00
Karina Kwiatek bd5ec792b7 Prevent text in links from being double-escaped 2022-07-16 15:57:32 +02:00
Georg Gadinger 572132f9e9 make captcha readable 2022-07-09 12:41:16 +02:00
Karina Kwiatek 39d55e52c8 Use `target.class.name` instead of `target.type`
This only worked for polymorphic relations
2022-07-09 01:15:31 +02:00
Karina Kwiatek 28240bba27 Properly match notification type 2022-07-09 01:15:31 +02:00
Andreas Nedbal b3f15fe409 Remove unnecessary duplicate locales 2022-07-07 16:51:05 +02:00
Andreas Nedbal a8362702e3 Localize notification page title 2022-07-07 16:51:05 +02:00
Andreas Nedbal b551b7acdb Add translations for notification navigation 2022-07-07 16:51:05 +02:00
Andreas Nedbal af327b3f08 Add translations for notification types 2022-07-07 16:51:05 +02:00
Andreas Nedbal 52218bf1d0 Add translations for navigation index page 2022-07-07 16:51:05 +02:00
Andreas Nedbal 334c30e773 Remove notification navigation bar 2022-07-07 16:51:05 +02:00
Andreas Nedbal 9fc3e535d2 Apply review suggestion from @raccube
Co-authored-by: Karina Kwiatek <6197148+raccube@users.noreply.github.com>
2022-07-06 21:54:34 +02:00
Andreas Nedbal 73ac742332 Add translations for ajax controller error handling 2022-07-06 21:54:34 +02:00
Andreas Nedbal 6d4478b7c4 Remove subscription ajax controller locales 2022-07-06 21:54:34 +02:00
Andreas Nedbal e670a50adf Add translations for report ajax controller 2022-07-06 21:54:34 +02:00
Andreas Nedbal 9460bcfdd7 Add translations for answer ajax controller 2022-07-06 21:54:34 +02:00
Andreas Nedbal 80172d0852 Add translations for question ajax controller 2022-07-06 21:54:34 +02:00
Andreas Nedbal 2237ff8f04 Add translations for moderation ajax controller 2022-07-06 21:54:34 +02:00
Andreas Nedbal e6e7780142 Add translations for list ajax controller 2022-07-06 21:54:34 +02:00
Andreas Nedbal 1c31ff41db Add translations for inbox ajax controller 2022-07-06 21:54:34 +02:00
Andreas Nedbal 15946740eb Add translations for comment ajax controller 2022-07-06 21:54:34 +02:00
Andreas Nedbal 7381a685ac Add translations for smile ajax controller 2022-07-06 21:54:34 +02:00
Andreas Nedbal 34de119bb1 Add translations for block/relationship ajax controllers 2022-07-06 21:54:34 +02:00
Karina Kwiatek 8a6a9c21ec Appease the dog overlords
These counters are legacy and will later be removed.
2022-07-06 20:58:53 +02:00
Karina Kwiatek 539505eccd Ensure counters only get updated if the record exists 2022-07-06 20:58:53 +02:00
Karina Kwiatek e2462b1e51 Correct lint errors
(only on lines affected in this PR)
2022-07-06 20:58:53 +02:00
Karina Kwiatek e7112f0244 Use `dependent: :destroy_async` instead of `DeletionWorker` 2022-07-06 20:58:53 +02:00
Karina Kwiatek 0db369a9ae Remove comment_smiles relationship from users 2022-07-06 20:48:50 +02:00
Karina Kwiatek c0dbc7d501 Always denotify when deleting reactions 2022-07-06 20:43:01 +02:00
Karina Kwiatek 1ec99dd767 Appease the dog overlords 2022-07-06 19:56:04 +02:00
Karina Kwiatek 9bcf1a80ad Merge `author_name` with `author_identifier` 2022-07-06 19:56:04 +02:00
Karina Kwiatek 561946cab9 Fix issues from bad rebase 2022-07-05 23:23:37 +02:00
Karina Kwiatek 22ec4db349 Remove `Smile` & `CommentSmile` 2022-07-05 23:23:37 +02:00
Karina Kwiatek 19dcb96dcd Update remaining usages of `Smile`/`CommentSmile` 2022-07-05 23:23:37 +02:00
Karina Kwiatek 08e5764bf3 Appease the dog overlords 2022-07-05 23:23:37 +02:00
Karina Kwiatek 5ba3fed56c Replace usage of `answer` in `before_destroy` of Reaction with `parent` 2022-07-05 23:23:37 +02:00
Karina Kwiatek f9ec11a616 Use `.class.name` for `target_type` in `Notification#make_notification` 2022-07-05 23:23:37 +02:00
Karina Kwiatek f20e407cc3 Fix notifications page crashing on reactions 2022-07-05 23:23:37 +02:00
Karina Kwiatek 0cfe5ee964 Replace usages of smiles with reaction appendables 2022-07-05 23:23:37 +02:00
Karina Kwiatek 5f0a546353 Refactor smiling answers to using reactions 2022-07-05 23:23:37 +02:00