Commit Graph

2643 Commits

Author SHA1 Message Date
Georg Gadinger 9d7c99fe9b
Merge pull request #974 from Retrospring/refactor/inbox
refactor inbox
2023-01-21 13:59:39 +01:00
Andreas Nedbal df3d4d71bb Appease the dog overlords 2023-01-21 13:44:53 +01:00
Andreas Nedbal de3e04812d Merge branch 'main' into feature/theme-stimulus 2023-01-21 13:40:58 +01:00
Andreas Nedbal fc30bf8cac Add more explicit message for format validation errors 2023-01-21 13:20:52 +01:00
Andreas Nedbal 47bccdb0c3 Fix screen_name regex being too lenient 2023-01-21 13:20:52 +01:00
Andreas Nedbal b72e679a62 Split format and length validation for User `screen_name` 2023-01-21 13:20:52 +01:00
Andreas Nedbal 18f428eddf Remove dropup notification menu from mobile 2023-01-21 12:53:49 +01:00
Karina Kwiatek 27318f302c Rename current icons to icon_ 2023-01-21 12:30:52 +01:00
Andreas Nedbal e7842fab86 Add missing form-label class to example input 2023-01-21 09:42:23 +01:00
Andreas Nedbal 07ea833d13 Add Stimulus capabilities controller 2023-01-21 04:53:20 +01:00
Andreas Nedbal e81e85cf9a Remove capabilities feature 2023-01-21 04:53:20 +01:00
Andreas Nedbal d4c2ca5e5e Don't set the collapse controller for entries that aren't long 2023-01-21 04:43:48 +01:00
Andreas Nedbal eae99cd9a5 Add collapse to profile questions 2023-01-21 04:43:48 +01:00
Georg Gadinger be55dee7db inbox: remove haml lints 2023-01-19 16:25:56 +01:00
Georg Gadinger c4724b8c62 inbox: refactor a bit further so the cyber dog shuts up 2023-01-19 16:21:21 +01:00
Georg Gadinger e5d8506a13 inbox: redirect away if there's no questions filtered by author 2023-01-19 11:57:56 +01:00
Georg Gadinger 30dec68e1b inbox: refactor show method, fix #959 2023-01-19 11:57:56 +01:00
Georg Gadinger 31ed9ba738 inbox: use underscored symbols instead of kebab strings 2023-01-19 11:57:55 +01:00
Georg Gadinger 2f82e3be31 inbox: only provide #show as GET 2023-01-19 11:57:55 +01:00
Andreas Nedbal 5f46c84850 remove console.log 2023-01-18 20:52:28 +01:00
Andreas Nedbal f5c4ed6954 Wire up theme controller and actions in view 2023-01-17 07:39:31 +01:00
Andreas Nedbal 5f529b2b26 Add Stimulus theme controller 2023-01-17 07:39:14 +01:00
Andreas Nedbal ab8d608458 Extract theme-related utilities 2023-01-17 07:38:32 +01:00
Andreas Nedbal 79fa204897 Remove theming handler features 2023-01-17 07:38:02 +01:00
Karina Kwiatek 596c1c5240 Remove underline on smiles list 2023-01-15 12:40:48 +01:00
Andreas Nedbal 61d77bf20e Fix announcements not closing when button is pressed 2023-01-13 19:00:23 +01:00
Andreas Nedbal 87630c87a6 Fix layout of announcements after Bootstrap 5 update 2023-01-13 19:00:23 +01:00
Karina Kwiatek 3dbbed3ef2 Shorten question text in notifications to short question length 2023-01-13 17:30:37 +01:00
Andreas Nedbal 8b4909ab80 use height limiting instead of legacy line-clamp 2023-01-13 15:58:07 +01:00
Andreas Nedbal 0d41da54b8 Fix layout for inbox entries as well 2023-01-12 23:21:08 +01:00
Andreas Nedbal f0b9a00923 Fix alignment of collapsibles in question headers
Co-Authored-By: Georg Gadinger <nilsding@nilsding.org>
2023-01-12 23:17:09 +01:00
Andreas Nedbal a2139213c7 Hide collapse from screenreaders
Co-Authored-By: Georg Gadinger <nilsding@nilsding.org>
2023-01-12 21:03:44 +01:00
Andreas Nedbal a8fb9fd701 Refactor render_theme method
Co-Authored-By: Georg Gadinger <nilsding@nilsding.org>
2023-01-12 21:03:44 +01:00
Andreas Nedbal e85f9d6867 Re-add support for detail page `display_all` condition 2023-01-12 21:03:44 +01:00
Andreas Nedbal 07a13d39da Add support for theme helper mapping specifying multiple target values 2023-01-12 21:03:44 +01:00
Andreas Nedbal 430cfa1a38 Add RGB variables for some theme colors 2023-01-12 21:03:44 +01:00
Andreas Nedbal a3b902b747 Add collapse to answerboxes and questions 2023-01-12 21:03:44 +01:00
Andreas Nedbal 46830f50cd Add Stimulus controller for collapse functionality 2023-01-12 21:03:44 +01:00
Andreas Nedbal 3258ea4f0b Implement shared collapse partial 2023-01-12 21:03:44 +01:00
Andreas Nedbal e8657891a9 Add wrapper -body classes to answerbox sections 2023-01-12 21:03:44 +01:00
Andreas Nedbal b66c2b1f36 add `long?` method and constant to Answer model 2023-01-12 21:03:44 +01:00
Karina Kwiatek c919b4913f
Merge branch 'main' into feature/long-questions 2023-01-11 22:24:58 +01:00
Andreas Nedbal c93255338e Add dev indicator to guest navbar 2023-01-11 22:24:16 +01:00
Andreas Nedbal 9150d09960 Apply review suggestion from @nilsding
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
2023-01-11 22:24:16 +01:00
Andreas Nedbal 710192e8fa Add "DEV" badge to navigation brand 2023-01-11 22:24:16 +01:00
Andreas Nedbal 8e915e1c0a Add dev env indicator to navigation 2023-01-11 22:24:16 +01:00
Andreas Nedbal 7970838659 Remove superfluous focus styling 2023-01-10 20:54:13 +01:00
Andreas Nedbal 6fa26340ef Add bigger shadow to popover 2023-01-10 20:53:55 +01:00
Andreas Nedbal 53bc270e08
Apply review suggestions from @nilsding
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
2023-01-10 20:49:37 +01:00
Andreas Nedbal 122935e723 only show formatting help on focus/hover in inbox entries 2023-01-10 16:05:50 +01:00
Andreas Nedbal cb7f9179e3 Add format help to inbox entries 2023-01-10 15:51:43 +01:00
Andreas Nedbal 30933e6ca1 Add Stimulus controller to launch format popup 2023-01-10 15:49:52 +01:00
Andreas Nedbal eccb51eab0 Add formatting help markup/translations 2023-01-10 15:48:56 +01:00
Karina Kwiatek 4e78efcae7 Add tests for sending long questions with question worker 2023-01-08 19:22:00 +01:00
Karina Kwiatek cfba963b55 Only reset character counters when they are present
Co-authored-by: Andreas Nedbal <git@pixelde.su>
2023-01-08 18:51:43 +01:00
Karina Kwiatek 7cdb0e4976 Respect long question setting in frontend 2023-01-08 17:12:46 +01:00
Karina Kwiatek 3a6814b908 Respect allow long questions setting 2023-01-08 14:03:54 +01:00
Karina Kwiatek ba7b19faee Add allow long questions option to profile settings 2023-01-08 13:14:21 +01:00
Karina Kwiatek 122be928bf
Merge pull request #934 from Retrospring/more-obvious-sharing-options
Make sharing options more obvious
2023-01-08 11:24:50 +00:00
Andreas Nedbal f6d7d6ae2d Fix initializers 2023-01-08 12:19:45 +01:00
Andreas Nedbal ce067a2d57 Move entrypoint to app/javascript/ 2023-01-08 12:19:45 +01:00
Andreas Nedbal 20e01d3a3f Install and setup jsbundling-rails with esbuild 2023-01-08 12:19:45 +01:00
Karina Kwiatek b65242d81e
Merge pull request #930 from Retrospring/fix/push-enable-when-subbed
Prevent push enable prompt (inbox) when already subscribed
2023-01-08 11:14:33 +00:00
Karina Kwiatek 4ac3483f1a Make sharing options more obvious 2023-01-06 17:38:27 +01:00
Georg Gadinger 04f1793058
Merge pull request #932 from Retrospring/om@nom.nom
typoed_email_validator: add new endings to the typo list
2023-01-06 14:55:25 +00:00
Georg Gadinger b6121b16f0
Merge pull request #929 from Retrospring/locale-gen
re-enable locale switching, add rake task to generate testing locales
2023-01-06 12:47:49 +00:00
Georg Gadinger 5b8e34aa1d add integration specs for changing locales 2023-01-06 13:37:22 +01:00
Georg Gadinger b81bbc2483 typoed_email_validator: add new endings to the typo list 2023-01-06 10:26:32 +01:00
Georg Gadinger ebcf9d7676 obey the dog 2023-01-06 10:04:31 +01:00
Karina Kwiatek 4457f2ed26 Prevent push enable prompt (inbox) when already subscribed 2023-01-05 23:20:36 +01:00
Georg Gadinger 8323f39ecd re-add locale switching logic
based on https://guides.rubyonrails.org/i18n.html\#managing-the-locale-across-requests
2023-01-05 15:20:33 +01:00
Karina Kwiatek 5db058cb73 Fix nav badge pills not being marked as HTML safe 2023-01-05 14:32:04 +01:00
Andreas Nedbal 01ab84aa31 Improve layout of inbox push info card 2023-01-05 12:32:50 +01:00
Karina Kwiatek 3180e10449
Merge pull request #924 from Retrospring/fix/webpush-multiple-init
Prevent WebPush init from attaching events multiple times
2023-01-05 11:32:43 +00:00
Karina Kwiatek 01f4ed499d Ensure enable button doesn't unexpectedly disappear
Co-authored-by: Andreas Nedbal <git@pixelde.su>
2023-01-05 11:53:19 +01:00
Karina Kwiatek 7673ecdadf Add missing return to subscription check 2023-01-05 11:22:43 +01:00
Karina Kwiatek 8a754de85c Rename subscriptionCheck.ts to settingsButtons.ts 2023-01-05 11:22:27 +01:00
Karina Kwiatek d288f6d6a3 Move subscription check logic into separate initializer 2023-01-05 11:08:13 +01:00
Andreas Nedbal cb740b64a9 remove duplicate stylesheet folder 2023-01-05 10:55:18 +01:00
Karina Kwiatek e93531a4af Prevent WebPush init from attaching events multiple times 2023-01-05 10:53:04 +01:00
Georg Gadinger b728c494d7 remove flag leftovers 2023-01-05 10:37:44 +01:00
Andreas Nedbal 84fcfb41a3 Fix Sass deprecation warnings 2023-01-05 10:35:52 +01:00
Andreas Nedbal dd830bd22b Fix order of icons and text on frontpage 2023-01-05 10:35:52 +01:00
Andreas Nedbal 0e47e06db1 Add bottom margin to mute rule inputs 2023-01-05 10:35:52 +01:00
Andreas Nedbal 61a9e39a3e Fix dropdowns in mobile navigation 2023-01-05 10:35:52 +01:00
Andreas Nedbal b7c7838b96 Make code HTML elements monospace again 2023-01-05 10:35:52 +01:00
Andreas Nedbal 5c583acf05 Give `bootstrap_color` a proper argument 2023-01-05 10:35:52 +01:00
Andreas Nedbal 58717c0e7f Fix ESLint nits 2023-01-05 10:35:52 +01:00
Andreas Nedbal c9b39ad1e5 Appease the dog overlords 2023-01-05 10:35:52 +01:00
Andreas Nedbal 0e97c7c80a Fix badge colors in various places 2023-01-05 10:35:52 +01:00
Andreas Nedbal da7e30f459 Remove link underlines in some places 2023-01-05 10:35:52 +01:00
Andreas Nedbal af01ab2950 Fix profile settings layout 2023-01-05 10:35:52 +01:00
Andreas Nedbal cea1190ab9 Remove and replace usage of media classes 2023-01-05 10:35:52 +01:00
Andreas Nedbal 68dd6da1f2 Remove and adjust jumbotron usage 2023-01-05 10:35:52 +01:00
Andreas Nedbal 5ce9972a3e Fix usages of btn-block class 2023-01-05 10:35:52 +01:00
Andreas Nedbal 49a972bfd3 Remove jQuery call to close question modal 2023-01-05 10:35:52 +01:00
Andreas Nedbal 2efaae6987 Fix modal/alert dismiss toggles 2023-01-05 10:35:52 +01:00
Andreas Nedbal c878862730 Remove `xxl` container width 2023-01-05 10:35:52 +01:00
Andreas Nedbal 99085f1836 Fix sizing of inline inbox action form 2023-01-05 10:35:52 +01:00
Andreas Nedbal 23c01a97be Fix text alignment classes 2023-01-05 10:35:52 +01:00