2017-04-14 18:17:07 -07:00
|
|
|
require 'rails_helper'
|
|
|
|
|
2018-05-02 09:58:48 -07:00
|
|
|
describe AccountSearchService, type: :service do
|
2017-04-14 18:17:07 -07:00
|
|
|
describe '.call' do
|
|
|
|
describe 'with a query to ignore' do
|
|
|
|
it 'returns empty array for missing query' do
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
results = subject.call('', nil, limit: 10)
|
2017-04-14 18:17:07 -07:00
|
|
|
|
|
|
|
expect(results).to eq []
|
|
|
|
end
|
|
|
|
it 'returns empty array for hashtag query' do
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
results = subject.call('#tag', nil, limit: 10)
|
2017-04-14 18:17:07 -07:00
|
|
|
|
2017-04-24 19:44:43 -07:00
|
|
|
expect(results).to eq []
|
|
|
|
end
|
|
|
|
it 'returns empty array for limit zero' do
|
|
|
|
Fabricate(:account, username: 'match')
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
results = subject.call('match', nil, limit: 0)
|
2017-04-24 19:44:43 -07:00
|
|
|
|
2017-04-14 18:17:07 -07:00
|
|
|
expect(results).to eq []
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'searching for a simple term that is not an exact match' do
|
|
|
|
it 'does not return a nil entry in the array for the exact match' do
|
|
|
|
match = Fabricate(:account, username: 'matchingusername')
|
|
|
|
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
results = subject.call('match', nil, limit: 5)
|
2017-04-14 18:17:07 -07:00
|
|
|
expect(results).to eq [match]
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'searching local and remote users' do
|
2017-04-17 10:57:02 -07:00
|
|
|
describe "when only '@'" do
|
|
|
|
before do
|
2017-05-26 15:55:08 -07:00
|
|
|
allow(Account).to receive(:find_local)
|
2017-04-17 10:57:02 -07:00
|
|
|
allow(Account).to receive(:search_for)
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
subject.call('@', nil, limit: 10)
|
2017-04-17 10:57:02 -07:00
|
|
|
end
|
|
|
|
|
2017-05-26 15:55:08 -07:00
|
|
|
it 'uses find_local with empty query to look for local accounts' do
|
|
|
|
expect(Account).to have_received(:find_local).with('')
|
2017-04-17 10:57:02 -07:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-04-14 18:17:07 -07:00
|
|
|
describe 'when no domain' do
|
|
|
|
before do
|
2017-05-26 15:55:08 -07:00
|
|
|
allow(Account).to receive(:find_local)
|
2017-04-14 18:17:07 -07:00
|
|
|
allow(Account).to receive(:search_for)
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
subject.call('one', nil, limit: 10)
|
2017-04-14 18:17:07 -07:00
|
|
|
end
|
|
|
|
|
2017-05-26 15:55:08 -07:00
|
|
|
it 'uses find_local to look for local accounts' do
|
|
|
|
expect(Account).to have_received(:find_local).with('one')
|
2017-04-14 18:17:07 -07:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'uses search_for to find matches' do
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
expect(Account).to have_received(:search_for).with('one', 10, 0)
|
2017-04-14 18:17:07 -07:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'when there is a domain' do
|
|
|
|
before do
|
|
|
|
allow(Account).to receive(:find_remote)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'uses find_remote to look for remote accounts' do
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
subject.call('two@example.com', nil, limit: 10)
|
2017-04-14 18:17:07 -07:00
|
|
|
expect(Account).to have_received(:find_remote).with('two', 'example.com')
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'and there is no account provided' do
|
|
|
|
it 'uses search_for to find matches' do
|
|
|
|
allow(Account).to receive(:search_for)
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
subject.call('two@example.com', nil, limit: 10, resolve: false)
|
2017-04-14 18:17:07 -07:00
|
|
|
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
expect(Account).to have_received(:search_for).with('two example.com', 10, 0)
|
2017-04-14 18:17:07 -07:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'and there is an account provided' do
|
|
|
|
it 'uses advanced_search_for to find matches' do
|
|
|
|
account = Fabricate(:account)
|
|
|
|
allow(Account).to receive(:advanced_search_for)
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
subject.call('two@example.com', account, limit: 10, resolve: false)
|
2017-04-14 18:17:07 -07:00
|
|
|
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
expect(Account).to have_received(:advanced_search_for).with('two example.com', account, 10, nil, 0)
|
2017-04-14 18:17:07 -07:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'with an exact match' do
|
|
|
|
it 'returns exact match first, and does not return duplicates' do
|
|
|
|
partial = Fabricate(:account, username: 'exactness')
|
|
|
|
exact = Fabricate(:account, username: 'exact')
|
|
|
|
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
results = subject.call('exact', nil, limit: 10)
|
2017-04-14 18:17:07 -07:00
|
|
|
expect(results.size).to eq 2
|
|
|
|
expect(results).to eq [exact, partial]
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-05-26 15:55:08 -07:00
|
|
|
describe 'when there is a local domain' do
|
|
|
|
around do |example|
|
|
|
|
before = Rails.configuration.x.local_domain
|
|
|
|
example.run
|
|
|
|
Rails.configuration.x.local_domain = before
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns exact match first' do
|
|
|
|
remote = Fabricate(:account, username: 'a', domain: 'remote', display_name: 'e')
|
|
|
|
remote_too = Fabricate(:account, username: 'b', domain: 'remote', display_name: 'e')
|
|
|
|
exact = Fabricate(:account, username: 'e')
|
|
|
|
Rails.configuration.x.local_domain = 'example.com'
|
|
|
|
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
results = subject.call('e@example.com', nil, limit: 2)
|
2017-05-26 15:55:08 -07:00
|
|
|
expect(results.size).to eq 2
|
|
|
|
expect(results).to eq([exact, remote]).or eq([exact, remote_too])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-04-14 18:17:07 -07:00
|
|
|
describe 'when there is a domain but no exact match' do
|
|
|
|
it 'follows the remote account when resolve is true' do
|
|
|
|
service = double(call: nil)
|
2018-01-22 05:25:09 -08:00
|
|
|
allow(ResolveAccountService).to receive(:new).and_return(service)
|
2017-04-14 18:17:07 -07:00
|
|
|
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
results = subject.call('newuser@remote.com', nil, limit: 10, resolve: true)
|
2017-04-14 18:17:07 -07:00
|
|
|
expect(service).to have_received(:call).with('newuser@remote.com')
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not follow the remote account when resolve is false' do
|
|
|
|
service = double(call: nil)
|
2018-01-22 05:25:09 -08:00
|
|
|
allow(ResolveAccountService).to receive(:new).and_return(service)
|
2017-04-14 18:17:07 -07:00
|
|
|
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
results = subject.call('newuser@remote.com', nil, limit: 10, resolve: false)
|
2017-04-14 18:17:07 -07:00
|
|
|
expect(service).not_to have_received(:call)
|
|
|
|
end
|
|
|
|
end
|
2018-04-23 12:27:18 -07:00
|
|
|
|
|
|
|
describe 'should not include suspended accounts' do
|
|
|
|
it 'returns the fuzzy match first, and does not return suspended exacts' do
|
|
|
|
partial = Fabricate(:account, username: 'exactness')
|
|
|
|
exact = Fabricate(:account, username: 'exact', suspended: true)
|
|
|
|
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
results = subject.call('exact', nil, limit: 10)
|
2018-04-23 12:27:18 -07:00
|
|
|
expect(results.size).to eq 1
|
|
|
|
expect(results).to eq [partial]
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not return suspended remote accounts" do
|
|
|
|
remote = Fabricate(:account, username: 'a', domain: 'remote', display_name: 'e', suspended: true)
|
|
|
|
|
Add type, limit, offset, min_id, max_id, account_id to search API (#10091)
* Add type, limit, offset, min_id, max_id, account_id to search API
Fix #8939
* Make the offset work on accounts and hashtags search as well
* Assure brakeman we are not doing mass assignment here
* Do not allow paginating unless a type is chosen
* Fix search query and index id field on statuses instead of created_at
2019-02-26 06:21:36 -08:00
|
|
|
results = subject.call('a@example.com', nil, limit: 2)
|
2018-04-23 12:27:18 -07:00
|
|
|
expect(results.size).to eq 0
|
|
|
|
expect(results).to eq []
|
|
|
|
end
|
|
|
|
end
|
2017-04-14 18:17:07 -07:00
|
|
|
end
|
|
|
|
end
|