2016-11-15 07:56:29 -08:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-02-24 09:25:04 -08:00
|
|
|
class PostStatusService < BaseService
|
2019-02-02 10:11:38 -08:00
|
|
|
include Redisable
|
2022-02-07 17:41:17 -08:00
|
|
|
include LanguagesHelper
|
2019-02-02 10:11:38 -08:00
|
|
|
|
2019-01-05 03:43:28 -08:00
|
|
|
MIN_SCHEDULE_OFFSET = 5.minutes.freeze
|
|
|
|
|
2016-02-24 09:50:16 -08:00
|
|
|
# Post a text status update, fetch and notify remote users mentioned
|
|
|
|
# @param [Account] account Account from which to post
|
2016-11-23 01:46:48 -08:00
|
|
|
# @param [Hash] options
|
2019-01-05 03:43:28 -08:00
|
|
|
# @option [String] :text Message
|
|
|
|
# @option [Status] :thread Optional status to reply to
|
2016-11-23 01:46:48 -08:00
|
|
|
# @option [Boolean] :sensitive
|
2017-01-15 05:01:33 -08:00
|
|
|
# @option [String] :visibility
|
2017-01-12 20:54:26 -08:00
|
|
|
# @option [String] :spoiler_text
|
2019-01-05 03:43:28 -08:00
|
|
|
# @option [String] :language
|
|
|
|
# @option [String] :scheduled_at
|
2019-03-03 13:18:23 -08:00
|
|
|
# @option [Hash] :poll Optional poll to attach
|
2016-11-23 01:46:48 -08:00
|
|
|
# @option [Enumerable] :media_ids Optional array of media IDs to attach
|
2017-01-15 05:01:33 -08:00
|
|
|
# @option [Doorkeeper::Application] :application
|
2017-04-25 06:04:49 -07:00
|
|
|
# @option [String] :idempotency Optional idempotency key
|
2020-03-08 07:17:39 -07:00
|
|
|
# @option [Boolean] :with_rate_limit
|
2016-02-24 09:50:16 -08:00
|
|
|
# @return [Status]
|
2019-01-05 03:43:28 -08:00
|
|
|
def call(account, options = {})
|
|
|
|
@account = account
|
|
|
|
@options = options
|
|
|
|
@text = @options[:text] || ''
|
|
|
|
@in_reply_to = @options[:thread]
|
|
|
|
|
|
|
|
return idempotency_duplicate if idempotency_given? && idempotency_duplicate?
|
|
|
|
|
|
|
|
validate_media!
|
|
|
|
preprocess_attributes!
|
|
|
|
|
|
|
|
if scheduled?
|
|
|
|
schedule_status!
|
|
|
|
else
|
|
|
|
process_status!
|
2017-04-25 06:04:49 -07:00
|
|
|
end
|
|
|
|
|
2019-01-05 03:43:28 -08:00
|
|
|
redis.setex(idempotency_key, 3_600, @status.id) if idempotency_given?
|
2017-07-14 10:47:53 -07:00
|
|
|
|
Fix idempotency when database writes are slow (#21840)
There is an idempotency key generated by clients when authoring a post,
and stored in Redis, to ensure that if a user or client retries posting
the same status, we don't get a duplicate.
Hachyderm.io has been experiencing some filesystem and database
performance issues, causing database writes to be slow. This can mean
that there are successful posts, but the reverse proxy returns 504
Gateway Timeout before the idempotency status has been updated; users or
clients who retry (such as Tusky which retries automatically, see
tuskyapp/Tusky#2951) can re-try the same post with the same idempotency
key before it has actually been recorded in Redis, leading to duplicate
posts.
To address this issue, move all of the database updates after the
initial transaction that creates the status into the
`postprocess_status!` method, so we can insert the idempotency key
immediately after the status has been created, significantly reducing
the window in which the status could be created but the idempotency key
not yet stored.
Note: this has not yet been tested; I'm submitting this PR for
discussion and to offer to the Hachyderm.io admins to try out to fix the
multiple posting problem.
Co-authored-by: Brian Campbell <brcampbell@beta.team>
2022-12-15 09:08:40 -08:00
|
|
|
unless scheduled?
|
|
|
|
postprocess_status!
|
|
|
|
bump_potential_friendship!
|
|
|
|
end
|
|
|
|
|
2019-01-05 03:43:28 -08:00
|
|
|
@status
|
|
|
|
end
|
2018-12-24 10:06:14 -08:00
|
|
|
|
2019-01-05 03:43:28 -08:00
|
|
|
private
|
2017-07-14 10:47:53 -07:00
|
|
|
|
2019-01-05 03:43:28 -08:00
|
|
|
def preprocess_attributes!
|
2019-01-10 10:12:10 -08:00
|
|
|
if @text.blank? && @options[:spoiler_text].present?
|
|
|
|
@text = '.'
|
2020-03-27 14:28:39 -07:00
|
|
|
if @media&.find(&:video?) || @media&.find(&:gifv?)
|
2019-08-31 04:09:21 -07:00
|
|
|
@text = '📹'
|
2020-03-27 14:28:39 -07:00
|
|
|
elsif @media&.find(&:audio?)
|
2019-08-31 04:09:21 -07:00
|
|
|
@text = '🎵'
|
2020-03-27 14:28:39 -07:00
|
|
|
elsif @media&.find(&:image?)
|
2019-08-31 04:09:21 -07:00
|
|
|
@text = '🖼'
|
|
|
|
end
|
2018-10-20 10:14:46 -07:00
|
|
|
end
|
2020-03-25 14:40:58 -07:00
|
|
|
@sensitive = (@options[:sensitive].nil? ? @account.user&.setting_default_sensitive : @options[:sensitive]) || @options[:spoiler_text].present?
|
2019-01-05 03:43:28 -08:00
|
|
|
@visibility = @options[:visibility] || @account.user&.setting_default_privacy
|
2020-03-08 08:11:49 -07:00
|
|
|
@visibility = :unlisted if @visibility&.to_sym == :public && @account.silenced?
|
2019-01-05 03:43:28 -08:00
|
|
|
@scheduled_at = @options[:scheduled_at]&.to_datetime
|
|
|
|
@scheduled_at = nil if scheduled_in_the_past?
|
2019-01-19 13:01:01 -08:00
|
|
|
rescue ArgumentError
|
|
|
|
raise ActiveRecord::RecordInvalid
|
2019-01-05 03:43:28 -08:00
|
|
|
end
|
2017-07-14 10:47:53 -07:00
|
|
|
|
2019-01-05 03:43:28 -08:00
|
|
|
def process_status!
|
|
|
|
# The following transaction block is needed to wrap the UPDATEs to
|
|
|
|
# the media attachments when the status is created
|
2018-12-24 10:06:14 -08:00
|
|
|
|
2017-04-25 18:47:44 -07:00
|
|
|
ApplicationRecord.transaction do
|
2019-01-05 03:43:28 -08:00
|
|
|
@status = @account.statuses.create!(status_attributes)
|
2017-04-25 18:47:44 -07:00
|
|
|
end
|
2016-02-24 09:25:04 -08:00
|
|
|
end
|
2016-11-28 04:36:47 -08:00
|
|
|
|
2019-01-05 03:43:28 -08:00
|
|
|
def schedule_status!
|
2019-01-21 11:03:04 -08:00
|
|
|
status_for_validation = @account.statuses.build(status_attributes)
|
2019-03-15 05:36:38 -07:00
|
|
|
|
2019-01-21 11:03:04 -08:00
|
|
|
if status_for_validation.valid?
|
2021-10-14 10:59:21 -07:00
|
|
|
# Marking the status as destroyed is necessary to prevent the status from being
|
|
|
|
# persisted when the associated media attachments get updated when creating the
|
|
|
|
# scheduled status.
|
2019-01-21 11:03:04 -08:00
|
|
|
status_for_validation.destroy
|
|
|
|
|
2019-01-05 03:43:28 -08:00
|
|
|
# The following transaction block is needed to wrap the UPDATEs to
|
|
|
|
# the media attachments when the scheduled status is created
|
2017-06-05 15:34:08 -07:00
|
|
|
|
2019-01-05 03:43:28 -08:00
|
|
|
ApplicationRecord.transaction do
|
|
|
|
@status = @account.scheduled_statuses.create!(scheduled_status_attributes)
|
|
|
|
end
|
|
|
|
else
|
|
|
|
raise ActiveRecord::RecordInvalid
|
2017-06-05 15:34:08 -07:00
|
|
|
end
|
2019-01-05 03:43:28 -08:00
|
|
|
end
|
2016-11-28 04:36:47 -08:00
|
|
|
|
2019-01-05 03:43:28 -08:00
|
|
|
def postprocess_status!
|
Fix idempotency when database writes are slow (#21840)
There is an idempotency key generated by clients when authoring a post,
and stored in Redis, to ensure that if a user or client retries posting
the same status, we don't get a duplicate.
Hachyderm.io has been experiencing some filesystem and database
performance issues, causing database writes to be slow. This can mean
that there are successful posts, but the reverse proxy returns 504
Gateway Timeout before the idempotency status has been updated; users or
clients who retry (such as Tusky which retries automatically, see
tuskyapp/Tusky#2951) can re-try the same post with the same idempotency
key before it has actually been recorded in Redis, leading to duplicate
posts.
To address this issue, move all of the database updates after the
initial transaction that creates the status into the
`postprocess_status!` method, so we can insert the idempotency key
immediately after the status has been created, significantly reducing
the window in which the status could be created but the idempotency key
not yet stored.
Note: this has not yet been tested; I'm submitting this PR for
discussion and to offer to the Hachyderm.io admins to try out to fix the
multiple posting problem.
Co-authored-by: Brian Campbell <brcampbell@beta.team>
2022-12-15 09:08:40 -08:00
|
|
|
process_hashtags_service.call(@status)
|
|
|
|
process_mentions_service.call(@status)
|
2021-11-25 04:07:38 -08:00
|
|
|
Trends.tags.register(@status)
|
|
|
|
LinkCrawlWorker.perform_async(@status.id)
|
2019-01-05 03:43:28 -08:00
|
|
|
DistributionWorker.perform_async(@status.id)
|
2019-07-19 09:26:49 -07:00
|
|
|
ActivityPub::DistributionWorker.perform_async(@status.id) unless @status.local_only?
|
2019-03-10 16:49:31 -07:00
|
|
|
PollExpirationNotifyWorker.perform_at(@status.poll.expires_at, @status.poll.id) if @status.poll
|
2016-02-24 09:25:04 -08:00
|
|
|
end
|
|
|
|
|
2019-01-05 03:43:28 -08:00
|
|
|
def validate_media!
|
2022-03-09 00:06:17 -08:00
|
|
|
if @options[:media_ids].blank? || !@options[:media_ids].is_a?(Enumerable)
|
|
|
|
@media = []
|
|
|
|
return
|
|
|
|
end
|
2017-02-26 14:23:06 -08:00
|
|
|
|
2019-03-03 15:40:21 -08:00
|
|
|
raise Mastodon::ValidationError, I18n.t('media_attachments.validations.too_many') if @options[:media_ids].size > 4 || @options[:poll].present?
|
2017-02-26 14:23:06 -08:00
|
|
|
|
2019-01-26 14:59:39 -08:00
|
|
|
@media = @account.media_attachments.where(status_id: nil).where(id: @options[:media_ids].take(4).map(&:to_i))
|
2017-02-26 14:23:06 -08:00
|
|
|
|
2019-06-19 14:42:38 -07:00
|
|
|
raise Mastodon::ValidationError, I18n.t('media_attachments.validations.images_and_video') if @media.size > 1 && @media.find(&:audio_or_video?)
|
2020-03-08 15:56:18 -07:00
|
|
|
raise Mastodon::ValidationError, I18n.t('media_attachments.validations.not_ready') if @media.any?(&:not_processed?)
|
2017-02-04 19:03:24 -08:00
|
|
|
end
|
|
|
|
|
2016-02-24 15:17:01 -08:00
|
|
|
def process_mentions_service
|
2017-10-27 10:08:30 -07:00
|
|
|
ProcessMentionsService.new
|
2016-02-24 09:44:03 -08:00
|
|
|
end
|
2016-11-05 07:20:05 -07:00
|
|
|
|
|
|
|
def process_hashtags_service
|
2017-10-27 10:08:30 -07:00
|
|
|
ProcessHashtagsService.new
|
2016-11-05 07:20:05 -07:00
|
|
|
end
|
2017-04-25 06:04:49 -07:00
|
|
|
|
2019-01-05 03:43:28 -08:00
|
|
|
def scheduled?
|
|
|
|
@scheduled_at.present?
|
|
|
|
end
|
|
|
|
|
|
|
|
def idempotency_key
|
|
|
|
"idempotency:status:#{@account.id}:#{@options[:idempotency]}"
|
|
|
|
end
|
|
|
|
|
|
|
|
def idempotency_given?
|
|
|
|
@options[:idempotency].present?
|
|
|
|
end
|
|
|
|
|
|
|
|
def idempotency_duplicate
|
|
|
|
if scheduled?
|
|
|
|
@account.schedule_statuses.find(@idempotency_duplicate)
|
|
|
|
else
|
|
|
|
@account.statuses.find(@idempotency_duplicate)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def idempotency_duplicate?
|
|
|
|
@idempotency_duplicate = redis.get(idempotency_key)
|
|
|
|
end
|
|
|
|
|
|
|
|
def scheduled_in_the_past?
|
|
|
|
@scheduled_at.present? && @scheduled_at <= Time.now.utc + MIN_SCHEDULE_OFFSET
|
|
|
|
end
|
|
|
|
|
|
|
|
def bump_potential_friendship!
|
|
|
|
return if !@status.reply? || @account.id == @status.in_reply_to_account_id
|
2018-07-16 09:35:43 -07:00
|
|
|
ActivityTracker.increment('activity:interactions')
|
2019-01-05 03:43:28 -08:00
|
|
|
return if @account.following?(@status.in_reply_to_account_id)
|
|
|
|
PotentialFriendshipTracker.record(@account.id, @status.in_reply_to_account_id, :reply)
|
|
|
|
end
|
|
|
|
|
|
|
|
def status_attributes
|
|
|
|
{
|
|
|
|
text: @text,
|
|
|
|
media_attachments: @media || [],
|
2022-03-09 00:06:17 -08:00
|
|
|
ordered_media_attachment_ids: (@options[:media_ids] || []).map(&:to_i) & @media.map(&:id),
|
2019-01-05 03:43:28 -08:00
|
|
|
thread: @in_reply_to,
|
2019-03-27 20:44:59 -07:00
|
|
|
poll_attributes: poll_attributes,
|
2020-03-25 14:40:58 -07:00
|
|
|
sensitive: @sensitive,
|
2019-01-05 03:43:28 -08:00
|
|
|
spoiler_text: @options[:spoiler_text] || '',
|
|
|
|
visibility: @visibility,
|
2022-03-08 23:46:05 -08:00
|
|
|
language: valid_locale_cascade(@options[:language], @account.user&.preferred_posting_language, I18n.default_locale),
|
2019-01-05 03:43:28 -08:00
|
|
|
application: @options[:application],
|
2019-05-13 05:42:39 -07:00
|
|
|
content_type: @options[:content_type] || @account.user&.setting_default_content_type,
|
2020-03-08 07:17:39 -07:00
|
|
|
rate_limit: @options[:with_rate_limit],
|
2019-03-15 05:36:38 -07:00
|
|
|
}.compact
|
2019-01-05 03:43:28 -08:00
|
|
|
end
|
|
|
|
|
|
|
|
def scheduled_status_attributes
|
|
|
|
{
|
|
|
|
scheduled_at: @scheduled_at,
|
|
|
|
media_attachments: @media || [],
|
|
|
|
params: scheduled_options,
|
|
|
|
}
|
|
|
|
end
|
|
|
|
|
2019-03-15 05:36:38 -07:00
|
|
|
def poll_attributes
|
|
|
|
return if @options[:poll].blank?
|
|
|
|
|
2019-09-29 13:58:01 -07:00
|
|
|
@options[:poll].merge(account: @account, voters_count: 0)
|
2019-03-15 05:36:38 -07:00
|
|
|
end
|
|
|
|
|
2019-01-05 03:43:28 -08:00
|
|
|
def scheduled_options
|
|
|
|
@options.tap do |options_hash|
|
2020-03-08 07:17:39 -07:00
|
|
|
options_hash[:in_reply_to_id] = options_hash.delete(:thread)&.id
|
|
|
|
options_hash[:application_id] = options_hash.delete(:application)&.id
|
|
|
|
options_hash[:scheduled_at] = nil
|
|
|
|
options_hash[:idempotency] = nil
|
|
|
|
options_hash[:with_rate_limit] = false
|
2019-01-05 03:43:28 -08:00
|
|
|
end
|
Re-add follow recommendations API (#7918)
* Re-add follow recommendations API
GET /api/v1/suggestions
Removed in 8efa081f210d72ed450c39ac4cde0fd84fb3d3fb due to Neo4J
dependency. The algorithm uses triadic closures, takes into account
suspensions, blocks, mutes, domain blocks, excludes locked and moved
accounts, and prefers more recently updated accounts.
* Track interactions with people you don't follow
Replying to, favouriting and reblogging someone you're not following
will make them show up in follow recommendations. The interactions
have different weights:
- Replying is 1
- Favouriting is 10 (decidedly positive interaction, but private)
- Reblogging is 20
Following them, muting or blocking will remove them from the list,
obviously.
* Remove triadic closures, ensure potential friendships are trimmed
2018-07-02 16:47:56 -07:00
|
|
|
end
|
2016-02-24 09:25:04 -08:00
|
|
|
end
|