From 3a5c456aa82b078d72f50e89e3173200bdc503bf Mon Sep 17 00:00:00 2001
From: fef <owo@fef.moe>
Date: Fri, 2 Dec 2022 01:00:08 +0000
Subject: [PATCH] rename nop handler to handleNoOp

This also adds the comment in action_bar.js to
status_action_bar.js, clarifying that a future
version could improve this code by modifying
EmojiPickerDropdown.
---
 .../flavours/glitch/components/status_action_bar.jsx          | 4 ++--
 .../flavours/glitch/features/status/components/action_bar.jsx | 4 ++--
 app/javascript/mastodon/components/status_action_bar.jsx      | 4 ++--
 .../mastodon/features/status/components/action_bar.jsx        | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/app/javascript/flavours/glitch/components/status_action_bar.jsx b/app/javascript/flavours/glitch/components/status_action_bar.jsx
index c38693641..d03f84ea4 100644
--- a/app/javascript/flavours/glitch/components/status_action_bar.jsx
+++ b/app/javascript/flavours/glitch/components/status_action_bar.jsx
@@ -208,7 +208,7 @@ class StatusActionBar extends ImmutablePureComponent {
     this.props.onAddFilter(this.props.status);
   };
 
-  nop = () => {}
+  handleNoOp = () => {} // hack for reaction add button
 
   render () {
     const { status, intl, withDismiss, withCounters, showReplyCount, scrollKey } = this.props;
@@ -318,7 +318,7 @@ class StatusActionBar extends ImmutablePureComponent {
     const reactButton = (
       <IconButton
         className='status__action-bar-button'
-        onClick={this.nop} // EmojiPickerDropdown handles that
+        onClick={this.handleNoOp} // EmojiPickerDropdown handles that
         title={intl.formatMessage(messages.react)}
         disabled={!canReact}
         icon='plus'
diff --git a/app/javascript/flavours/glitch/features/status/components/action_bar.jsx b/app/javascript/flavours/glitch/features/status/components/action_bar.jsx
index 4b30bd7f3..5a44db63c 100644
--- a/app/javascript/flavours/glitch/features/status/components/action_bar.jsx
+++ b/app/javascript/flavours/glitch/features/status/components/action_bar.jsx
@@ -144,7 +144,7 @@ class ActionBar extends React.PureComponent {
     navigator.clipboard.writeText(url);
   };
 
-  nop = () => {} // hack for reaction add button
+  handleNoOp = () => {} // hack for reaction add button
 
   render () {
     const { status, intl } = this.props;
@@ -207,7 +207,7 @@ class ActionBar extends React.PureComponent {
     const reactButton = (
       <IconButton
         className='plus-icon'
-        onClick={this.nop} // EmojiPickerDropdown handles that
+        onClick={this.handleNoOp} // EmojiPickerDropdown handles that
         title={intl.formatMessage(messages.react)}
         disabled={!canReact}
         icon='plus'
diff --git a/app/javascript/mastodon/components/status_action_bar.jsx b/app/javascript/mastodon/components/status_action_bar.jsx
index 342b5a6ca..c33468875 100644
--- a/app/javascript/mastodon/components/status_action_bar.jsx
+++ b/app/javascript/mastodon/components/status_action_bar.jsx
@@ -242,7 +242,7 @@ class StatusActionBar extends ImmutablePureComponent {
     this.props.onFilter();
   };
 
-  nop = () => {}
+  handleNoOp = () => {} // hack for reaction add button
 
   render () {
     const { status, relationship, intl, withDismiss, withCounters, scrollKey } = this.props;
@@ -374,7 +374,7 @@ class StatusActionBar extends ImmutablePureComponent {
     const reactButton = (
       <IconButton
         className='status__action-bar-button'
-        onClick={this.nop} // EmojiPickerDropdown handles that
+        onClick={this.handleNoOp} // EmojiPickerDropdown handles that
         title={intl.formatMessage(messages.react)}
         disabled={!canReact}
         icon='plus'
diff --git a/app/javascript/mastodon/features/status/components/action_bar.jsx b/app/javascript/mastodon/features/status/components/action_bar.jsx
index 8e0ee0c6b..802db1483 100644
--- a/app/javascript/mastodon/features/status/components/action_bar.jsx
+++ b/app/javascript/mastodon/features/status/components/action_bar.jsx
@@ -189,7 +189,7 @@ class ActionBar extends React.PureComponent {
     navigator.clipboard.writeText(url);
   };
 
-  nop = () => {} // hack for reaction add button
+  handleNoOp = () => {} // hack for reaction add button
 
   render () {
     const { status, relationship, intl } = this.props;
@@ -272,7 +272,7 @@ class ActionBar extends React.PureComponent {
     const reactButton = (
       <IconButton
         className='plus-icon'
-        onClick={this.nop} // EmojiPickerDropdown handles that
+        onClick={this.handleNoOp} // EmojiPickerDropdown handles that
         title={intl.formatMessage(messages.react)}
         disabled={!canReact}
         icon='plus'