From 6f1fa1364f40e991389718823fb3bcb1da30bbf5 Mon Sep 17 00:00:00 2001
From: Matt Jankowski <matt@jankowski.online>
Date: Fri, 28 Jul 2023 17:15:33 -0400
Subject: [PATCH] Fix `RSpec/EmptyExampleGroup` cop (#24735)

---
 .rubocop_todo.yml                             | 35 -------------------
 spec/helpers/admin/action_logs_helper_spec.rb |  6 ----
 spec/models/account_alias_spec.rb             |  6 ----
 spec/models/account_deletion_request_spec.rb  |  6 ----
 spec/models/account_moderation_note_spec.rb   |  6 ----
 spec/models/announcement_mute_spec.rb         |  6 ----
 spec/models/announcement_reaction_spec.rb     |  6 ----
 spec/models/announcement_spec.rb              |  6 ----
 spec/models/backup_spec.rb                    |  6 ----
 spec/models/conversation_mute_spec.rb         |  6 ----
 spec/models/custom_filter_keyword_spec.rb     |  6 ----
 spec/models/custom_filter_spec.rb             |  6 ----
 spec/models/device_spec.rb                    |  6 ----
 spec/models/encrypted_message_spec.rb         |  6 ----
 spec/models/featured_tag_spec.rb              |  6 ----
 .../follow_recommendation_suppression_spec.rb |  6 ----
 spec/models/list_account_spec.rb              |  6 ----
 spec/models/list_spec.rb                      |  6 ----
 spec/models/login_activity_spec.rb            |  6 ----
 spec/models/mute_spec.rb                      |  6 ----
 spec/models/preview_card_spec.rb              |  6 ----
 spec/models/preview_card_trend_spec.rb        |  6 ----
 spec/models/relay_spec.rb                     |  6 ----
 spec/models/scheduled_status_spec.rb          |  6 ----
 spec/models/status_stat_spec.rb               |  6 ----
 spec/models/status_trend_spec.rb              |  6 ----
 spec/models/system_key_spec.rb                |  6 ----
 spec/models/tag_follow_spec.rb                |  6 ----
 spec/models/unavailable_domain_spec.rb        |  6 ----
 spec/models/user_invite_request_spec.rb       |  6 ----
 spec/models/web/setting_spec.rb               |  6 ----
 spec/services/unmute_service_spec.rb          |  7 ----
 32 files changed, 222 deletions(-)
 delete mode 100644 spec/helpers/admin/action_logs_helper_spec.rb
 delete mode 100644 spec/models/account_alias_spec.rb
 delete mode 100644 spec/models/account_deletion_request_spec.rb
 delete mode 100644 spec/models/account_moderation_note_spec.rb
 delete mode 100644 spec/models/announcement_mute_spec.rb
 delete mode 100644 spec/models/announcement_reaction_spec.rb
 delete mode 100644 spec/models/announcement_spec.rb
 delete mode 100644 spec/models/backup_spec.rb
 delete mode 100644 spec/models/conversation_mute_spec.rb
 delete mode 100644 spec/models/custom_filter_keyword_spec.rb
 delete mode 100644 spec/models/custom_filter_spec.rb
 delete mode 100644 spec/models/device_spec.rb
 delete mode 100644 spec/models/encrypted_message_spec.rb
 delete mode 100644 spec/models/featured_tag_spec.rb
 delete mode 100644 spec/models/follow_recommendation_suppression_spec.rb
 delete mode 100644 spec/models/list_account_spec.rb
 delete mode 100644 spec/models/list_spec.rb
 delete mode 100644 spec/models/login_activity_spec.rb
 delete mode 100644 spec/models/mute_spec.rb
 delete mode 100644 spec/models/preview_card_spec.rb
 delete mode 100644 spec/models/preview_card_trend_spec.rb
 delete mode 100644 spec/models/relay_spec.rb
 delete mode 100644 spec/models/scheduled_status_spec.rb
 delete mode 100644 spec/models/status_stat_spec.rb
 delete mode 100644 spec/models/status_trend_spec.rb
 delete mode 100644 spec/models/system_key_spec.rb
 delete mode 100644 spec/models/tag_follow_spec.rb
 delete mode 100644 spec/models/unavailable_domain_spec.rb
 delete mode 100644 spec/models/user_invite_request_spec.rb
 delete mode 100644 spec/models/web/setting_spec.rb
 delete mode 100644 spec/services/unmute_service_spec.rb

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 0ffa4fb1c..972b496d5 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -183,41 +183,6 @@ RSpec/AnyInstance:
     - 'spec/workers/activitypub/delivery_worker_spec.rb'
     - 'spec/workers/web/push_notification_worker_spec.rb'
 
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/EmptyExampleGroup:
-  Exclude:
-    - 'spec/helpers/admin/action_logs_helper_spec.rb'
-    - 'spec/models/account_alias_spec.rb'
-    - 'spec/models/account_deletion_request_spec.rb'
-    - 'spec/models/account_moderation_note_spec.rb'
-    - 'spec/models/announcement_mute_spec.rb'
-    - 'spec/models/announcement_reaction_spec.rb'
-    - 'spec/models/announcement_spec.rb'
-    - 'spec/models/backup_spec.rb'
-    - 'spec/models/conversation_mute_spec.rb'
-    - 'spec/models/custom_filter_keyword_spec.rb'
-    - 'spec/models/custom_filter_spec.rb'
-    - 'spec/models/device_spec.rb'
-    - 'spec/models/encrypted_message_spec.rb'
-    - 'spec/models/featured_tag_spec.rb'
-    - 'spec/models/follow_recommendation_suppression_spec.rb'
-    - 'spec/models/list_account_spec.rb'
-    - 'spec/models/list_spec.rb'
-    - 'spec/models/login_activity_spec.rb'
-    - 'spec/models/mute_spec.rb'
-    - 'spec/models/preview_card_spec.rb'
-    - 'spec/models/preview_card_trend_spec.rb'
-    - 'spec/models/relay_spec.rb'
-    - 'spec/models/scheduled_status_spec.rb'
-    - 'spec/models/status_stat_spec.rb'
-    - 'spec/models/status_trend_spec.rb'
-    - 'spec/models/system_key_spec.rb'
-    - 'spec/models/tag_follow_spec.rb'
-    - 'spec/models/unavailable_domain_spec.rb'
-    - 'spec/models/user_invite_request_spec.rb'
-    - 'spec/models/web/setting_spec.rb'
-    - 'spec/services/unmute_service_spec.rb'
-
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 22
diff --git a/spec/helpers/admin/action_logs_helper_spec.rb b/spec/helpers/admin/action_logs_helper_spec.rb
deleted file mode 100644
index 4e9d08f09..000000000
--- a/spec/helpers/admin/action_logs_helper_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Admin::ActionLogsHelper do
-end
diff --git a/spec/models/account_alias_spec.rb b/spec/models/account_alias_spec.rb
deleted file mode 100644
index f0cd274ea..000000000
--- a/spec/models/account_alias_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe AccountAlias do
-end
diff --git a/spec/models/account_deletion_request_spec.rb b/spec/models/account_deletion_request_spec.rb
deleted file mode 100644
index 8bbfb695d..000000000
--- a/spec/models/account_deletion_request_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe AccountDeletionRequest do
-end
diff --git a/spec/models/account_moderation_note_spec.rb b/spec/models/account_moderation_note_spec.rb
deleted file mode 100644
index 9d683ca52..000000000
--- a/spec/models/account_moderation_note_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe AccountModerationNote do
-end
diff --git a/spec/models/announcement_mute_spec.rb b/spec/models/announcement_mute_spec.rb
deleted file mode 100644
index 1937da3aa..000000000
--- a/spec/models/announcement_mute_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe AnnouncementMute do
-end
diff --git a/spec/models/announcement_reaction_spec.rb b/spec/models/announcement_reaction_spec.rb
deleted file mode 100644
index 43cc0e148..000000000
--- a/spec/models/announcement_reaction_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe AnnouncementReaction do
-end
diff --git a/spec/models/announcement_spec.rb b/spec/models/announcement_spec.rb
deleted file mode 100644
index 32d398213..000000000
--- a/spec/models/announcement_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Announcement do
-end
diff --git a/spec/models/backup_spec.rb b/spec/models/backup_spec.rb
deleted file mode 100644
index 130311752..000000000
--- a/spec/models/backup_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Backup do
-end
diff --git a/spec/models/conversation_mute_spec.rb b/spec/models/conversation_mute_spec.rb
deleted file mode 100644
index 3d5504a65..000000000
--- a/spec/models/conversation_mute_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe ConversationMute do
-end
diff --git a/spec/models/custom_filter_keyword_spec.rb b/spec/models/custom_filter_keyword_spec.rb
deleted file mode 100644
index 09a36fa3e..000000000
--- a/spec/models/custom_filter_keyword_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe CustomFilterKeyword do
-end
diff --git a/spec/models/custom_filter_spec.rb b/spec/models/custom_filter_spec.rb
deleted file mode 100644
index f5e9b7ea9..000000000
--- a/spec/models/custom_filter_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe CustomFilter do
-end
diff --git a/spec/models/device_spec.rb b/spec/models/device_spec.rb
deleted file mode 100644
index 4e7b8f2e2..000000000
--- a/spec/models/device_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Device do
-end
diff --git a/spec/models/encrypted_message_spec.rb b/spec/models/encrypted_message_spec.rb
deleted file mode 100644
index c38142be1..000000000
--- a/spec/models/encrypted_message_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe EncryptedMessage do
-end
diff --git a/spec/models/featured_tag_spec.rb b/spec/models/featured_tag_spec.rb
deleted file mode 100644
index 58865f94a..000000000
--- a/spec/models/featured_tag_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe FeaturedTag do
-end
diff --git a/spec/models/follow_recommendation_suppression_spec.rb b/spec/models/follow_recommendation_suppression_spec.rb
deleted file mode 100644
index d437d170d..000000000
--- a/spec/models/follow_recommendation_suppression_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe FollowRecommendationSuppression do
-end
diff --git a/spec/models/list_account_spec.rb b/spec/models/list_account_spec.rb
deleted file mode 100644
index c9853d4a0..000000000
--- a/spec/models/list_account_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe ListAccount do
-end
diff --git a/spec/models/list_spec.rb b/spec/models/list_spec.rb
deleted file mode 100644
index 621ad3968..000000000
--- a/spec/models/list_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe List do
-end
diff --git a/spec/models/login_activity_spec.rb b/spec/models/login_activity_spec.rb
deleted file mode 100644
index 2214d3ef3..000000000
--- a/spec/models/login_activity_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe LoginActivity do
-end
diff --git a/spec/models/mute_spec.rb b/spec/models/mute_spec.rb
deleted file mode 100644
index 050083d0f..000000000
--- a/spec/models/mute_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Mute do
-end
diff --git a/spec/models/preview_card_spec.rb b/spec/models/preview_card_spec.rb
deleted file mode 100644
index 7d687d16f..000000000
--- a/spec/models/preview_card_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe PreviewCard do
-end
diff --git a/spec/models/preview_card_trend_spec.rb b/spec/models/preview_card_trend_spec.rb
deleted file mode 100644
index a31bf71cc..000000000
--- a/spec/models/preview_card_trend_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe PreviewCardTrend do
-end
diff --git a/spec/models/relay_spec.rb b/spec/models/relay_spec.rb
deleted file mode 100644
index 7ed49e733..000000000
--- a/spec/models/relay_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Relay do
-end
diff --git a/spec/models/scheduled_status_spec.rb b/spec/models/scheduled_status_spec.rb
deleted file mode 100644
index 286c17e69..000000000
--- a/spec/models/scheduled_status_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe ScheduledStatus do
-end
diff --git a/spec/models/status_stat_spec.rb b/spec/models/status_stat_spec.rb
deleted file mode 100644
index 9679c836a..000000000
--- a/spec/models/status_stat_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe StatusStat do
-end
diff --git a/spec/models/status_trend_spec.rb b/spec/models/status_trend_spec.rb
deleted file mode 100644
index dbb3d4bb3..000000000
--- a/spec/models/status_trend_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe StatusTrend do
-end
diff --git a/spec/models/system_key_spec.rb b/spec/models/system_key_spec.rb
deleted file mode 100644
index 5bd630aaa..000000000
--- a/spec/models/system_key_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe SystemKey do
-end
diff --git a/spec/models/tag_follow_spec.rb b/spec/models/tag_follow_spec.rb
deleted file mode 100644
index 240147ecc..000000000
--- a/spec/models/tag_follow_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe TagFollow do
-end
diff --git a/spec/models/unavailable_domain_spec.rb b/spec/models/unavailable_domain_spec.rb
deleted file mode 100644
index b868779f2..000000000
--- a/spec/models/unavailable_domain_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe UnavailableDomain do
-end
diff --git a/spec/models/user_invite_request_spec.rb b/spec/models/user_invite_request_spec.rb
deleted file mode 100644
index ee0efbb43..000000000
--- a/spec/models/user_invite_request_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe UserInviteRequest do
-end
diff --git a/spec/models/web/setting_spec.rb b/spec/models/web/setting_spec.rb
deleted file mode 100644
index 3182c6721..000000000
--- a/spec/models/web/setting_spec.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Web::Setting do
-end
diff --git a/spec/services/unmute_service_spec.rb b/spec/services/unmute_service_spec.rb
deleted file mode 100644
index 236f837e2..000000000
--- a/spec/services/unmute_service_spec.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe UnmuteService, type: :service do
-  subject { described_class.new }
-end