From b978e10bef4cf9df4bc21d0ba456aee7104c01ea Mon Sep 17 00:00:00 2001
From: fef <owo@fef.moe>
Date: Thu, 1 Dec 2022 02:24:08 +0000
Subject: [PATCH] change reaction api to match other interactions

Status reactions had an API similar to that of
announcement reactions, using PUT and DELETE at a
single endpoint.  I believe that for statuses, it
makes more sense to follow the convention of the
other interactions and use separate POST endpoints
for create and destroy respectively.
---
 app/controllers/api/v1/statuses/reactions_controller.rb | 2 +-
 app/javascript/flavours/glitch/actions/interactions.js  | 4 ++--
 app/javascript/mastodon/actions/interactions.js         | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/controllers/api/v1/statuses/reactions_controller.rb b/app/controllers/api/v1/statuses/reactions_controller.rb
index 9542d491c..333054f2a 100644
--- a/app/controllers/api/v1/statuses/reactions_controller.rb
+++ b/app/controllers/api/v1/statuses/reactions_controller.rb
@@ -7,7 +7,7 @@ class Api::V1::Statuses::ReactionsController < Api::BaseController
   before_action :require_user!
   before_action :set_status
 
-  def update
+  def create
     ReactService.new.call(current_account, @status, params[:id])
     render_empty
   end
diff --git a/app/javascript/flavours/glitch/actions/interactions.js b/app/javascript/flavours/glitch/actions/interactions.js
index 1607231a3..924dcfca7 100644
--- a/app/javascript/flavours/glitch/actions/interactions.js
+++ b/app/javascript/flavours/glitch/actions/interactions.js
@@ -417,7 +417,7 @@ export const addReaction = (statusId, name) => (dispatch, getState) => {
     dispatch(addReactionRequest(statusId, name, alreadyAdded));
   }
 
-  api(getState).put(`/api/v1/statuses/${statusId}/reactions/${name}`).then(() => {
+  api(getState).post(`/api/v1/statuses/${statusId}/react/${name}`).then(() => {
     dispatch(addReactionSuccess(statusId, name, alreadyAdded));
   }).catch(err => {
     if (!alreadyAdded) {
@@ -451,7 +451,7 @@ export const addReactionFail = (statusId, name, error) => ({
 export const removeReaction = (statusId, name) => (dispatch, getState) => {
   dispatch(removeReactionRequest(statusId, name));
 
-  api(getState).delete(`/api/v1/statuses/${statusId}/reactions/${name}`).then(() => {
+  api(getState).post(`/api/v1/statuses/${statusId}/unreact/${name}`).then(() => {
     dispatch(removeReactionSuccess(statusId, name));
   }).catch(err => {
     dispatch(removeReactionFail(statusId, name, err));
diff --git a/app/javascript/mastodon/actions/interactions.js b/app/javascript/mastodon/actions/interactions.js
index 900ac2cd7..f01841fe6 100644
--- a/app/javascript/mastodon/actions/interactions.js
+++ b/app/javascript/mastodon/actions/interactions.js
@@ -437,7 +437,7 @@ export const addReaction = (statusId, name) => (dispatch, getState) => {
     dispatch(addReactionRequest(statusId, name, alreadyAdded));
   }
 
-  api(getState).put(`/api/v1/statuses/${statusId}/reactions/${name}`).then(() => {
+  api(getState).post(`/api/v1/statuses/${statusId}/react/${name}`).then(() => {
     dispatch(addReactionSuccess(statusId, name, alreadyAdded));
   }).catch(err => {
     if (!alreadyAdded) {
@@ -471,7 +471,7 @@ export const addReactionFail = (statusId, name, error) => ({
 export const removeReaction = (statusId, name) => (dispatch, getState) => {
   dispatch(removeReactionRequest(statusId, name));
 
-  api(getState).delete(`/api/v1/statuses/${statusId}/reactions/${name}`).then(() => {
+  api(getState).post(`/api/v1/statuses/${statusId}/unreact/${name}`).then(() => {
     dispatch(removeReactionSuccess(statusId, name));
   }).catch(err => {
     dispatch(removeReactionFail(statusId, name, err));