This repository has been archived on 2024-07-22. You can view files and clone it, but cannot push or open issues or pull requests.
mastodon/spec/fabricators
Claire 02851848e9
Revamp post filtering system (#18058)
* Add model for custom filter keywords

* Use CustomFilterKeyword internally

Does not change the API

* Fix /filters/edit and /filters/new

* Add migration tests

* Remove whole_word column from custom_filters (covered by custom_filter_keywords)

* Redesign /filters

Instead of a list, present a card that displays more information and handles
multiple keywords per filter.

* Redesign /filters/new and /filters/edit to add and remove keywords

This adds a new gem dependency: cocoon, as well as a npm dependency:
cocoon-js-vanilla. Those are used to easily populate and remove form fields
from the user interface when manipulating multiple keyword filters at once.

* Add /api/v2/filters to edit filter with multiple keywords

Entities:
- `Filter`: `id`, `title`, `filter_action` (either `hide` or `warn`), `context`
  `keywords`
- `FilterKeyword`: `id`, `keyword`, `whole_word`

API endpoits:
- `GET /api/v2/filters` to list filters (including keywords)
- `POST /api/v2/filters` to create a new filter
  `keywords_attributes` can also be passed to create keywords in one request
- `GET /api/v2/filters/:id` to read a particular filter
- `PUT /api/v2/filters/:id` to update a new filter
  `keywords_attributes` can also be passed to edit, delete or add keywords in
   one request
- `DELETE /api/v2/filters/:id` to delete a particular filter
- `GET /api/v2/filters/:id/keywords` to list keywords for a filter
- `POST /api/v2/filters/:filter_id/keywords/:id` to add a new keyword to a
   filter
- `GET /api/v2/filter_keywords/:id` to read a particular keyword
- `PUT /api/v2/filter_keywords/:id` to edit a particular keyword
- `DELETE /api/v2/filter_keywords/:id` to delete a particular keyword

* Change from `irreversible` boolean to `action` enum

* Remove irrelevent `irreversible_must_be_within_context` check

* Fix /filters/new and /filters/edit with update for filter_action

* Fix Rubocop/Codeclimate complaining about task names

* Refactor FeedManager#phrase_filtered?

This moves regexp building and filter caching to the `CustomFilter` class.

This does not change the functional behavior yet, but this changes how the
cache is built, doing per-custom_filter regexps so that filters can be matched
independently, while still offering caching.

* Perform server-side filtering and output result in REST API

* Fix numerous filters_changed events being sent when editing multiple keywords at once

* Add some tests

* Use the new API in the WebUI

- use client-side logic for filters we have fetched rules for.
  This is so that filter changes can be retroactively applied without
  reloading the UI.
- use server-side logic for filters we haven't fetched rules for yet
  (e.g. network error, or initial timeline loading)

* Minor optimizations and refactoring

* Perform server-side filtering on the streaming server

* Change the wording of filter action labels

* Fix issues pointed out by linter

* Change design of “Show anyway” link in accordence to review comments

* Drop “irreversible” filtering behavior

* Move /api/v2/filter_keywords to /api/v1/filters/keywords

* Rename `filter_results` attribute to `filtered`

* Rename REST::LegacyFilterSerializer to REST::V1::FilterSerializer

* Fix systemChannelId value in streaming server

* Simplify code by removing client-side filtering code

The simplifcation comes at a cost though: filters aren't retroactively
applied anymore.
2022-06-28 09:42:13 +02:00
..
assets Improvements to image upload validation and creation (#10431) 2019-04-01 07:30:46 +02:00
access_token_fabricator.rb
accessible_access_token_fabricator.rb
account_alias_fabricator.rb Add account migration UI (#11846) 2019-09-19 20:58:19 +02:00
account_deletion_request_fabricator.rb Change account suspensions to be reversible by default (#14726) 2020-09-15 14:37:58 +02:00
account_domain_block_fabricator.rb
account_fabricator.rb Refactor and improve tests (#17386) 2022-01-28 00:46:42 +01:00
account_migration_fabricator.rb Change move handler to carry blocks over (#14144) 2020-07-01 13:51:15 +02:00
account_moderation_note_fabricator.rb
account_note_fabricator.rb Add user notes on accounts (#14148) 2020-06-30 19:19:50 +02:00
account_pin_fabricator.rb
account_stat_fabricator.rb
account_statuses_cleanup_policy_fabricator.rb Add feature to automatically delete old toots (#16529) 2021-08-09 23:11:50 +02:00
account_tag_stat_fabricator.rb
account_warning_fabricator.rb Add appeals (#17364) 2022-02-14 21:27:53 +01:00
account_warning_preset_fabricator.rb
admin_action_log_fabricator.rb
announcement_fabricator.rb Add announcements (#12662) 2020-01-23 22:00:13 +01:00
announcement_mute_fabricator.rb Add announcements (#12662) 2020-01-23 22:00:13 +01:00
announcement_reaction_fabricator.rb Add announcements (#12662) 2020-01-23 22:00:13 +01:00
appeal_fabricator.rb Add appeals (#17364) 2022-02-14 21:27:53 +01:00
application_fabricator.rb
backup_fabricator.rb
block_fabricator.rb
bookmark_fabricator.rb Add bookmarks (#7107) 2019-11-13 23:02:10 +01:00
canonical_email_block_fabricator.rb Add canonical e-mail blocks for suspended accounts (#16049) 2021-04-17 03:14:25 +02:00
conversation_account_fabricator.rb
conversation_fabricator.rb
conversation_mute_fabricator.rb
custom_emoji_category_fabricator.rb Add categories for custom emojis (#11196) 2019-06-28 15:54:10 +02:00
custom_emoji_fabricator.rb
custom_filter_fabricator.rb
custom_filter_keyword_fabricator.rb Revamp post filtering system (#18058) 2022-06-28 09:42:13 +02:00
device_fabricator.rb Add E2EE API (#13820) 2020-06-02 19:24:53 +02:00
domain_allow_fabricator.rb Add whitelist mode (#11291) 2019-07-30 11:10:46 +02:00
domain_block_fabricator.rb
email_domain_block_fabricator.rb
encrypted_message_fabricator.rb Add E2EE API (#13820) 2020-06-02 19:24:53 +02:00
favourite_fabricator.rb
featured_tag_fabricator.rb
follow_fabricator.rb
follow_recommendation_suppression_fabricator.rb Add cold-start follow recommendations (#15945) 2021-04-12 12:37:14 +02:00
follow_request_fabricator.rb
identity_fabricator.rb
import_fabricator.rb
invite_fabricator.rb
ip_block_fabricator.rb Add IP-based rules (#14963) 2020-10-12 16:33:49 +02:00
list_account_fabricator.rb
list_fabricator.rb
login_activity_fabricator.rb Fix suspicious sign-in mails never being sent (#18599) 2022-06-21 15:16:22 +02:00
marker_fabricator.rb Add timeline read markers API (#11762) 2019-09-06 13:55:51 +02:00
media_attachment_fabricator.rb Fix media attachments without file being uploadable (#12562) 2020-01-23 21:40:03 +01:00
mention_fabricator.rb
mute_fabricator.rb
notification_fabricator.rb
one_time_key_fabricator.rb Add E2EE API (#13820) 2020-06-02 19:24:53 +02:00
poll_fabricator.rb
poll_vote_fabricator.rb
preview_card_fabricator.rb Add support for editing for published statuses (#16697) 2022-01-19 22:37:27 +01:00
relay_fabricator.rb
report_fabricator.rb Add notifications for statuses deleted by moderators (#17204) 2022-01-17 09:41:33 +01:00
report_note_fabricator.rb
rule_fabricator.rb Fix report category not being saved in REST API (#17682) 2022-03-02 18:57:08 +01:00
scheduled_status_fabricator.rb
session_activation_fabricator.rb
setting_fabricator.rb
site_upload_fabricator.rb Improvements to image upload validation and creation (#10431) 2019-04-01 07:30:46 +02:00
status_edit_fabricator.rb Add support for editing for published statuses (#16697) 2022-01-19 22:37:27 +01:00
status_fabricator.rb
status_pin_fabricator.rb Add more tests for ActivityPub controllers (#13585) 2020-05-03 16:30:36 +02:00
status_stat_fabricator.rb
system_key_fabricator.rb Add E2EE API (#13820) 2020-06-02 19:24:53 +02:00
tag_fabricator.rb
unavailable_domain_fabricator.rb Change delivery failure tracking to work with hostnames instead of URLs (#13437) 2020-04-15 20:33:24 +02:00
user_fabricator.rb Refactor and improve tests (#17386) 2022-01-28 00:46:42 +01:00
user_invite_request_fabricator.rb Add "why do you want to join" field to invite requests (#10524) 2019-04-09 23:06:30 +09:00
web_push_subscription_fabricator.rb
web_setting_fabricator.rb
webauthn_credential_fabricator.rb Add WebAuthn as an alternative 2FA method (#14466) 2020-08-24 16:46:27 +02:00
webhook_fabricator.rb Add administrative webhooks (#18510) 2022-06-09 21:57:36 +02:00