This repository has been archived on 2024-07-22. You can view files and clone it, but cannot push or open issues or pull requests.

Eugen Rochko 21ad21cb50 Improve signature verification safeguards (#8959) ... * Downcase signed_headers string before building the signed string The HTTP Signatures draft does not mandate the “headers” field to be downcased, but mandates the header field names to be downcased in the signed string, which means that prior to this patch, Mastodon could fail to process signatures from some compliant clients. It also means that it would not actually check the Digest of non-compliant clients that wouldn't use a lowercased Digest field name. Thankfully, I don't know of any such client. * Revert "Remove dead code (#8919)" This reverts commit a00ce8c92c. * Restore time window checking, change it to 12 hours By checking the Date header, we can prevent replaying old vulnerable signatures. The focus is to prevent replaying old vulnerable requests from software that has been fixed in the meantime, so a somewhat long window should be fine and accounts for timezone misconfiguration. * Escape users' URLs when formatting them Fixes possible HTML injection * Escape all string interpolations in Formatter class Slightly improve performance by reducing class allocations from repeated Formatter#encode calls * Fix code style issues		2018-10-12 00:15:55 +02:00
..
account_controller_concern_spec.rb	Use raw status code on have_http_status (#7214)	2018-04-21 21:35:07 +02:00
export_controller_concern_spec.rb	lint pass 2 (#8878)	2018-10-04 17:38:04 +02:00
localized_spec.rb	Misc. typos (#8694)	2018-09-14 00:53:09 +02:00
obfuscate_filename_spec.rb	…
rate_limit_headers_spec.rb	Rate limit by user instead of IP when API user is authenticated (#5923)	2017-12-09 14:20:02 +01:00
signature_verification_spec.rb	Improve signature verification safeguards (#8959)	2018-10-12 00:15:55 +02:00
user_tracking_concern_spec.rb	Fix regeneration marker not expiring (#6290)	2018-01-18 20:29:56 +01:00