This repository has been archived on 2024-07-22. You can view files and clone it, but cannot push or open issues or pull requests.
mastodon/app
Akihiko Odaki 64ef37b89d
Introduce ApplicationController#cache_collection_paginated_by_id (#14677)
* Replace incorrect use of distinct with group

Some uses of ActiveRecord::QueryMethods#distinct pass field names but they
are incorrect for the current version of Rails.

ActiveRecord::QueryMethods#group provides the expected behavior and
benefits performance. See commit 6da24aad4cafdef8d8a2c92bac2002a5fc2fe9c8.

* Introduce ApplicationController#cache_collection_paginated_by_id

ApplicationController#cache_collection_paginated_by_id fuses
ApplicationController#cache_collection and Paginable.paginate_by_id.

An advantage of this method is that it prevents from modifying scope which
Paginable.paginate_by_id may provide.
ApplicationController#cache_collection always return an array and there
is no possibility of the scope modification. It is also clear for a
programmer, considering the implication of "cache".

This method can also emit more efficient queries by using
Cacheable.cache_ids before calling Paginable.paginate_by_id.
2020-08-28 12:31:56 +02:00
..
chewy Change `tootctl search deploy` algorithm (#14300) 2020-07-14 18:10:35 +02:00
controllers Introduce ApplicationController#cache_collection_paginated_by_id (#14677) 2020-08-28 12:31:56 +02:00
helpers Add a visibility icon to status (#14123) 2020-06-25 22:43:59 +02:00
javascript Add WebAuthn as an alternative 2FA method (#14466) 2020-08-24 16:46:27 +02:00
lib Fix dereferencing remote statuses not using the correct account (#14656) 2020-08-24 16:56:21 +02:00
mailers Add WebAuthn as an alternative 2FA method (#14466) 2020-08-24 16:46:27 +02:00
models Add WebAuthn as an alternative 2FA method (#14466) 2020-08-24 16:46:27 +02:00
policies Add ability to delete files uploaded for settings in admin UI (#13192) 2020-03-08 16:00:24 +01:00
presenters Add user notes on accounts (#14148) 2020-06-30 19:19:50 +02:00
serializers Add thumbnail_remote_url in MediaAttachment REST response (#14358) 2020-07-19 19:53:31 +02:00
services Use Status.group instead of Status.distinct in HashQueryService (#14662) 2020-08-25 13:39:35 +02:00
validators Improve email address validation (#14565) 2020-08-12 12:40:25 +02:00
views Add WebAuthn as an alternative 2FA method (#14466) 2020-08-24 16:46:27 +02:00
workers Changed retries and rescued in ActivityPub::ProcessingWorker (#14355) 2020-07-20 11:26:12 +02:00