Commit Graph

2770 Commits

Author SHA1 Message Date
Andreas Nedbal d520755bc2 Remove service model 2023-02-05 21:54:51 +01:00
Andreas Nedbal c327eee38e Remove services controller 2023-02-05 21:54:51 +01:00
Andreas Nedbal a2e45c85bf Add migration to enable sharing for legacy service owners 2023-02-05 21:54:51 +01:00
Georg Gadinger f1a545aea5 use remote_ip 2023-02-04 22:31:53 +01:00
Karina Kwiatek c40a1a4997
Merge pull request #1040 from Retrospring/fix/n+1-notification-type-counters
Prevent 𝑛+1 for notification type counters
2023-02-02 12:09:06 +01:00
Karina Kwiatek 05a90987cd
Merge pull request #1037 from Retrospring/fix/pre-load-mutes
Pre-load own mute relationships in follow lists
2023-02-02 12:07:58 +01:00
Karina Kwiatek 40f7f8f525 Eager load notification targets 2023-02-02 11:03:27 +01:00
Karina Kwiatek 80e312eb3b Appease the dog overlords 2023-02-02 10:38:41 +01:00
Karina Kwiatek 81a6c6ac55 Prevent 𝑛+1 for notification type counters 2023-02-02 00:55:31 +01:00
Andreas Nedbal 7d91c0349a Eagerly load services in action to prevent n+1 query 2023-02-02 00:44:42 +01:00
Karina Kwiatek 825454bbae Fix incorrect type local in followers endpoint 2023-02-01 23:34:33 +01:00
Karina Kwiatek 603e9c501e Pre-load own mute relationships in follow lists 2023-02-01 23:21:09 +01:00
Karina Kwiatek d08198668b Pass user services for question generate turbo frame 2023-01-31 23:10:51 +01:00
Karina Kwiatek 279ed82d6a
Merge pull request #1029 from Retrospring/fix/relationship-list-n+1
Prevent 𝑛+1 on follower/following lists
2023-01-31 22:15:32 +01:00
Karina Kwiatek 226cd10fbc Appease the dog overlords 2023-01-31 14:01:21 +01:00
Karina Kwiatek 8520dbc4b9 De-duplicate relationship pagination logic 2023-01-31 13:59:05 +01:00
Karina Kwiatek 83eeabb525 Use locals for own relationships 2023-01-31 13:46:09 +01:00
Karina Kwiatek 2517b1330a
Merge pull request #1017 from Retrospring/feature/raised-texts
Add new raised text and raised accent text theme fields
2023-01-31 12:57:15 +01:00
Karina Kwiatek 51e15ef195 Appease the dog overlords 2023-01-31 12:30:58 +01:00
Karina Kwiatek 1b6eafd2d1 Prevent 𝑛+1 on follower/following lists 2023-01-31 12:25:55 +01:00
Andreas Nedbal 87aac34f16 Move raised content theming section below general 2023-01-31 08:28:08 +01:00
Georg Gadinger 8b7ba59660 typoed_email_validator: add new endings to the typo list 2023-01-30 06:01:01 +01:00
Karina Kwiatek 4dc5a65f74
Merge pull request #1014 from Retrospring/fix/inbox-services-query
Move fetching of services to controller to avoid n+1 queries
2023-01-29 23:07:46 +01:00
Andreas Nedbal 63b16fd39a Appease the dog overlords 2023-01-29 21:13:38 +01:00
Andreas Nedbal 61a31f97b0 Move theme attributes into their own method 2023-01-29 21:12:33 +01:00
Andreas Nedbal 520d77bb44 Let relevant style overrides use the new raised text colors 2023-01-29 20:44:40 +01:00
Andreas Nedbal ab6e8270df Allow new fields in ThemeController 2023-01-29 20:44:09 +01:00
Andreas Nedbal 6b3342036f Merge branch 'main' into feature/raised-texts 2023-01-29 19:38:32 +01:00
Georg Gadinger a59bc3ef92 typoed_email_validator: add new endings to the typo list 2023-01-29 19:19:35 +01:00
Karina Kwiatek 7c1057acb3
Merge pull request #1012 from Retrospring/bugfix/author-deletes
Fix author-searched deletion in inbox not working
2023-01-29 09:01:24 +01:00
Karina Kwiatek 96659befea
Appease the dog overlords
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
2023-01-29 00:46:52 +01:00
Karina Kwiatek 19dfc70e2d
Merge pull request #1011 from Retrospring/refactor/cleanup-user-controller
Cleanup user controller
2023-01-28 22:53:48 +01:00
Karina Kwiatek 87894d1e95 Move empty filter check back into show action 2023-01-28 22:42:14 +01:00
Karina Kwiatek 367e2f4b92 Use a local instead of an ivar for passing services into views 2023-01-28 22:24:05 +01:00
Karina Kwiatek 3e2b65d7b8 Move fetching of services to controller to avoid n+1 queries 2023-01-28 21:42:55 +01:00
Karina Kwiatek ab1b034cfb Add type hints for paginators 2023-01-28 21:18:01 +01:00
Karina Kwiatek 32ba17ac72 Eager load profiles in paginators 2023-01-28 21:18:00 +01:00
Andreas Nedbal 6c25594b88 Get the username of the currently searched author correctly 2023-01-28 19:18:02 +01:00
Andreas Nedbal 8dd49d3a8c Remove author search handler 2023-01-28 19:17:04 +01:00
Karina Kwiatek ff866f88ef Appease the dog overlords 2023-01-28 19:09:03 +01:00
Karina Kwiatek e9c397a013 Replace `@title` and `@type` ivars 2023-01-28 19:08:28 +01:00
Karina Kwiatek 6e3bc40c57 Move marking follow notifications as read to an after action 2023-01-28 18:48:14 +01:00
Karina Kwiatek 1c74061c1b
Merge pull request #1004 from Retrospring/cache-headers-on-manifest
Cache headers for web app manifest based on user theme
2023-01-28 11:13:08 +01:00
Karina Kwiatek 999f599029
Merge pull request #1005 from Retrospring/skip-announcements-in-ajax 2023-01-27 23:53:20 +01:00
Karina Kwiatek a34a30349e Use `skip_before_action` instead of redefining action in `AjaxController` 2023-01-27 23:16:41 +01:00
Karina Kwiatek b8b86b069d Cache headers for web app manifest based on user theme 2023-01-27 23:09:09 +01:00
Georg Gadinger 3e3501d201 inbox: update inbox entries in controller 2023-01-27 20:36:22 +01:00
Karina Kwiatek 2ecfe38e5e
Merge pull request #984 from Retrospring/feature/stimulus-cropper
Refactor image cropping into Stimulus controller
2023-01-27 17:22:58 +01:00
Georg Gadinger 8cd0d481c8 bruh 2023-01-24 15:57:34 +01:00
Georg Gadinger 58705fffba mark notifications as "read" in the controller and when you see them
this makes it behave a bit more like the inbox
2023-01-24 15:54:41 +01:00
Andreas Nedbal a0a7f4e124 Add raised-text and raised-accent-text theme variables 2023-01-23 23:36:38 +01:00
Georg Gadinger b99e1b03de notifications: only update all new notifications 2023-01-23 12:25:48 +01:00
Karina Kwiatek 6b771887ab Fix unprivileged comment actions being visible
- Fixes an error when viewing answers containing comments while not logged in
- Hides the report option while not logged in
2023-01-23 09:04:55 +01:00
Andreas Nedbal fe156a38d3 Appease the dog overlords 2023-01-22 17:58:23 +01:00
Andreas Nedbal f0df18ce87 Remove unused IDs on profile crop elements 2023-01-22 17:48:53 +01:00
Andreas Nedbal 6a361e69db Wire up cropper controller in profile settings 2023-01-22 17:44:08 +01:00
Andreas Nedbal 96ed2c864c Add Stimulus cropper controller 2023-01-22 17:43:40 +01:00
Andreas Nedbal 3b1f9bf4cb Remove legacy cropping feature 2023-01-22 17:43:20 +01:00
Karina Kwiatek 529bf40dbe
Merge pull request #979 from Retrospring/fix/pwa-issues
Fix various PWA issues
2023-01-22 12:47:12 +01:00
Andreas Nedbal e18b9518aa Properly align the hashes 2023-01-22 11:14:24 +01:00
Andreas Nedbal c7cc0da04b Appease the dog overlords 2023-01-22 10:57:05 +01:00
Andreas Nedbal c122652275 Increase allowed comment length to 512 characters 2023-01-22 10:36:23 +01:00
Georg Gadinger eb7abb33be user: only provide #questions as GET 2023-01-22 00:04:33 +01:00
Georg Gadinger 14f32aa3c0 question: only provide #show as GET 2023-01-22 00:04:33 +01:00
Georg Gadinger b019f24aaa user: only provide #followers and #followings as GET 2023-01-22 00:04:33 +01:00
Georg Gadinger 989873ba62 user: only provide #show as GET 2023-01-22 00:04:33 +01:00
Georg Gadinger d572734b96 notifications: only provide #index as GET 2023-01-22 00:04:33 +01:00
Georg Gadinger 77529c2217 moderation/reports: only provide #index as GET 2023-01-22 00:04:33 +01:00
Georg Gadinger 144db471d6 moderation/inbox: only provide #index as GET 2023-01-22 00:04:33 +01:00
Georg Gadinger 59d94d7ba0 timeline: only provide #index, #public and #list as GET 2023-01-22 00:04:33 +01:00
Karina Kwiatek 9e25a36196 Fix 'Buffer is not defined' on push enable 2023-01-22 00:04:10 +01:00
Karina Kwiatek e16f460b53 Add option to view comments in rails admin 2023-01-22 00:03:53 +01:00
Karina Kwiatek 95984cfdab Correct app description in web app manifest 2023-01-21 18:26:08 +01:00
Karina Kwiatek d2076c35b5 Remove `?source=pwa`
We can use `@media (display-mode: standalone)` to detect this instead
2023-01-21 18:23:40 +01:00
Karina Kwiatek 3f41d339de Add icons at 144x144
For some reason Chromium requires an icon at this size, however the error in Lighthouse states that the size must be *at least* 144x144 but in fact must be exactly this size.
2023-01-21 18:18:14 +01:00
Karina Kwiatek b9269f0693 Add maskable icons 2023-01-21 18:16:24 +01:00
Karina Kwiatek 73082975c4 Fix web app icon sizes property name 2023-01-21 18:15:18 +01:00
Georg Gadinger 9d7c99fe9b
Merge pull request #974 from Retrospring/refactor/inbox
refactor inbox
2023-01-21 13:59:39 +01:00
Andreas Nedbal df3d4d71bb Appease the dog overlords 2023-01-21 13:44:53 +01:00
Andreas Nedbal de3e04812d Merge branch 'main' into feature/theme-stimulus 2023-01-21 13:40:58 +01:00
Andreas Nedbal fc30bf8cac Add more explicit message for format validation errors 2023-01-21 13:20:52 +01:00
Andreas Nedbal 47bccdb0c3 Fix screen_name regex being too lenient 2023-01-21 13:20:52 +01:00
Andreas Nedbal b72e679a62 Split format and length validation for User `screen_name` 2023-01-21 13:20:52 +01:00
Andreas Nedbal 18f428eddf Remove dropup notification menu from mobile 2023-01-21 12:53:49 +01:00
Karina Kwiatek 27318f302c Rename current icons to icon_ 2023-01-21 12:30:52 +01:00
Andreas Nedbal e7842fab86 Add missing form-label class to example input 2023-01-21 09:42:23 +01:00
Andreas Nedbal 07ea833d13 Add Stimulus capabilities controller 2023-01-21 04:53:20 +01:00
Andreas Nedbal e81e85cf9a Remove capabilities feature 2023-01-21 04:53:20 +01:00
Andreas Nedbal d4c2ca5e5e Don't set the collapse controller for entries that aren't long 2023-01-21 04:43:48 +01:00
Andreas Nedbal eae99cd9a5 Add collapse to profile questions 2023-01-21 04:43:48 +01:00
Georg Gadinger be55dee7db inbox: remove haml lints 2023-01-19 16:25:56 +01:00
Georg Gadinger c4724b8c62 inbox: refactor a bit further so the cyber dog shuts up 2023-01-19 16:21:21 +01:00
Georg Gadinger e5d8506a13 inbox: redirect away if there's no questions filtered by author 2023-01-19 11:57:56 +01:00
Georg Gadinger 30dec68e1b inbox: refactor show method, fix #959 2023-01-19 11:57:56 +01:00
Georg Gadinger 31ed9ba738 inbox: use underscored symbols instead of kebab strings 2023-01-19 11:57:55 +01:00
Georg Gadinger 2f82e3be31 inbox: only provide #show as GET 2023-01-19 11:57:55 +01:00
Andreas Nedbal 5f46c84850 remove console.log 2023-01-18 20:52:28 +01:00
Andreas Nedbal f5c4ed6954 Wire up theme controller and actions in view 2023-01-17 07:39:31 +01:00
Andreas Nedbal 5f529b2b26 Add Stimulus theme controller 2023-01-17 07:39:14 +01:00
Andreas Nedbal ab8d608458 Extract theme-related utilities 2023-01-17 07:38:32 +01:00
Andreas Nedbal 79fa204897 Remove theming handler features 2023-01-17 07:38:02 +01:00
Karina Kwiatek 596c1c5240 Remove underline on smiles list 2023-01-15 12:40:48 +01:00
Andreas Nedbal 61d77bf20e Fix announcements not closing when button is pressed 2023-01-13 19:00:23 +01:00
Andreas Nedbal 87630c87a6 Fix layout of announcements after Bootstrap 5 update 2023-01-13 19:00:23 +01:00
Karina Kwiatek 3dbbed3ef2 Shorten question text in notifications to short question length 2023-01-13 17:30:37 +01:00
Andreas Nedbal 8b4909ab80 use height limiting instead of legacy line-clamp 2023-01-13 15:58:07 +01:00
Andreas Nedbal 0d41da54b8 Fix layout for inbox entries as well 2023-01-12 23:21:08 +01:00
Andreas Nedbal f0b9a00923 Fix alignment of collapsibles in question headers
Co-Authored-By: Georg Gadinger <nilsding@nilsding.org>
2023-01-12 23:17:09 +01:00
Andreas Nedbal a2139213c7 Hide collapse from screenreaders
Co-Authored-By: Georg Gadinger <nilsding@nilsding.org>
2023-01-12 21:03:44 +01:00
Andreas Nedbal a8fb9fd701 Refactor render_theme method
Co-Authored-By: Georg Gadinger <nilsding@nilsding.org>
2023-01-12 21:03:44 +01:00
Andreas Nedbal e85f9d6867 Re-add support for detail page `display_all` condition 2023-01-12 21:03:44 +01:00
Andreas Nedbal 07a13d39da Add support for theme helper mapping specifying multiple target values 2023-01-12 21:03:44 +01:00
Andreas Nedbal 430cfa1a38 Add RGB variables for some theme colors 2023-01-12 21:03:44 +01:00
Andreas Nedbal a3b902b747 Add collapse to answerboxes and questions 2023-01-12 21:03:44 +01:00
Andreas Nedbal 46830f50cd Add Stimulus controller for collapse functionality 2023-01-12 21:03:44 +01:00
Andreas Nedbal 3258ea4f0b Implement shared collapse partial 2023-01-12 21:03:44 +01:00
Andreas Nedbal e8657891a9 Add wrapper -body classes to answerbox sections 2023-01-12 21:03:44 +01:00
Andreas Nedbal b66c2b1f36 add `long?` method and constant to Answer model 2023-01-12 21:03:44 +01:00
Karina Kwiatek c919b4913f
Merge branch 'main' into feature/long-questions 2023-01-11 22:24:58 +01:00
Andreas Nedbal c93255338e Add dev indicator to guest navbar 2023-01-11 22:24:16 +01:00
Andreas Nedbal 9150d09960 Apply review suggestion from @nilsding
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
2023-01-11 22:24:16 +01:00
Andreas Nedbal 710192e8fa Add "DEV" badge to navigation brand 2023-01-11 22:24:16 +01:00
Andreas Nedbal 8e915e1c0a Add dev env indicator to navigation 2023-01-11 22:24:16 +01:00
Andreas Nedbal 7970838659 Remove superfluous focus styling 2023-01-10 20:54:13 +01:00
Andreas Nedbal 6fa26340ef Add bigger shadow to popover 2023-01-10 20:53:55 +01:00
Andreas Nedbal 53bc270e08
Apply review suggestions from @nilsding
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
2023-01-10 20:49:37 +01:00
Andreas Nedbal 122935e723 only show formatting help on focus/hover in inbox entries 2023-01-10 16:05:50 +01:00
Andreas Nedbal cb7f9179e3 Add format help to inbox entries 2023-01-10 15:51:43 +01:00
Andreas Nedbal 30933e6ca1 Add Stimulus controller to launch format popup 2023-01-10 15:49:52 +01:00
Andreas Nedbal eccb51eab0 Add formatting help markup/translations 2023-01-10 15:48:56 +01:00
Karina Kwiatek 4e78efcae7 Add tests for sending long questions with question worker 2023-01-08 19:22:00 +01:00
Karina Kwiatek cfba963b55 Only reset character counters when they are present
Co-authored-by: Andreas Nedbal <git@pixelde.su>
2023-01-08 18:51:43 +01:00
Karina Kwiatek 7cdb0e4976 Respect long question setting in frontend 2023-01-08 17:12:46 +01:00
Karina Kwiatek 3a6814b908 Respect allow long questions setting 2023-01-08 14:03:54 +01:00
Karina Kwiatek ba7b19faee Add allow long questions option to profile settings 2023-01-08 13:14:21 +01:00
Karina Kwiatek 122be928bf
Merge pull request #934 from Retrospring/more-obvious-sharing-options
Make sharing options more obvious
2023-01-08 11:24:50 +00:00
Andreas Nedbal f6d7d6ae2d Fix initializers 2023-01-08 12:19:45 +01:00
Andreas Nedbal ce067a2d57 Move entrypoint to app/javascript/ 2023-01-08 12:19:45 +01:00
Andreas Nedbal 20e01d3a3f Install and setup jsbundling-rails with esbuild 2023-01-08 12:19:45 +01:00
Karina Kwiatek b65242d81e
Merge pull request #930 from Retrospring/fix/push-enable-when-subbed
Prevent push enable prompt (inbox) when already subscribed
2023-01-08 11:14:33 +00:00
Karina Kwiatek 4ac3483f1a Make sharing options more obvious 2023-01-06 17:38:27 +01:00
Georg Gadinger 04f1793058
Merge pull request #932 from Retrospring/om@nom.nom
typoed_email_validator: add new endings to the typo list
2023-01-06 14:55:25 +00:00
Georg Gadinger b6121b16f0
Merge pull request #929 from Retrospring/locale-gen
re-enable locale switching, add rake task to generate testing locales
2023-01-06 12:47:49 +00:00
Georg Gadinger 5b8e34aa1d add integration specs for changing locales 2023-01-06 13:37:22 +01:00
Georg Gadinger b81bbc2483 typoed_email_validator: add new endings to the typo list 2023-01-06 10:26:32 +01:00
Georg Gadinger ebcf9d7676 obey the dog 2023-01-06 10:04:31 +01:00
Karina Kwiatek 4457f2ed26 Prevent push enable prompt (inbox) when already subscribed 2023-01-05 23:20:36 +01:00
Georg Gadinger 8323f39ecd re-add locale switching logic
based on https://guides.rubyonrails.org/i18n.html\#managing-the-locale-across-requests
2023-01-05 15:20:33 +01:00
Karina Kwiatek 5db058cb73 Fix nav badge pills not being marked as HTML safe 2023-01-05 14:32:04 +01:00
Andreas Nedbal 01ab84aa31 Improve layout of inbox push info card 2023-01-05 12:32:50 +01:00