Commit Graph

2495 Commits

Author SHA1 Message Date
Andreas Nedbal 34b9f0bc61 Add tests for `ApplicationHelper` 2022-01-16 14:17:29 +01:00
Andreas Nedbal 0878561e50 Rename .houndci.yml to .hound.yml
Because of course the config is not respected when you use the wrong name
2022-01-16 14:17:29 +01:00
Andreas Nedbal 914b56369b Adjust ApplicationHelper tests 2022-01-16 14:17:29 +01:00
Andreas Nedbal a438e414c9 Fix code style in ApplicationHelper 2022-01-16 14:17:29 +01:00
Andreas Nedbal bdaf2f7fef Include cop settings from `rt_rubocop_defaults` and remove Gem
Hound can't require external configurations and so we have to resort to this.
2022-01-15 23:48:43 +01:00
Andreas Nedbal 71353b3721 Fix order of (new) gems in Gemfile 2022-01-15 23:48:43 +01:00
Andreas Nedbal 2f52a9c325 Remove HAML linting action step
Hound also does this
2022-01-15 23:48:43 +01:00
Andreas Nedbal dbc01f0264 Add HoundCI configuration 2022-01-15 23:48:43 +01:00
Andreas Nedbal 9c8854f633 Downgrade rubocop version to work with Hound 2022-01-15 23:48:43 +01:00
Andreas Nedbal 3c7b77b980 Apply review suggestion from @nilsding
Co-authored-by: Karina Kwiatek <6197148+raccube@users.noreply.github.com>
2022-01-15 23:48:43 +01:00
Andreas Nedbal d1b4c5f6c9 Set some stricter Rubocop rules 2022-01-15 23:48:43 +01:00
Karina Kwiatek 04177cc135 Use `button_to` instead of `link_to` for post in security settings 2022-01-15 17:57:51 +01:00
Karina Kwiatek f13e84319e Use `button_to` instead of `link_to` for post in service settings 2022-01-15 17:57:51 +01:00
Andreas Nedbal 75b93d3535 Use `button_to` helper to generate a proper logout button 2022-01-15 09:25:30 +01:00
Andreas Nedbal 435ddf2415 Prevent cancelling "delete all" in inbox still deleting everything 2022-01-15 00:05:17 +01:00
Andreas Nedbal 7d14e93ada Port localebox to TypeScript 2022-01-15 00:05:17 +01:00
Andreas Nedbal bee75584d0 Update i18n import to the aliased retrospring/i18n 2022-01-15 00:05:17 +01:00
Andreas Nedbal 8247c8864f Generate i18n export as TypeScript and move locale logic there 2022-01-15 00:05:17 +01:00
Andreas Nedbal 1a408e1bc6 Port Memes to TypeScript 2022-01-15 00:05:17 +01:00
Andreas Nedbal ef9a08d3fc Clean up legacy entrypoint 2022-01-15 00:05:17 +01:00
Andreas Nedbal f81461d799 Remove jquery-ujs and jquery.turbolinks 2022-01-15 00:05:17 +01:00
Karina Kwiatek 5d7039a2d2 Add test for `Exporter#collect_user_info` 2022-01-14 23:29:49 +01:00
Karina Kwiatek a52de1d318 Fix user data exporter attempting to access `display_name` on `User` 2022-01-14 23:29:49 +01:00
Karina Kwiatek 0246c32df0 Upgrade to Sentry to 4.9.0 2022-01-13 21:42:06 +01:00
Karina Kwiatek 081bfbfeb8 Upgrade to Rails 6.1 2022-01-13 21:42:06 +01:00
Karina Kwiatek d370837311 Upgrade `web-console`
This was throwing some errors in the background on page load (in dev)
2022-01-13 21:42:06 +01:00
Karina Kwiatek b167c4e938 Add tests for privacy settings 2022-01-13 21:42:06 +01:00
Karina Kwiatek 9c84f946ff Fix test failing under macOS 2022-01-13 21:42:06 +01:00
Karina Kwiatek 45854894dc Upgrade to Rails 6.0 2022-01-13 21:42:06 +01:00
Andreas Nedbal 2647a553ec Remove legacy stylesheet pack tag 2022-01-12 22:36:17 +01:00
Andreas Nedbal 691068dad7 Remove old paperclip processor 2022-01-12 22:36:06 +01:00
Georg Gadinger 60a8e3ac7d create timestamp function + sequences on test schema loads too
This fixes a strange issue when running RSpec with changed migrations.

Basically: `ActiveRecord::Migration.maintain_test_schema!` drops the
database and wants to apply the schema from the `schema.rb` again, but
that fails at creating the `answers` table since it can't find the
postgres function `gen_timestamp_id`.

Internally it just calls `bin/rails db:test:load_schema`, so I just
hook it in the same way I do it for `db:schema:load` (used by
`db:setup` ...)
2022-01-11 23:29:30 +01:00
Andreas Nedbal 452c71c128 Update Webpacker npm module to 5.4.3 2022-01-11 23:28:05 +01:00
Andreas Nedbal 55417ecf02 Remove sprockets asset comment 2022-01-11 22:41:37 +01:00
Andreas Nedbal 6e1a62752e Remove (now) unused asset gems 2022-01-11 22:41:37 +01:00
Andreas Nedbal ca30e4420e Install asset dependencies 2022-01-11 22:41:37 +01:00
Andreas Nedbal c6c9bba807 Move flags file to SCSS components 2022-01-11 22:41:37 +01:00
Andreas Nedbal 25408cdcf2 Remove unneeded stylesheet_link_tag 2022-01-11 22:41:37 +01:00
Andreas Nedbal a7b814a52e Include Coloris styles from SCSS 2022-01-11 22:41:37 +01:00
Andreas Nedbal 5912dd0832 Include Croppr styles from SCSS 2022-01-11 22:41:37 +01:00
Andreas Nedbal fd3017afa2 Include toastify styles from SCSS 2022-01-11 22:41:37 +01:00
Andreas Nedbal 3ebe3e00de Remove nprogress 2022-01-11 22:41:37 +01:00
Andreas Nedbal 96fc583c42 Remove image folder asset keepfile 2022-01-11 22:41:37 +01:00
Andreas Nedbal 008f3c7b5d Move stylesheets from assets into javascript/styles/ 2022-01-11 22:41:37 +01:00
Karina Kwiatek 9eb34bf984
Fix answers not submitting on Control/Cmd-Return (#279) 2022-01-11 22:32:43 +01:00
Georg Gadinger 29923fac84 add validator for typoed emails
It happens quite often that people typo their email address (I blame
phone keyboards for that).  Catch common cases in a validator and
tell the user that they have a typo in their email.

Why yes, I did write the tests for this first, thanks for asking!
2022-01-11 19:18:23 +01:00
Andreas Nedbal 515e6d09ff Use text ellipsis instead of three single dots for shortening
Co-authored-by: Karina Kwiatek <6197148+raccube@users.noreply.github.com>
2022-01-10 22:53:58 +01:00
Andreas Nedbal e8d3b9629d Use proper indentation for test values
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
2022-01-10 22:53:58 +01:00
Andreas Nedbal ba280f7996 Add tests for `ApplicationHelper::TitleMethods` 2022-01-10 22:53:58 +01:00
Andreas Nedbal 48c9e6132b Split graph and bootstrap helper tests into own files 2022-01-10 22:53:58 +01:00