Commit Graph

2738 Commits

Author SHA1 Message Date
Georg Gadinger 606629577a make URI.parse part of the validation for the sharing URL
the regexp alone and web browsers allows URLs to contain non-ASCII
characters, which `URI.parse` does not like -- resulting in the inbox
page to suddenly break.

also changed the `redirect_to` in the controller to a `render :edit` so
that validation errors are shown properly
2023-02-10 20:48:15 +01:00
Karina Kwiatek 59c0dce9b4 Disable relationship action buttons while waiting for a response 2023-02-07 23:39:13 +01:00
Georg Gadinger 9a77b89cda use remote_ip 2: electric boogaloo 2023-02-07 07:38:59 +01:00
Andreas Nedbal b0f5294243 Appease the dog overlords 2023-02-05 21:54:51 +01:00
Andreas Nedbal 2cb98fc2e0 Hide the custom share button if the URL is blank 2023-02-05 21:54:51 +01:00
Andreas Nedbal 024127e62f Remove connected user transformation from TwitteredMarkdown 2023-02-05 21:54:51 +01:00
Andreas Nedbal 490a06af27 Allow `sharing_custom_url` to be empty 2023-02-05 21:54:51 +01:00
Andreas Nedbal 47d1f5ccff Validate format of `sharing_custom_url` 2023-02-05 21:54:51 +01:00
Andreas Nedbal 8f0ae5171d Appease the dog overlords 2023-02-05 21:54:51 +01:00
Andreas Nedbal 83aa4ed1bc Implement new sharing layout 2023-02-05 21:54:51 +01:00
Andreas Nedbal a4195a158f Update TypeScript to support new sharing feature 2023-02-05 21:54:51 +01:00
Andreas Nedbal 7589d66686 Remove service reference in question generation 2023-02-05 21:54:51 +01:00
Andreas Nedbal da0a5fb98d Add inbox sharing Stimulus controller 2023-02-05 21:54:51 +01:00
Andreas Nedbal a56db2256b Return sharing options when answering a question 2023-02-05 21:54:51 +01:00
Andreas Nedbal 926be13fa6 Add `Settings::SharingController` 2023-02-05 21:54:51 +01:00
Andreas Nedbal 83d386267a Remove inbox entry options collapse 2023-02-05 21:54:51 +01:00
Andreas Nedbal 52ae7fbb81 Remove service-related views 2023-02-05 21:54:51 +01:00
Andreas Nedbal 06d7db7ff8 Remove ShareWorker 2023-02-05 21:54:51 +01:00
Andreas Nedbal d520755bc2 Remove service model 2023-02-05 21:54:51 +01:00
Andreas Nedbal c327eee38e Remove services controller 2023-02-05 21:54:51 +01:00
Andreas Nedbal a2e45c85bf Add migration to enable sharing for legacy service owners 2023-02-05 21:54:51 +01:00
Georg Gadinger f1a545aea5 use remote_ip 2023-02-04 22:31:53 +01:00
Karina Kwiatek c40a1a4997
Merge pull request #1040 from Retrospring/fix/n+1-notification-type-counters
Prevent 𝑛+1 for notification type counters
2023-02-02 12:09:06 +01:00
Karina Kwiatek 05a90987cd
Merge pull request #1037 from Retrospring/fix/pre-load-mutes
Pre-load own mute relationships in follow lists
2023-02-02 12:07:58 +01:00
Karina Kwiatek 40f7f8f525 Eager load notification targets 2023-02-02 11:03:27 +01:00
Karina Kwiatek 80e312eb3b Appease the dog overlords 2023-02-02 10:38:41 +01:00
Karina Kwiatek 81a6c6ac55 Prevent 𝑛+1 for notification type counters 2023-02-02 00:55:31 +01:00
Andreas Nedbal 7d91c0349a Eagerly load services in action to prevent n+1 query 2023-02-02 00:44:42 +01:00
Karina Kwiatek 825454bbae Fix incorrect type local in followers endpoint 2023-02-01 23:34:33 +01:00
Karina Kwiatek 603e9c501e Pre-load own mute relationships in follow lists 2023-02-01 23:21:09 +01:00
Karina Kwiatek d08198668b Pass user services for question generate turbo frame 2023-01-31 23:10:51 +01:00
Karina Kwiatek 279ed82d6a
Merge pull request #1029 from Retrospring/fix/relationship-list-n+1
Prevent 𝑛+1 on follower/following lists
2023-01-31 22:15:32 +01:00
Karina Kwiatek 226cd10fbc Appease the dog overlords 2023-01-31 14:01:21 +01:00
Karina Kwiatek 8520dbc4b9 De-duplicate relationship pagination logic 2023-01-31 13:59:05 +01:00
Karina Kwiatek 83eeabb525 Use locals for own relationships 2023-01-31 13:46:09 +01:00
Karina Kwiatek 2517b1330a
Merge pull request #1017 from Retrospring/feature/raised-texts
Add new raised text and raised accent text theme fields
2023-01-31 12:57:15 +01:00
Karina Kwiatek 51e15ef195 Appease the dog overlords 2023-01-31 12:30:58 +01:00
Karina Kwiatek 1b6eafd2d1 Prevent 𝑛+1 on follower/following lists 2023-01-31 12:25:55 +01:00
Andreas Nedbal 87aac34f16 Move raised content theming section below general 2023-01-31 08:28:08 +01:00
Georg Gadinger 8b7ba59660 typoed_email_validator: add new endings to the typo list 2023-01-30 06:01:01 +01:00
Karina Kwiatek 4dc5a65f74
Merge pull request #1014 from Retrospring/fix/inbox-services-query
Move fetching of services to controller to avoid n+1 queries
2023-01-29 23:07:46 +01:00
Andreas Nedbal 63b16fd39a Appease the dog overlords 2023-01-29 21:13:38 +01:00
Andreas Nedbal 61a31f97b0 Move theme attributes into their own method 2023-01-29 21:12:33 +01:00
Andreas Nedbal 520d77bb44 Let relevant style overrides use the new raised text colors 2023-01-29 20:44:40 +01:00
Andreas Nedbal ab6e8270df Allow new fields in ThemeController 2023-01-29 20:44:09 +01:00
Andreas Nedbal 6b3342036f Merge branch 'main' into feature/raised-texts 2023-01-29 19:38:32 +01:00
Georg Gadinger a59bc3ef92 typoed_email_validator: add new endings to the typo list 2023-01-29 19:19:35 +01:00
Karina Kwiatek 7c1057acb3
Merge pull request #1012 from Retrospring/bugfix/author-deletes
Fix author-searched deletion in inbox not working
2023-01-29 09:01:24 +01:00
Karina Kwiatek 96659befea
Appease the dog overlords
Co-authored-by: Georg Gadinger <nilsding@nilsding.org>
2023-01-29 00:46:52 +01:00
Karina Kwiatek 19dfc70e2d
Merge pull request #1011 from Retrospring/refactor/cleanup-user-controller
Cleanup user controller
2023-01-28 22:53:48 +01:00
Karina Kwiatek 87894d1e95 Move empty filter check back into show action 2023-01-28 22:42:14 +01:00
Karina Kwiatek 367e2f4b92 Use a local instead of an ivar for passing services into views 2023-01-28 22:24:05 +01:00
Karina Kwiatek 3e2b65d7b8 Move fetching of services to controller to avoid n+1 queries 2023-01-28 21:42:55 +01:00
Karina Kwiatek ab1b034cfb Add type hints for paginators 2023-01-28 21:18:01 +01:00
Karina Kwiatek 32ba17ac72 Eager load profiles in paginators 2023-01-28 21:18:00 +01:00
Andreas Nedbal 6c25594b88 Get the username of the currently searched author correctly 2023-01-28 19:18:02 +01:00
Andreas Nedbal 8dd49d3a8c Remove author search handler 2023-01-28 19:17:04 +01:00
Karina Kwiatek ff866f88ef Appease the dog overlords 2023-01-28 19:09:03 +01:00
Karina Kwiatek e9c397a013 Replace `@title` and `@type` ivars 2023-01-28 19:08:28 +01:00
Karina Kwiatek 6e3bc40c57 Move marking follow notifications as read to an after action 2023-01-28 18:48:14 +01:00
Karina Kwiatek 1c74061c1b
Merge pull request #1004 from Retrospring/cache-headers-on-manifest
Cache headers for web app manifest based on user theme
2023-01-28 11:13:08 +01:00
Karina Kwiatek 999f599029
Merge pull request #1005 from Retrospring/skip-announcements-in-ajax 2023-01-27 23:53:20 +01:00
Karina Kwiatek a34a30349e Use `skip_before_action` instead of redefining action in `AjaxController` 2023-01-27 23:16:41 +01:00
Karina Kwiatek b8b86b069d Cache headers for web app manifest based on user theme 2023-01-27 23:09:09 +01:00
Georg Gadinger 3e3501d201 inbox: update inbox entries in controller 2023-01-27 20:36:22 +01:00
Karina Kwiatek 2ecfe38e5e
Merge pull request #984 from Retrospring/feature/stimulus-cropper
Refactor image cropping into Stimulus controller
2023-01-27 17:22:58 +01:00
Georg Gadinger 8cd0d481c8 bruh 2023-01-24 15:57:34 +01:00
Georg Gadinger 58705fffba mark notifications as "read" in the controller and when you see them
this makes it behave a bit more like the inbox
2023-01-24 15:54:41 +01:00
Andreas Nedbal a0a7f4e124 Add raised-text and raised-accent-text theme variables 2023-01-23 23:36:38 +01:00
Georg Gadinger b99e1b03de notifications: only update all new notifications 2023-01-23 12:25:48 +01:00
Karina Kwiatek 6b771887ab Fix unprivileged comment actions being visible
- Fixes an error when viewing answers containing comments while not logged in
- Hides the report option while not logged in
2023-01-23 09:04:55 +01:00
Andreas Nedbal fe156a38d3 Appease the dog overlords 2023-01-22 17:58:23 +01:00
Andreas Nedbal f0df18ce87 Remove unused IDs on profile crop elements 2023-01-22 17:48:53 +01:00
Andreas Nedbal 6a361e69db Wire up cropper controller in profile settings 2023-01-22 17:44:08 +01:00
Andreas Nedbal 96ed2c864c Add Stimulus cropper controller 2023-01-22 17:43:40 +01:00
Andreas Nedbal 3b1f9bf4cb Remove legacy cropping feature 2023-01-22 17:43:20 +01:00
Karina Kwiatek 529bf40dbe
Merge pull request #979 from Retrospring/fix/pwa-issues
Fix various PWA issues
2023-01-22 12:47:12 +01:00
Andreas Nedbal e18b9518aa Properly align the hashes 2023-01-22 11:14:24 +01:00
Andreas Nedbal c7cc0da04b Appease the dog overlords 2023-01-22 10:57:05 +01:00
Andreas Nedbal c122652275 Increase allowed comment length to 512 characters 2023-01-22 10:36:23 +01:00
Georg Gadinger eb7abb33be user: only provide #questions as GET 2023-01-22 00:04:33 +01:00
Georg Gadinger 14f32aa3c0 question: only provide #show as GET 2023-01-22 00:04:33 +01:00
Georg Gadinger b019f24aaa user: only provide #followers and #followings as GET 2023-01-22 00:04:33 +01:00
Georg Gadinger 989873ba62 user: only provide #show as GET 2023-01-22 00:04:33 +01:00
Georg Gadinger d572734b96 notifications: only provide #index as GET 2023-01-22 00:04:33 +01:00
Georg Gadinger 77529c2217 moderation/reports: only provide #index as GET 2023-01-22 00:04:33 +01:00
Georg Gadinger 144db471d6 moderation/inbox: only provide #index as GET 2023-01-22 00:04:33 +01:00
Georg Gadinger 59d94d7ba0 timeline: only provide #index, #public and #list as GET 2023-01-22 00:04:33 +01:00
Karina Kwiatek 9e25a36196 Fix 'Buffer is not defined' on push enable 2023-01-22 00:04:10 +01:00
Karina Kwiatek e16f460b53 Add option to view comments in rails admin 2023-01-22 00:03:53 +01:00
Karina Kwiatek 95984cfdab Correct app description in web app manifest 2023-01-21 18:26:08 +01:00
Karina Kwiatek d2076c35b5 Remove `?source=pwa`
We can use `@media (display-mode: standalone)` to detect this instead
2023-01-21 18:23:40 +01:00
Karina Kwiatek 3f41d339de Add icons at 144x144
For some reason Chromium requires an icon at this size, however the error in Lighthouse states that the size must be *at least* 144x144 but in fact must be exactly this size.
2023-01-21 18:18:14 +01:00
Karina Kwiatek b9269f0693 Add maskable icons 2023-01-21 18:16:24 +01:00
Karina Kwiatek 73082975c4 Fix web app icon sizes property name 2023-01-21 18:15:18 +01:00
Georg Gadinger 9d7c99fe9b
Merge pull request #974 from Retrospring/refactor/inbox
refactor inbox
2023-01-21 13:59:39 +01:00
Andreas Nedbal df3d4d71bb Appease the dog overlords 2023-01-21 13:44:53 +01:00
Andreas Nedbal de3e04812d Merge branch 'main' into feature/theme-stimulus 2023-01-21 13:40:58 +01:00
Andreas Nedbal fc30bf8cac Add more explicit message for format validation errors 2023-01-21 13:20:52 +01:00
Andreas Nedbal 47bccdb0c3 Fix screen_name regex being too lenient 2023-01-21 13:20:52 +01:00